svelte

Commit Graph

Author	SHA1	Message	Date
Simon H	641e411cf1	fix: ensure spread events are always added (#11535 ) In edge cases it may happen that set_attributes is re-run before the effect is executed. In that case the render effect which initiates this re-run will destroy the inner effect and it will never run. But because next and prev may have the same keys, the event would not get added again and it would get lost. We prevent this by using a root effect. The added test case doesn't fail for some reason without this fix, but it does fail when you test it out manually, so I still added it. Found through https://github.com/sveltejs/svelte/issues/10359#issuecomment-2101167524	2 years ago

Author

SHA1

Message

Date

Simon H

641e411cf1

fix: ensure spread events are always added (#11535 )

In edge cases it may happen that set_attributes is re-run before the effect is executed. In that case the render effect which initiates this re-run will destroy the inner effect and it will never run. But because next and prev may have the same keys, the event would not get added again and it would get lost. We prevent this by using a root effect.
The added test case doesn't fail for some reason without this fix, but it does fail when you test it out manually, so I still added it.
Found through https://github.com/sveltejs/svelte/issues/10359#issuecomment-2101167524

1 Commits (134fcadcf155d68429ed9930ee1e92f2ab9380c3)