svelte

Commit Graph

Author	SHA1	Message	Date
Simon H	e75c9acd18	fix: don't reuse proxies when state symbol refers to stale value (#10343 ) * fix: don't reuse proxies when state symbol refers to stale value When somebody copies over the state symbol property onto a new object (you can retrieve the symbol by using `Reflect.ownKeys(...)`), it was wrongfully assumed that it always relates to the current value. This PR adds an additional check that this is actually the case. This also adds a dev time warning when an object is frozen but contains a state property, which hints at a bug in user land. fixes #10316 * lint * rename * remove warning * update test * changeset --------- Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: Rich Harris <richard.a.harris@gmail.com>	3 years ago

Author

SHA1

Message

Date

Simon H

e75c9acd18

fix: don't reuse proxies when state symbol refers to stale value (#10343 )

* fix: don't reuse proxies when state symbol refers to stale value

When somebody copies over the state symbol property onto a new object (you can retrieve the symbol by using `Reflect.ownKeys(...)`), it was wrongfully assumed that it always relates to the current value. This PR adds an additional check that this is actually the case.
This also adds a dev time warning when an object is frozen but contains a state property, which hints at a bug in user land.
fixes #10316

* lint

* rename

* remove warning

* update test

* changeset

---------

Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Rich Harris <richard.a.harris@gmail.com>

1 Commits (133b805164e747f7237045cdde6d8a12e76229fd)