svelte

Commit Graph

Author	SHA1	Message	Date
Simon H	da6e192e1d	fix: ensure hydration walks all nodes (#12448 ) We've marked several methods used for walking the DOM with a `__NO_SIDE_EFFECTS__` comment. That was good historically, because we didn't need those kept around if its results were unused, but since the hydration changes in #12335 this actually introduces a bug: Because that PR now relies on the hydration nodes being correct due to walking the DOM, tree-shaking unused variables/calls results in the walk being incorrect, leading to bugs Fixes #12422	6 months ago

Author

SHA1

Message

Date

Simon H

da6e192e1d

fix: ensure hydration walks all nodes (#12448 )

We've marked several methods used for walking the DOM with a `__NO_SIDE_EFFECTS__` comment. That was good historically, because we didn't need those kept around if its results were unused, but since the hydration changes in #12335 this actually introduces a bug: Because that PR now relies on the hydration nodes being correct due to walking the DOM, tree-shaking unused variables/calls results in the walk being incorrect, leading to bugs

Fixes #12422

1 Commits (0f6cc2b1edc5c9e16e86728652a57d331d521755)