11488 Commits (0ecfc6079c2925af154a0edc6aad3011d4d488c5)

 

All Branches   

Search

Author	SHA1	Message	Date
Tee Ming	325620ba63	fix: bypass error boundaries for hydration recovery (#18841) ... Fixes #18840 This PR rethrows the hydration error rather than catching it at the boundaries so that the svelte hydration warning can surface ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>	3 weeks ago
Simon Holthausen	87a061a73f	consolidate (maybe_)dirty_effects and dirty_deriveds	3 weeks ago
Simon Holthausen	4d8f4410f7	perf	3 weeks ago
Kunpeng Xie	803f59b171	fix: avoid reinserting dynamic elements during hydration (#18855) ... Hydrating a `<svelte:element>` currently removes and reinserts the DOM node that was already claimed from the server-rendered HTML. This can restart CSS animations and disconnect/reconnect custom elements inside it. Keep claimed elements in place while preserving insertion for client-created elements and later tag changes. Capture the hydration state before rendering children, since empty or void elements can temporarily turn hydration off. Fixes #18852. ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` Validation: - The real Chromium regression fails on unchanged `636eaaaa`: hydration removes all four server-rendered dynamic elements. Client mounting and server rendering pass. - The regression checks node removals and custom-element connection callbacks for ordinary, empty, void, and custom dynamic elements, then changes the tags and removes/recreates an element. - A hydration mismatch regression verifies that different client/server child branches recover while retaining the outer element and its following sibling. - `pnpm test hydration runtime-browser`: 219 passed. - Full `CI=true pnpm test`: 34 test files passed, 7,790 tests passed, 55 existing skips. The real-browser suite ran with Chromium. - `pnpm check`: passed, including build, generated type checks, and treeshakeability checks. - `pnpm lint`: passed. AI assistance: This change and its tests were prepared with OpenAI Codex. The PR description is also AI-assisted. --------- Co-authored-by: paoloricciuti <ricciutipaolo@gmail.com>	3 weeks ago
Simon Holthausen	9fd77d22a5	another	3 weeks ago
Simon Holthausen	408d51b362	tuple->object	3 weeks ago
Simon Holthausen	bd0faecdaa	explanatory comment, remove obsolete deletion	3 weeks ago
Simon Holthausen	494c8b9f08	another	3 weeks ago
Simon Holthausen	3b92502f00	codegolf	3 weeks ago
Simon Holthausen	b08aeee3cf	fix more edge cases	3 weeks ago
Simon Holthausen	7005aae212	more edge case fixes	3 weeks ago
Simon Holthausen	ba4d37a4b4	belts and braces	3 weeks ago
Simon Holthausen	32f4451f2e	fix flushSync (should drain queue before calling the function)	3 weeks ago
Simon Holthausen	31524c792e	e prop for sources	3 weeks ago
Simon Holthausen	91d215664f	resolve some todos	3 weeks ago
Simon Holthausen	15ccee8e0f	cleanup	3 weeks ago
Simon Holthausen	ddffe3efe2	align	3 weeks ago
Simon Holthausen	62fafd63ab	align	3 weeks ago
Simon Holthausen	5de9201dc2	tweak	3 weeks ago
Simon Holthausen	64bd3a18f1	tweak test for new behavior	3 weeks ago
Simon Holthausen	d592d8aebd	original test obsolete, refactor into a new test	3 weeks ago
Simon Holthausen	387995cd63	remove some dead weight	3 weeks ago
Simon Holthausen	ab75873a57	more fixes	3 weeks ago
Simon Holthausen	33e3540bb9	fork fix	3 weeks ago
Simon Holthausen	e5e45aa11b	getting close	3 weeks ago
github-actions[bot]	636eaaaa6f	Version Packages (#18750) ... This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.57.1 ### Patch Changes - fix: cancel deferred event listeners during cleanup ([#18749](https://github.com/sveltejs/svelte/pull/18749)) - fix: preserve global CSS in components without scopable elements ([#18793](https://github.com/sveltejs/svelte/pull/18793)) - fix: reduce SSR render result garbage collection ([#18798](https://github.com/sveltejs/svelte/pull/18798)) - fix: resolve the fallback of an each block in the enclosing scope ([#18803](https://github.com/sveltejs/svelte/pull/18803)) - perf: speed up parser interactions with Acorn or avoid them where possible ([#18740](https://github.com/sveltejs/svelte/pull/18740)) - fix: prevent effect tree of batches from interfering with each other ([#18508](https://github.com/sveltejs/svelte/pull/18508)) - fix: serialize input default values during server rendering ([#18733](https://github.com/sveltejs/svelte/pull/18733)) - fix: remove `WAS_MARKED` flag in favor of `Set` ([#18127](https://github.com/sveltejs/svelte/pull/18127)) - fix: throw `set_context_after_init` when `setContext` is called after an `await` during SSR ([#18739](https://github.com/sveltejs/svelte/pull/18739)) - fix: make Object.hasOwn reactive for state proxy ownership changes ([#18838](https://github.com/sveltejs/svelte/pull/18838)) - fix: keep `$state.eager` when used as a variable initializer ([#18809](https://github.com/sveltejs/svelte/pull/18809)) - perf: avoid regex matching in parser where possible ([#18736](https://github.com/sveltejs/svelte/pull/18736)) - fix: in non-async mode, only push variable to current_sources when active_reaction is updating ([#18550](https://github.com/sveltejs/svelte/pull/18550)) - fix: recognise `aria-braillelabel` and `aria-brailleroledescription` as known ARIA attributes ([#18765](https://github.com/sveltejs/svelte/pull/18765)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	4 weeks ago
Simon Holthausen	230b829384	oops	4 weeks ago
Rich Harris	8030ff2a2c	fix: remove incorrect special handling of :export pseudo-selectors (#18839) ... #18793 added special handling for `:export` selectors, but this is incorrect. `:export` is (apparently) part of [Interoperable CSS](https://github.com/css-modules/icss) but Svelte doesn't (and shouldn't) know what that is. No changeset because #18793 is unreleased, and the changeset in that PR didn't mention ICSS	4 weeks ago
Simon Holthausen	6cb26772d3	another	4 weeks ago
Simon Holthausen	2cfc5819d0	fucking hell forks are hard	4 weeks ago
svelte-triage-bot[bot]	a72dc8eadb	fix: make Object.hasOwn reactive for state proxies (#18838) ... Fixes #18837 ### What changed State proxies now establish a per-property reactive dependency when `Object.hasOwn(proxy, prop)` invokes the `getOwnPropertyDescriptor` trap. Property additions and deletions therefore invalidate the expression, consistently with the `prop in proxy` operator. The source creation uses the same eligibility constraints as the existing `has` trap so inherited properties retain their existing semantics. A runtime-runes regression sample covers both adding and deleting the observed property in DOM and hydration modes. ### Tests and linting - `FILTER=object-has-own-reactive pnpm test runtime-runes --reporter=dot` — 4 passed - `pnpm exec vitest run packages/svelte/src/internal/client/proxy.test.ts --reporter=dot` — 8 passed - `pnpm test runtime-runes --reporter=dot` — 2707 passed, 34 skipped - `pnpm test --reporter=dot` — 7786 passed, 55 skipped - `cd packages/svelte && pnpm check` — passed - `pnpm format` — passed - `pnpm lint` — passed Includes a patch changeset for `svelte`. <!-- svelte-triage-bot:feedback-baseline:81ef2357a99a2592312d5483e38be3f6ddeb4be5 --> --------- Co-authored-by: svelte-triage-bot <team@svelte.com> Co-authored-by: Rich Harris <rich.harris@vercel.com>	4 weeks ago
Simon Holthausen	a7c16935a5	equality check against what the batch sees to update its value	4 weeks ago
Simon Holthausen	bf0ecc0578	more	4 weeks ago
Simon Holthausen	9143c90b04	more messy experimentation	4 weeks ago
Simon Holthausen	e017878175	messy wip	4 weeks ago
Simon Holthausen	762e5cb6d8	bring over some tests from entangle batch PR	4 weeks ago
Simon Holthausen	4bdf9e3db4	apply needs to happen before commit callbacks because they can create new batches, causing bugs	4 weeks ago
Simon Holthausen	70bb532c0d	more	4 weeks ago
Simon Holthausen	e82d7494f7	wip	4 weeks ago
Nic Polumeyv	6eb720a1b7	chore: scope.js stops importing from the analysis visitors (#18787) ... `phases/scope.js` imported `validate_identifier_name` from `2-analyze/visitors/shared/utils.js`, which imports `get_rune` back from `scope.js`. The check reads a `Binding` and `Scope.declare` is its main caller, so it now lives in `scope.js`. No behaviour change.	1 month ago
Nic Polumeyv	e6ae460caa	chore: analysis and transform stop importing each other (#18786) ... Analysis imported `should_proxy` from `3-transform/client/utils.js` and transform imported `check_graph_for_cycles` from `2-analyze/utils`. The graph search now lives in `compiler/utils`, `should_proxy` in `phases/scope.js` next to the bindings it reads. No behaviour change.	1 month ago
Nic Polumeyv	5981c060d2	chore: move parser helpers next to their users (#18785) ... Phase 1 imported `disallow_children` from phase 2, `fuzzymatch` sat in the parser's utils while only analysis and `extract_svelte_ignore` used it, `create_fragment` had a file to itself although `create_attribute` lives in `phases/nodes.js`, and `push_array` had a single caller. Each now sits next to its users: `create_fragment` and `disallow_children` in `phases/nodes.js`, `fuzzymatch` in `compiler/utils`, `push_array` inside `mapped_code.js`. Four files fewer, no behaviour change.	1 month ago
svelte-triage-bot[bot]	f2ad10ecd2	fix: preserve global CSS without scopable elements (#18793) ... ## Summary - mark fully global selectors as used without requiring a scopable component element - preserve exact ICSS `:export` rules under the same conditions - keep elements inside `<svelte:head>` excluded from CSS hash injection - add a regression test covering both reported selector forms Fixes #18792	1 month ago
svelte-triage-bot[bot]	a8a9b02e38	fix: reduce SSR render result garbage collection (#18798) ... Fixes #18797. ### Problem SSR `render()` is lazy, but the wrapper benchmark discarded its result and therefore measured almost no rendering work. When `.body` was consumed, each render result's own accessor properties caused substantial garbage-collection overhead. ### Fix - Consume `render(App).body` in both the warmup and measured SSR benchmark loops. - Move lazy render-result properties onto a shared `RenderResult` prototype. - Memoize synchronous output and the asynchronous render promise while preserving lazy sync/async API behavior. - Add a regression test ensuring exposed render-result properties are inherited. - Add a patch changeset for `svelte`. The benchmark now deliberately selects the synchronous lazy-render path by reading `.body`, so the process-wide async flag imported by the reactivity benchmarks does not determine this benchmark's render mode. ### Performance on this host | Case | Time | GC time | | --- | ---: | ---: | | main, output discarded | 0.20 ms | 0.00 ms | | main, `.body` consumed before fix | 163.04 ms | 62.68 ms | | `svelte@5.38.10` | 110.05 ms | 1.39 ms | | fixed, `.body` consumed | 104.79 ms | 2.43 ms | ### Tests - `pnpm test packages/svelte/src/internal/server/renderer.test.ts` — 53 passed - `pnpm test server-side-rendering` — 234 passed, 2 skipped - `pnpm test` — 7,771 passed, 55 skipped - `pnpm lint` - `pnpm check` - `pnpm format` - `git diff --check` <!-- svelte-triage-bot:feedback-baseline:116724e3b641c84ed56b2a60d494b6cb2298bbb3 --> Co-authored-by: svelte-triage-bot <team@svelte.com>	1 month ago
Nic Polumeyv	6be176df2f	fix: resolve the fallback of an each block in the enclosing scope (#18803) ... In `phases/scope.js`, `EachBlock` visits `node.fallback` with the block's own scope, so `{:else}` resolves the loop's name to the each context. With `let item = $state('outer')` outside and `{#each items as item}…{:else}<button onclick={() => (item = 'changed')}>` the compiler reports "Cannot reassign or bind to each block argument" for a variable that is not the block's argument. The fallback renders when there is nothing to iterate, so it is visited in the enclosing scope, as an await block's `pending` is.	1 month ago
Xia Chao	34b13ac3e4	fix: keep `$state.eager` when used as a variable initializer (#18809) ... fixes #18808 If you write `let x = $state.eager(...)`, the client compiler used to delete that line and then still read `x`. The page crashed with `x is not defined`. Server rendering kept the binding. Using `$state.eager(...)` directly in the markup already worked. This puts the `let` / `const` form on the same path as `$state.snapshot`. Added a runtime-runes sample that fails without this change. Co-authored-by: Xia Chao <236466140+bun-unsafe@users.noreply.github.com>	1 month ago
Simon H	ce89035ecb	fix: prevent effect tree of batches from interfering with each other (#18508) ... While working on another Svelte feature I noticed a bug that boils down to batches interfering with each other through the effect tree: If batch A schedules an effect, it is walked up to the root (possibly). Now if in the meantime batch B also wants to schedule effects, it can have unintended consequences. Normally this does not happen, since it's extremely hard to run into this situation. There's basically two cases: Either an unfortunate timing of microtasks, or during flushing effects are scheduling new effects which messes with a `#commit()` right after (the test case does this). To fix this we now defer walking up the tree until the batch is actually processed. That way we set + unset the markers on the branches synchronously so there's no chance of another batch interfering.	1 month ago
Simon H	d16099ef0f	fix: remove `WAS_MARKED` flag in favor of `Set` (#18127) ... Removes the `WAS_MARKED` logic in favor of a simple `Set` heuristic: If `mark_reactions` goes beyond a certain count, initialize it, otherwise keep it `null`. Balances the common case of not having many transitive dependencies with the edge case of cyclic dependencies as was seen in #16658 (I rechecked that reproduction and it remains fast with this change). I ran the benchmark against this and it doesn't hit the `Seen` heuristic once (i.e. even the benchmark doesn't have this extreme level of dependencies where it becomes noticeable). Fixes #18123, supersedes #18124 --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	1 month ago
Bao Nguyen	5895c637b0	fix: recognise `aria-braillelabel` and `aria-brailleroledescription` as known ARIA attributes (#18765)	1 month ago
JY Wey	9e69544238	fix: in non-async mode, only push variable to current_sources when active_reaction is updating (#18550) ... fix: #16814 in non-async mode, when the derived inside `SvelteDate` is created and evaluated, the `#reaction` is from the `active_reaction` when the `SvelteDate` instance is created, which could possible in NON_UPDATING state, so the derived should not be added to `current_sources` to prevent re-run. --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	1 month ago