11451 Commits (svelte-custom-renderer)

 

All Branches   

Search

Author	SHA1	Message	Date
Simon H	adba758067	fix: don't reset status of uninitialized deriveds (#18054) ... If a new branch is created (e.g. if block becomes truthy) inside a fork and a derived is read inside the new branch for the first time, it will get reactions but its true value will stay uninitialized due to the fork. If the fork then commits, it will NOT change its value because it will not reexecute: there is no effect running after commit telling it to do that, because it was only read inside new effects which already ran while still inside the fork. Now, when that branch is removed (e.g. if block becomes falsy), the derived loses its reactions again and becomes disconnected, at which point the status is reset. So we end up with a maybe_dirty or clean derived and an uninitialized value, causing breakage if it's called again afterwards. The fix is to not reset the status in this case. Fixes https://github.com/sveltejs/kit/issues/15126 Fixes https://github.com/sveltejs/kit/issues/15318 Fixes https://github.com/sveltejs/kit/issues/15061	4 months ago
ottomated	14adb8caa9	fix: correct types for `ontoggle` on <details> elements (#18063) ... `<details>` elements fire `ontoggle` as ToggleEvents ([source](https://developer.mozilla.org/en-US/docs/Web/API/HTMLElement/toggle_event)), but they're currently just typed as Event. ### Before submitting the PR, please make sure you do the following - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [ ] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint`	4 months ago
Matia	7a2a17557c	docs: add CSS custom properties section to style directive (#18065) ... Adds documentation for using CSS custom properties with the `style:` directive. I think this was lost at some point during the great transition. It's only mentioned in the [best practices](https://svelte.dev/docs/svelte/best-practices#Using-JavaScript-variables-in-CSS) section, so I thought it would make sense to include it.	4 months ago
Paolo Ricciuti	b391869905	Merge branch 'main' into svelte-custom-renderer	4 months ago
Rich Harris	f8ef6de325	chore: squelch hydration warnings in tests (#18046) ... Gets rid of some annoying console spam. I don't totally understand why `warnings` isn't populated by the time the assertions happen (it seems to happen just afterwards, except if I sleep for a few milliseconds and then do the assertion the warnings get swallowed altogether?) but for right now I don't much care	5 months ago
Rich Harris	8ee2169609	chore: improve benchmarks (#18061) ... This makes the benchmarks slightly more honest — it adds the async flag, and a benchmark that tests the (common) scenario where most effects are clean. Relevant to #18035, will self-merge so we can do a fresh comparison	5 months ago
Rich Harris	206974a5cd	chore: generate markdown tables of CPU profiles (#18059) ... extracted from #18035 — this should have been part of #18047 but I missed it off, oops. Will self-merge so it doesn't get in the way of #18035, and because the `performance-investigation` skill is predicated on this code existing --------- Co-authored-by: Copilot Autofix powered by AI <62310815+github-advanced-security[bot]@users.noreply.github.com>	5 months ago
paoloricciuti	0b3d17986e	chore: better types	5 months ago
paoloricciuti	4440cec525	chore: better types	5 months ago
paoloricciuti	801c8ef4ae	fix: don't emit HTML warnings in custom renderer compile	5 months ago
paoloricciuti	883611fd8b	chore: remove duplicate error	5 months ago
Paolo Ricciuti	0031d8fbdd	Merge branch 'main' into svelte-custom-renderer	5 months ago
paoloricciuti	7d37884d38	fix: throw error if snippet is rendered in renderer different from compiler	5 months ago
paoloricciuti	ce4442d663	fix: allow DOM components to be mounted into custom renderers (require manual handling)	5 months ago
paoloricciuti	7f9021a056	chore: move init operations into separate module	5 months ago
Rich Harris	a9530e5330	chore: add labels to more internal deriveds (#18050) ... tiny QoL thing	5 months ago
Paolo Ricciuti	da9efc5ddb	Merge branch 'main' into svelte-custom-renderer	5 months ago
Rich Harris	704e3bb5f0	chore: agent hints for perf investigations (#18047) ... This adds some hints in an `AGENTS.md` for how to conduct performance investigations, along with a utility for comparing profiles from different branches to identify hotspots. We will likely want to put other stuff in `AGENTS.md` in future but I figured we could start with something immediately useful. It also tweaks the comparison script — rather than nuking results from existing branches, it keeps them around so that we don't need to re-run benchmarks (which takes a long time) for branches that haven't changed. --------- Co-authored-by: vercel[bot] <35613825+vercel[bot]@users.noreply.github.com>	5 months ago
Paolo Ricciuti	11c878766a	Merge branch 'main' into svelte-custom-renderer	5 months ago
Rich Harris	c93e251654	fix: never set derived.v inside fork (#18037) ... This started out as me implementing https://github.com/sveltejs/svelte/pull/17998/changes#r3018047965, but then I realised that I'd also fixed the bug that #17998 addresses. So I guess it's an alternative to that PR --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>	5 months ago
paoloricciuti	ac62333832	fix: return component exports from `render`	5 months ago
paoloricciuti	8a82750657	chore: left TODO for style manipulation	5 months ago
paoloricciuti	ce3b8ee2d2	fix: explicit `is_html` false if render is not null	5 months ago
paoloricciuti	28e70f8990	fix: allow one "window" for each renderer	5 months ago
paoloricciuti	f68d6af173	fix: handle template as a normal tag	5 months ago
paoloricciuti	9c1d17e51f	fix: handle autofocus in `set_attributes`	5 months ago
paoloricciuti	8a8b779586	fix: remove anchor from target on `unmount`	5 months ago
paoloricciuti	62d1ce7822	fix: default to empty props if props is undefined in render	5 months ago
paoloricciuti	49511b4a83	fix: `defaultValue`/`defaultChecked` in spread attributes	5 months ago
paoloricciuti	184eaeface	fix: allow for an offscreen_anchor per renderer	5 months ago
paoloricciuti	84ee6a0e55	fix: don't emit `selectedcontent` in custom render mode	5 months ago
paoloricciuti	8f8ac035cf	fix: special value handling	5 months ago
paoloricciuti	37bf4452f5	fix: event listeners in spread	5 months ago
paoloricciuti	020dc9e1bb	fix: disable `@html` in custom renderer	5 months ago
paoloricciuti	9ccd0b4e08	fix: cleanup in `finally`	5 months ago
paoloricciuti	5c0e54ecff	fix: skip microtask in custom renderer `create_event`	5 months ago
Paolo Ricciuti	81bf921672	Merge branch 'main' into svelte-custom-renderer	5 months ago
Rich Harris	345b8ed69f	chore: keep previous benchmark runs around (#18049) ... extracted from #18047 – will self-merge this bit	5 months ago
Paolo Ricciuti	cdc57e0737	Merge branch 'main' into svelte-custom-renderer	5 months ago
Rich Harris	e402b2d0d6	chore: write `pnpm bench:compare` report to disk (#18045) ... will give this a quick self-merge to unblock	5 months ago
Rich Harris	99b1467ba4	chore: generate CPU profiles when running benchmarks (#18043) ... This causes `pnpm bench` and `pnpm bench:compare` to generate `.cpuprofile` files for each benchmark, which should in theory make it easier to understand how different branches affect performance (and find opportunities for optimisation). These files can be opened directly in VS Code and other editors, or in [profiler.firefox.com](https://profiler.firefox.com), [speedscope.app](https://www.speedscope.app), Chrome's performance devtools and so on.	5 months ago
paoloricciuti	8c70351882	chore: changeset	5 months ago
paoloricciuti	02d23d1bf0	fix: class toggle	5 months ago
Paolo Ricciuti	63d87445db	Merge branch 'main' into svelte-custom-renderer	5 months ago
paoloricciuti	65b23d19fb	fix: options in migrate	5 months ago
paoloricciuti	d9a5f167f2	fix: import	5 months ago
Rich Harris	edcbb0e640	fix: invalidate `@const` tags based on visible references in legacy mode (#18041) ... closes #17992	5 months ago
Rich Harris	ff3495dc05	fix: disallow `--` in `idPrefix` (#18038) ... supersedes #17993	5 months ago
Scott Wu	51629ec7bd	docs: update references to `vite-plugin-svelte` (#18027) ... ### Before submitting the PR, please make sure you do the following - [ ] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [ ] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [ ] This message body should clearly illustrate what problems it solves. - [ ] Ideally, include a test that fails without this PR but passes with it. - [ ] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [ ] Run the tests with `pnpm test` and lint the project with `pnpm lint` --------- Co-authored-by: Rich Harris <hello@rich-harris.dev> Co-authored-by: Rich Harris <rich.harris@vercel.com>	5 months ago
dagecko	e0f925116c	fix: pin 9 actions to commit SHA (#18025) ... Re-submission of #18017. Had a problem with my fork and had to delete it, which closed the original PR. Apologies for the noise. ## Summary This PR pins all GitHub Actions to immutable commit SHAs instead of mutable version tags. - Pin 9 unpinned actions to full 40-character SHAs - Add version comments for readability ## Changes by file | File | Changes | |------|---------| | autofix.yml | Pinned actions to SHA | | ci.yml | Pinned actions to SHA | | pkg.pr.new.yml | Pinned actions to SHA | | release.yml | Pinned actions to SHA | ## A note on internal action pinning This PR pins all actions including org-owned ones. Best practice is to pin everything — the tj-actions/changed-files attack was an internally maintained action that was compromised, and every repo referencing it by tag silently executed attacker code. That said, it's your codebase. If you'd prefer to leave org-owned actions unpinned, let us know and we'll adjust the PR. ## How to verify Review the diff — each change is mechanical and preserves workflow behavior: - **SHA pinning**: `action@v3` becomes `action@abc123 # v3` — original version preserved as comment - No workflow logic, triggers, or permissions are modified I wrote a scanner called Runner Guard and open sourced it [here](https://github.com/Vigilant-LLC/runner-guard). If you have any questions, reach out. I'll be monitoring comms. \- Chris Nyhuis (dagecko)	5 months ago