svelte

Commit Graph

Author	SHA1	Message	Date
Paolo Ricciuti	89b6a939fe	fix: wrap `Promise.all` in `save` during SSR (#18178 ) Closes #18168 Not sure if there's a deeper issue in play because the error it's only really there if you also add a title to the component. I think the issue is that with multiple arguments the top level `Promise.all` is not wrapped in `save` and that probably causes a race condition with `title` that sets the context back to `null` in a `finally`. One issue is that now the generated code looks like this ```js const [$$0, $$1] = (await $.save(Promise.all([ (async () => (await $.save(user()))().name)(), (async () => (await $.save(user()))().image)() ])))(); ``` which seems a bit redundant, but I'm not sure if we can get rid of the inner `save` since they are indeed awaiting something.	4 months ago

Author

SHA1

Message

Date

Paolo Ricciuti

89b6a939fe

fix: wrap `Promise.all` in `save` during SSR (#18178 )

Closes #18168

Not sure if there's a deeper issue in play because the error it's only
really there if you also add a title to the component. I think the issue
is that with multiple arguments the top level `Promise.all` is not
wrapped in `save` and that probably causes a race condition with `title`
that sets the context back to `null` in a `finally`.

One issue is that now the generated code looks like this

```js
const [$$0, $$1] = (await $.save(Promise.all([
	(async () => (await $.save(user()))().name)(),
	(async () => (await $.save(user()))().image)()
])))();
```
which seems a bit redundant, but I'm not sure if we can get rid of the
inner `save` since they are indeed awaiting something.

1 Commits (remove-was-marked)