Simon H
b8607f8765
fix: silence a11y attribute warnings when spread attributes present ( #15150 )
...
Fixes #15067
8 months ago
Simon H
f5406c952e
fix: widen ownership when calling setContext ( #15153 )
...
Instead of doing ownership addition at each `getContext` call site, we do it once as the `setContext` call site and make the state basically global.
- avoids potential false positives in edge cases
- makes the whole thing more performant, especially around things like calling `getContext` inside a list item component
- false negatives are unlikely from this
fixes #15072
8 months ago
7nik
522557559f
fix: do not prune selectors like `:global(.foo):has(.scoped)` ( #15140 )
...
Fixes #14910
The issue occurs only when :has() targets at a component's root element and because include_self is false.
I came to the conclusion that this is the same case as :root:has(.scoped).
8 months ago
github-actions[bot]
c8bbb15693
Version Packages ( #15139 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
Dominic Gannaway
13a6d555c0
fix: improve derived connection to ownership graph ( #15137 )
...
* fix: improve derived connection to ownership graph
* revised
* revised
* revised
* revised
* feedback
* feedback
* invasive change
* fix bugs
* fix other bug
8 months ago
7nik
9410ad0318
fix: correctly look for sibling elements inside blocks and components ( #15106 )
...
Fixes #15027 and fixes #14995
When the target element is inside a block or component, get_following_sibling_elements was looking only for sibling elements after the block/component. This PR fixes it by starting the search from the begging of the block/component and skipping nodes that go before the target element.
8 months ago
github-actions[bot]
b2c8224a73
Version Packages ( #15118 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
Dominic Gannaway
fc4dd2dec4
fix: lazily connect derievds (in deriveds) to their parent ( #15129 )
8 months ago
Elliott Johnson
3f8ce21f47
fix: Add `bind:focused` to `HTMLAttributes` ( #15122 )
...
* Revert "fix: ensure untrack correctly retains the active reaction (#15065 )"
This reverts commit 2ad519542d
.
* feat: Add `bind:focused` to `HTMLAttributes`
* Revert "Revert "fix: ensure untrack correctly retains the active reaction (#15065 )""
This reverts commit f4e98bf89f
.
* changeset
* tests
8 months ago
Rich Harris
0e0f01ee1c
fix: disallow $state/$derived in const tags ( #15115 )
8 months ago
github-actions[bot]
357e1a74b4
Version Packages ( #15088 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
Trevor N. Suarez
d47f4f5908
fix: expand boolean attribute support ( #15095 )
...
* Adding test for expected boolean attribute support
* Improving support for more boolean attributes:
Added:
- `defer`
- `disablepictureinpicture`
- `disableremoteplayback`
Improved:
- `allowfullscreen`
- `novalidate`
* Skipping JSDOM version of boolean attribute test
JSDOM lacks support for some attributes, so we'll skip it for now.
See:
- `async`: https://github.com/jsdom/jsdom/issues/1564
- `nomodule`: https://github.com/jsdom/jsdom/issues/2475
- `autofocus`: https://github.com/jsdom/jsdom/issues/3041
- `inert`: https://github.com/jsdom/jsdom/issues/3605
- etc...: https://github.com/jestjs/jest/issues/139#issuecomment-592673550
* Adding changeset
8 months ago
Edoardo Cavazza
d17f5c748d
fix: add check for is attribute ( #15086 )
...
Fixes #15085
Add a check for is attribute in is_custom_element_node function.
8 months ago
Rich Harris
7740d4576b
fix: optimise || expressions in template ( #15092 )
8 months ago
Theodore Brown
c2e805f05c
fix: consistently set value to blank string when value attribute is undefined ( #15057 )
...
Fixes #4467
8 months ago
Rich Harris
8bba70b8e3
fix: avoid double deriveds in component props ( #15089 )
...
* fix: prevent double deriveds in component props
* unused
* reuse mechanism
* move code to where it is used
* changeset
8 months ago
Trevor N. Suarez
eee808fb79
fix: correctly handle `novalidate` attribute casing ( #15083 )
...
This PR fixes #15082 by correctly handling the HTML element novalidate attribute casing through noValidate DOM property mapping.
8 months ago
Paolo Ricciuti
7da86ef80c
fix: don't throw for `undefined` non delegated event handlers ( #15087 )
...
* fix: don't throw for `undefined` non delegated event handlers
* chore: update typings
8 months ago
github-actions[bot]
ee024ffd0e
Version Packages ( #15080 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
Dominic Gannaway
09510c8c5c
fix: address regression with untrack ( #15079 )
...
* fix: address regression with untrack
* add test
8 months ago
github-actions[bot]
c75f1f5f2f
Version Packages ( #15052 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
Paolo Ricciuti
5ad6a0cdc3
fix: initialize `files` bind on hydration ( #15059 )
8 months ago
Dominic Gannaway
2ad519542d
fix: ensure untrack correctly retains the active reaction ( #15065 )
...
* fix: ensure untrack correctly retains the active reaction
* fix: ensure untrack correctly retains the active reaction
8 months ago
ComputerGuy
5f6525f416
fix: omit unnecessary nullish coallescing in template expressions ( #15056 )
...
* omit unnecessary nullish coallescing in template expressions
* add tests
8 months ago
Rich Harris
700029bd4d
fix: more efficient template effect grouping ( #15050 )
...
* WIP
* drive-by
* group attribute updates
* fix
* more
* unused
* more
* WIP
* unused
* simplify
* simplify
* simplify
* more
* unused
* unused
* more
* tweak
* update how class/style directives are handled
* more
* more
* simplify
* changeset
8 months ago
github-actions[bot]
a9d1f46dbb
Version Packages ( #15021 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
Rich Harris
509ba568f3
fix: create fewer deriveds for concatenated strings ( #15041 )
...
* fix: create fewer deriveds for concatenated strings
* stringified_text -> expression
8 months ago
Puru Vijay
2aefc5430d
feat(elements): Expose ClassValue ( #15035 )
...
* Push
* Cleanup
* Add changeset
* Remove redundant string
* Update documentation/docs/03-template-syntax/18-class.md
Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>
* Update documentation/docs/03-template-syntax/18-class.md
---------
Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>
8 months ago
Paolo Ricciuti
973b51d168
fix: correctly parse leading comments in function binding ( #15020 )
...
* fix: correctly parse leading comments in function binding
* chore: fix lint
8 months ago
github-actions[bot]
1d3c4397b2
Version Packages ( #15010 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
Rich Harris
ff79704ab8
fix: bump esrap ( #15015 )
...
* chore: bump esrap
* changeset
8 months ago
Dominic Gannaway
5419610833
fix: ensure resume effects are scheduled in topological order ( #15012 )
...
* fix: ensure resume effects are scheduled in topological order
* fix: ensure resume effects are scheduled in topological order
8 months ago
Paolo Ricciuti
360ee70dcb
fix: remove listener on `bind_current_time` teardown ( #15013 )
...
Fixes #15008
8 months ago
Paolo Ricciuti
dfa97a5e64
feat: allow every children in `template` tags ( #15007 )
...
* feat: allow every children in `template` tags
* Update .changeset/dry-mails-return.md
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
8 months ago
github-actions[bot]
a1698c63ec
Version Packages ( #15001 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
Dominic Gannaway
dae4c5f5e1
fix: ensure signal write invalidation within effects is consistent ( #14989 )
...
* fix: ensure signal write invalidation within effects is persistent
* fix: ensure signal write invalidation within effects is persistent
* fix: ensure signal write invalidation within effects is persistent
* address feedback
8 months ago
Paolo Ricciuti
a129592e5b
feat: allow const tag inside `svelte:boundary` ( #14993 )
...
* feat: allow const tag inside `svelte:boundary`
* chore: add better test
* docs: update docs for `@const`
8 months ago
github-actions[bot]
efa5acf24e
Version Packages ( #14970 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
Paolo Ricciuti
8a1acac084
fix: never consider inert boundary effects ( #14999 )
...
* fix: never consider inert boundary effects
* chore: inline bitwise
8 months ago
Paolo Ricciuti
9b6e65fbeb
fix: correctly transform `pre` with no content ( #14973 )
...
Closes #14971
8 months ago
Paolo Ricciuti
41fb51349e
fix: store access on component destroy ( #14968 )
...
Co-authored-by: Oscar Dominguez <dominguez.celada@gmail.com>
8 months ago
Dominic Gannaway
dbe5818560
fix: wrap each block expression in derived to encapsulte effects ( #14967 )
...
* fix: wrap each block expression in derived to encapsulte effects
* add test
* Update .changeset/tender-apples-scream.md
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
8 months ago
github-actions[bot]
dc8ae825b8
Version Packages ( #14965 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
Dominic Gannaway
bdc02008e4
fix: reset dependency read versions after reaction execution ( #14964 )
...
* fix: reset dependency read versions after reaction execution
* fix: reset dependency read versions after reaction execution
* fix: reset dependency read versions after reaction execution
* fix: reset dependency read versions after reaction execution
* fix: reset dependency read versions after reaction execution
* chore: add test
* changeset
---------
Co-authored-by: paoloricciuti <ricciutipaolo@gmail.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
8 months ago
github-actions[bot]
b7400ae93b
Version Packages ( #14959 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
Rich Harris
c0842d1459
fix: properly add owners to function bindings ( #14962 )
...
Closes #14956
8 months ago
Rich Harris
68cffa8489
fix: apply `overflow: hidden` style when transitioning elements, where necessary ( #14930 )
...
* fix: apply `overflow: hidden` style when transitioning elements, where necessary
* notes to self
8 months ago
Rich Harris
79a67c9561
fix: account for parent scale when animating elements ( #14957 )
...
* WIP fix flip
* fix: account for parent scale when animating elements
8 months ago
github-actions[bot]
80d9f9996f
Version Packages ( #14953 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
Simon H
9aae463ae1
fix: silence false-positive statel value warning ( #14958 )
...
fixes #14687
8 months ago
Simon H
a2565efa37
docs: tweak "invalid assignment" compiler error message ( #14955 )
...
* docs: tweak "invalid assignment" compiler error message
fixes #14702
* tweak wording
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
8 months ago
Rich Harris
ce4f9722da
fix: remove bindable prop validation ( #14946 )
8 months ago
github-actions[bot]
9b71eea35d
Version Packages ( #14943 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
Rich Harris
d41801c75f
feat: warn on using `slide` transition with invalid `display` styles ( #14936 )
...
* feat: warn on using `slide` transition with table elements
* more generic
* more generic
8 months ago
Rich Harris
4d2cb2734b
fix: prevent long delays causing erratic spring behaviour ( #14940 )
8 months ago
Rich Harris
d245bab63a
feat: allow non-numeric values to be tweened by snapping immediately to new value ( #14941 )
8 months ago
Rich Harris
adee13d98c
fix: account for min-width/height in `slide` transition ( #14942 )
8 months ago
Dominic Gannaway
9c20eb4815
chore: improve signal performance by reducing duplicate deps ( #14945 )
...
* chore: expand benchmark iterations
* chore: improve signal performance by reducing duplicate deps
* feedback
* oops
8 months ago
Caique Torres
48e3db21c1
fix: default values in object destructuring ( #14554 )
...
* fix: enhance string/expression length check and fix closing character issues
* docs: add documentation for unterminated_string_constant error
* test: add tests for object destructuring with default values in "each" blocks
* Update .changeset/clean-planets-rush.md
* refactor: clean up unnecessary comments and whitespace
* fix: resolve formatting issues
* simplify
* tweak
* regenerate
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
9 months ago
github-actions[bot]
4aadb34c02
Version Packages ( #14924 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
9 months ago
Simon H
08061c85da
fix: guard against `customElements` being unavailable in browser extension contexts ( #14933 )
...
fixes #14739
9 months ago
Simon H
8241096b06
fix: treat `inert` as a boolean attribute ( #14935 )
...
* fix: treat `inert` as a boolean attribute
fixes #14731
* remove solo: true
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
9 months ago
Matthijs
c8865bb4a7
fix: make Tween with duration 0 set current to target immediately ( #14937 )
...
* fix: Make Tween duration 0 set current to target immediately
* Run prettier on test file
* tweak
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
9 months ago
Rich Harris
77378688b9
fix: remove leading newline from `<pre>` contents ( #14922 )
...
... if it's not followed by another newline, according to the spec
Fixes #14767
---------
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>
9 months ago
github-actions[bot]
fb67bad5b0
Version Packages ( #14921 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
9 months ago
Paolo Ricciuti
72a6c7263c
fix: don't throw `bind_invalid_export` if there's also a bindable prop with the same name ( #14813 )
9 months ago
Dominic Gannaway
cd1adbc4e6
fix: ensure logic blocks keep consistent namespacing ( #14817 )
...
* fix: ensure logic blocks keep consitent namespacing
* lint
* add test
* handle `<title>` ambiguity the same as `<a>`
* update changeset
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
9 months ago
github-actions[bot]
f5c285080c
Version Packages ( #14918 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
9 months ago
Matthijs
a646780109
fix: Make Tween work with continuous target changes ( #14895 )
...
* Read previous_value at a later stage in Tween.set
* Add changeset
* tweak
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
9 months ago
Dominic Gannaway
dbdb8cd7fd
fix: use cached indexOf array prototype method internally ( #14912 )
9 months ago
github-actions[bot]
a8ca375c57
Version Packages ( #14908 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
9 months ago
Simon H
2e2b440954
fix: apply `clsx` logic to custom element `class` attributes ( #14907 )
...
Fixes #14902
9 months ago
Paolo Ricciuti
c4e9faad52
fix: correctly parse `each` with loose parser ( #14887 )
...
* fix: correctly parse `each` with loose parser
* chore: fix lint
* chore: remove unused imports
* Apply suggestions from code review
* chore: fix lint
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
9 months ago
github-actions[bot]
ed26c3f658
Version Packages ( #14888 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
9 months ago
Dominic Gannaway
82db92f870
fix: ensure disconnected deriveds correctly connect again ( #14899 )
...
* fix: ensure disconnected deriveds correctly connect again
* fix: ensure disconnected deriveds correctly connect again
9 months ago
Paolo Ricciuti
a91308d9db
fix: correctly highlight sources reassigned inside `trace` ( #14811 )
...
* fix: correctly highlight sources reassigned inside `trace`
* chore: add missing effect logs
* fix: prevent `null` access on `tracing_expressions` for nested tracing
* chore: add test case for #14853
* fix: types for `$inpect.trace`
9 months ago
github-actions[bot]
f3a7ded734
Version Packages ( #14856 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
9 months ago
Dominic Gannaway
8148734812
fix: ensure unowned deriveds correctly get re-linked to the graph ( #14855 )
...
* fix: ensure unowned deriveds correctly get re-linked to the graph
* fix: ensure unowned deriveds correctly get re-linked to the graph
* fix: ensure unowned deriveds correctly get re-linked to the graph
* add test
* add test
* cleaner apporach
* cleaner apporach
* cleaner apporach
* cleaner apporach
9 months ago
Dominic Gannaway
32348a5387
fix: ensure $inspect.trace works correctly with null values ( #14853 )
...
* fix: ensure $inspect.trace works correctly with null values
* fix: ensure $inspect.trace works correctly with null values
9 months ago
github-actions[bot]
7f8acb8a37
Version Packages ( #14824 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
9 months ago
Simon H
015210a1a8
feat: allow objects/arrays for class attribute ( #14714 )
...
* WIP
* missed
* fix
* fix
* rename, smooth over incompatibilities
* spread support + test
* docs
* types
* implement CSS pruning for array/object expressions
* beefier static analysis
* lint
* rename doc
* move class after all directive docs
* tweak docs - clarify top-level falsy values, stagger examples, demonstrate composition, discourage class: more strongly
* changeset
* fix
* Update documentation/docs/03-template-syntax/18-class.md
Co-authored-by: Conduitry <git@chor.date>
* Apply suggestions from code review
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
Co-authored-by: Conduitry <git@chor.date>
9 months ago
Andrey Sitnik
38a3ae321f
fix: Allow to disable animation prefix ( #14822 )
...
* fix: Allow to disable animation prefix
* Apply suggestions from code review
---------
Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>
9 months ago
github-actions[bot]
1d773ef3a4
Version Packages ( #14782 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
9 months ago
Bjorn Lu
72b7bc7af8
feat: add "worker" exports condition ( #14779 )
9 months ago
github-actions[bot]
2086c199be
Version Packages ( #14776 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
9 months ago
ottomated
999b92d134
fix: intellisense DX for $props, $inspect, $bindable, and $host ( #14777 )
...
* remove default function types for $props, $inspect, $bindable, and $host
* changeset
* regenerate types
* add helper message for type regeneration
* append a newline to generated types
* prettier
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
9 months ago
Dominic Gannaway
5bc4033421
fix: treeshake `$inspect.trace` code if unused in modules ( #14774 )
9 months ago
github-actions[bot]
69d198eb44
Version Packages ( #14764 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
9 months ago
Rich Harris
7c6379a260
fix: bump esrap dependency ( #14765 )
...
* fix: bump esrap
* changeset
* ugh
9 months ago
Dominic Gannaway
d0f156c0f9
fix: ensure $inspect.trace code is treeshaken out if unused ( #14770 )
...
* fix: ensure $inspect.trace code is treeshaken out if unused
* Update .changeset/tough-dingos-deliver.md
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
9 months ago
Dominic Gannaway
8705d44c64
fix: ensure svg namespace for `<a>` elements is correct ( #14756 )
...
* fix: ensure svg namespace persists from parent of if blocks
* better fix
* better fix
* address feedback
9 months ago
github-actions[bot]
2bfdd1b436
Version Packages ( #14745 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
9 months ago
Taku Fukada
c79b909458
fix: remove 'implements' from class declaration ( #14749 )
...
* fix: remove implements from class declaration
* add a smoke test
9 months ago
Rich Harris
e38975eac9
fix: remove unwanted properties from both replaced and unreplaced nodes ( #14744 )
9 months ago
github-actions[bot]
00ff60e8d5
Version Packages ( #14740 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
9 months ago
Rich Harris
c033dae049
fix: bump esrap, prevent malformed AST ( #14742 )
...
* bump esrap, start fixing stuff
* ignore type exports when looking for undefineds
* sanitize stuff
* changeset
* fix
* oops
* try this?
* prettier
9 months ago
Rich Harris
36a437c2f9
fix: compare array contents for equality mismatch detections, not the arrays themselves ( #14738 )
9 months ago
github-actions[bot]
5529ad241f
Version Packages ( #14735 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
9 months ago
Simon H
3146e93bbb
chore: loose parser improvements ( #14733 )
...
* handle invalid expression inside each key
* handle invalid expression inside each expression
* handle invalid expression inside await block
* handle "in the middle of typing" components with starting lowercase and dot at the end
* changeset
9 months ago
Paolo Ricciuti
36d73cad55
fix: correctly highlight first rerun of `$inspect.trace` ( #14734 )
9 months ago