svelte

Commit Graph

Author	SHA1	Message	Date
Simon H	d16099ef0f	fix: remove `WAS_MARKED` flag in favor of `Set` (#18127 ) Removes the `WAS_MARKED` logic in favor of a simple `Set` heuristic: If `mark_reactions` goes beyond a certain count, initialize it, otherwise keep it `null`. Balances the common case of not having many transitive dependencies with the edge case of cyclic dependencies as was seen in #16658 (I rechecked that reproduction and it remains fast with this change). I ran the benchmark against this and it doesn't hit the `Seen` heuristic once (i.e. even the benchmark doesn't have this extreme level of dependencies where it becomes noticeable). Fixes #18123, supersedes #18124 --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 days ago

Author

SHA1

Message

Date

Simon H

d16099ef0f

fix: remove `WAS_MARKED` flag in favor of `Set` (#18127 )

Removes the `WAS_MARKED` logic in favor of a simple `Set` heuristic: If
`mark_reactions` goes beyond a certain count, initialize it, otherwise
keep it `null`. Balances the common case of not having many transitive
dependencies with the edge case of cyclic dependencies as was seen in
#16658 (I rechecked that reproduction and it remains fast with this
change).

I ran the benchmark against this and it doesn't hit the `Seen` heuristic
once (i.e. even the benchmark doesn't have this extreme level of
dependencies where it becomes noticeable).

Fixes #18123, supersedes #18124

---------

Co-authored-by: Rich Harris <rich.harris@vercel.com>

1 Commits (main)