11417 Commits (incremental-batches)

 

All Branches   

Search

Author	SHA1	Message	Date
dagecko	e0f925116c	fix: pin 9 actions to commit SHA (#18025) ... Re-submission of #18017. Had a problem with my fork and had to delete it, which closed the original PR. Apologies for the noise. ## Summary This PR pins all GitHub Actions to immutable commit SHAs instead of mutable version tags. - Pin 9 unpinned actions to full 40-character SHAs - Add version comments for readability ## Changes by file | File | Changes | |------|---------| | autofix.yml | Pinned actions to SHA | | ci.yml | Pinned actions to SHA | | pkg.pr.new.yml | Pinned actions to SHA | | release.yml | Pinned actions to SHA | ## A note on internal action pinning This PR pins all actions including org-owned ones. Best practice is to pin everything — the tj-actions/changed-files attack was an internally maintained action that was compromised, and every repo referencing it by tag silently executed attacker code. That said, it's your codebase. If you'd prefer to leave org-owned actions unpinned, let us know and we'll adjust the PR. ## How to verify Review the diff — each change is mechanical and preserves workflow behavior: - **SHA pinning**: `action@v3` becomes `action@abc123 # v3` — original version preserved as comment - No workflow logic, triggers, or permissions are modified I wrote a scanner called Runner Guard and open sourced it [here](https://github.com/Vigilant-LLC/runner-guard). If you have any questions, reach out. I'll be monitoring comms. \- Chris Nyhuis (dagecko)	5 months ago
Simon H	97d45f85c6	fix: don't override `$destroy/set/on` instance methods in dev mode (#18034) ... Don't think we need a test for this Fixes #17988	5 months ago
Rich Harris	3413d3d5ff	tidy up	5 months ago
Rich Harris	e9a418f78a	unused	5 months ago
Rich Harris	d697d5066e	remove some logging	5 months ago
Rich Harris	b27f9ed18c	Merge branch 'main' into incremental-batches	5 months ago
Rich Harris	ac238fb643	remove maybe_dirty_effects	5 months ago
Rich Harris	033573dbb3	no longer need whatever this nonsense was	5 months ago
Rich Harris	9d48444c50	tidy up	5 months ago
Rich Harris	2beb9eaf8f	slightly hacky fix. all tests passing	5 months ago
Rich Harris	edd398900d	this test was just wrong?	5 months ago
Rich Harris	aba4ab8737	chore: fix editorconfig (#18033) ... I don't know why exactly, but VS Code suddenly started paying attention to this line. An indent size of 2 inside an IDE is for masochists and barbarians. If that's your preference then that's up to you but there's certainly no reason to impose it on everyone who clones this repo.	5 months ago
Rich Harris	a0fe4975ad	fix	5 months ago
Rich Harris	e0f3dae6f7	fix	5 months ago
Rich Harris	38a47384be	fix	5 months ago
Rich Harris	db7cce904b	WIP	5 months ago
Rich Harris	0d95919978	all async tests passing	5 months ago
Rich Harris	6a96f64c5c	more shrug	5 months ago
Rich Harris	a2c39c10b1	shrug	5 months ago
Rich Harris	4826a279bf	fix	5 months ago
Rich Harris	494f06aad1	WIP	5 months ago
Rich Harris	ef44fbe189	more commented logs	5 months ago
Rich Harris	ae3ed1b9c9	WIP	5 months ago
Rich Harris	cfc16cae59	WIP	5 months ago
Rich Harris	e11871867c	simplify	5 months ago
Rich Harris	b02c7f7bcd	fix	5 months ago
Rich Harris	25adfd15c3	note to self	5 months ago
Rich Harris	5f21efe7dc	WIP	5 months ago
Rich Harris	e6b37592bd	tidy	5 months ago
Rich Harris	ce6cbd13db	WIP	5 months ago
Rich Harris	92c5b81718	WIP	5 months ago
Rich Harris	59f0fa1cd8	fix	5 months ago
Rich Harris	315b4043ca	apparently we need to get rid of this now?	5 months ago
Rich Harris	66507b88b4	fix	5 months ago
Rich Harris	a22611a60e	fix	5 months ago
github-actions[bot]	37ab33c0a3	Version Packages (#18006) ... This PR was opened by the [Changesets release](https://github.com/changesets/action) GitHub action. When you're ready to do a release, you can merge this and the packages will be published to npm automatically. If you're not ready to do a release yet, that's fine, whenever you add more changesets to main, this PR will be updated. # Releases ## svelte@5.55.1 ### Patch Changes - fix: correctly handle bindings on the server ([#18009](https://github.com/sveltejs/svelte/pull/18009)) - fix: prevent hydration error on async `{@html ...}` ([#17999](https://github.com/sveltejs/svelte/pull/17999)) - fix: cleanup `superTypeParameters` in `ClassDeclarations`/`ClassExpression` ([#18015](https://github.com/sveltejs/svelte/pull/18015)) - fix: improve duplicate module import error message ([#18016](https://github.com/sveltejs/svelte/pull/18016)) - fix: reschedule new effects in prior batches ([#18021](https://github.com/sveltejs/svelte/pull/18021)) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	5 months ago
Rohit Nair P	4879f9da99	fix: improve duplicate module import error message (#18016) ... ## Description **While investigating the compiler analysis phase for errors or missing lines, I located an explicit `TODO fix the message here` comment in the source code (`packages/svelte/src/compiler/phases/2-analyze/visitors/shared/utils.js`).** ### Triggering Code ```svelte <script module> import { foo } from './somewhere.js'; </script> <script> let foo = 'conflict'; // Triggers the duplicate module import error </script> ``` ## The Bug When a component author creates a local `let` declaration in the instance `<script>` block that shadows a variable imported in the `<script module>` block, the compiler emits a `declaration_duplicate_module_import` error. However, the error message text was misleading. It stated: ```diff - Cannot declare a variable with the same name as an import inside `<script module>` + Cannot declare a variable with the same name as an import from `<script module>` ``` This incorrectly implies that the duplicate declaration itself is happening *inside* the module script block, rather than colliding with an import *from* that block. ## Changes Made | Action | Target (File / Function) | Description | | :--- | :--- | :--- | | **Template Fix** | `packages/svelte/messages/compile-errors/script.md` | Changed "inside" to "from" to accurately reflect the nature of the shadow collision. | | **Regenerated Errors** | `packages/svelte/src/compiler/errors.js` | Ran `pnpm generate` to apply the updated markdown template into the dictionary list. | | **Removed TODO** | `ensure_no_module_import_conflict` function | Removed the original `// TODO fix the message here` notation from the validator. | | **Test Adjustments** | `illegal-variable-declaration/errors.json` | Updated the validator test suite snapshots to assert against the correct error message format. | ## Validation Results * The error correctly throws when a user replicates this component structure. * Vitest suite `tests/validator/test.ts` successfully asserts the new, clearer message. --- ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` # THANK YOU	5 months ago
Simon H	04eadbc8a9	fix: correctly handle bindings on the server (#18009) ... `item.subsume(item)` did nothing, honestly kinda weird how this only turned up now Fixes #17981	5 months ago
Paolo Ricciuti	957f2755fa	fix: cleanup `superTypeParameters` in `ClassDeclarations`/`ClassExpression` (#18015) ... Closes #18012 We were removing `superTypeArguments` but the AST showed `superTypeParameters`. Luckily, I was able to pinpoint `esrap@2.2.4` as the cause... I've only bumped `esrap` and that made the test fail (so that I could fix it) And of course it was that...there's literally a commit that explicitly print them lol f9137c4101	5 months ago
Rich Harris	41d2de109a	WIP	5 months ago
Rich Harris	b8cb7dcf90	Merge branch 'main' into incremental-batches	5 months ago
Rich Harris	2660c7f87e	fix	5 months ago
Simon H	a9d8439ad1	fix: reschedule new effects in prior batches (#18021) ... If a batch creates a new branch (e.g. through an if block becoming true) the previous batches so far do not know about the new effects created through that. This can lead to stale values being shown. We therefore schedule those new effects on prior batches if they are touched by a `current` value of that batch Fixes #17099 extracted from #17971	5 months ago
Rich Harris	930076dcd6	match main	5 months ago
Rich Harris	eae5ccba61	delete these tests for now	5 months ago
Rich Harris	4d1436bb79	fix	5 months ago
Rich Harris	7cd62ff67d	WIP	5 months ago
Rich Harris	46e1d08e00	more debug logging	5 months ago
Rich Harris	45b123264e	fix	5 months ago
Rich Harris	b6ccd1465b	merge main	5 months ago