svelte

Commit Graph

Author	SHA1	Message	Date
Simon H	d9369d8e30	fix: tighten up `$` prefix validation (#13261 ) Our current validation was both too lax and too strict: - too strict, because you can define a `$` variable in Svelte 4 if it's not at the top level - too strict, because you can define `$`-prefixed function parameters, but not give the parameter the name `$` - too lax, because you can define a `$`-prefixed variable if you're at least one level deep into a function. In runes mode, this should be an error This PR aligns the behavior, ensures this isn't a breaking change in legacy anymore, and makes the validation in runes mode more strict	1 year ago

Author

SHA1

Message

Date

Simon H

d9369d8e30

fix: tighten up `$` prefix validation (#13261 )

Our current validation was both too lax and too strict:
- too strict, because you can define a `$` variable in Svelte 4 if it's not at the top level
- too strict, because you can define `$`-prefixed function parameters, but not give the parameter the name `$`
- too lax, because you can define a `$`-prefixed variable if you're at least one level deep into a function. In runes mode, this should be an error

This PR aligns the behavior, ensures this isn't a breaking change in legacy anymore, and makes the validation in runes mode more strict

1 Commits (fix-import-run-space)