svelte

Commit Graph

Author	SHA1	Message	Date
Siddhesh Kabra	faf1e103c5	fix: prevent onoutroend from firing twice when compilerOptions.hmr is true (#18655 ) Fixes #18440 `hmr()` in `packages/svelte/src/internal/client/dev/hmr.js` wrapped a component in a `block` effect containing a `branch` effect. It forwarded the inner effect's `nodes` object to the outer block: This shared the same reference, meaning `outer_block.nodes === inner_branch.nodes`. When `pause_children` collected transitions for unmounting, Each collected transition had `out(check)` called multiple times, starting multiple animations and firing `outroend` multiple times. Fix by only copying `start`/`end` (the DOM range info the outer block needs) without sharing the transitions array:	3 weeks ago

Author

SHA1

Message

Date

Siddhesh Kabra

faf1e103c5

fix: prevent onoutroend from firing twice when compilerOptions.hmr is true (#18655 )

Fixes #18440

`hmr()` in `packages/svelte/src/internal/client/dev/hmr.js` wrapped a
component in a `block` effect containing a `branch` effect. It forwarded
the inner effect's `nodes` object to the outer block:

This shared the same reference, meaning `outer_block.nodes ===
inner_branch.nodes`. When `pause_children` collected transitions for
unmounting, Each collected transition had `out(check)` called multiple times,
starting multiple animations and firing `outroend` multiple times.

Fix by only copying `start`/`end` (the DOM range info the outer block needs)
without sharing the transitions array:

1 Commits (entangle-batches-3)