svelte

Commit Graph

Author	SHA1	Message	Date
Simon H	8e7319063a	fix: don't mark deriveds while an effect is updating (#18124 ) Fixes #18123 This makes setting state inside effects slightly slower theoretically (since they hit the new guard), but I verified that the original issue for which we introduced this (#16658) is still fast with this change. The more we add logic to this the more I think we should investigate switching to a different mechanism. I tried using a `Set` previously but it did hurt the benchmarks a bit - might try to revisit a variant of this. --------- Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>	4 months ago

Author

SHA1

Message

Date

Simon H

8e7319063a

fix: don't mark deriveds while an effect is updating (#18124 )

Fixes #18123

This makes setting state inside effects slightly slower theoretically
(since they hit the new guard), but I verified that the original issue
for which we introduced this (#16658) is still fast with this change.

The more we add logic to this the more I think we should investigate
switching to a different mechanism. I tried using a `Set` previously but
it did hurt the benchmarks a bit - might try to revisit a variant of
this.

---------

Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>

1 Commits (elliott/test-target)