2032049e47
chore: Reduce hydration comment for {:else if} ( #15250 )
...
* rewrite else/if hydration
* fix: bad index
* reduce args on if_block()
* restore the block
* don't use isNan()
* changeset
6 months ago
474c588067
fix: disallow `bind:group` to snippet parameters ( #15401 )
6 months ago
e4987d2a9f
Version Packages ( #15383 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
6 months ago
fe343e9c50
fix: catch error on @const tag in svelte:boundary in DEV mode ( #15369 )
...
* fix: catch error on @const tag in svelte:boundary
* changeset
* edit changeset
* test
* fix
* rollback
* simpler way to do that
* rollback
* roolback again
---------
Co-authored-by: paoloricciuti <ricciutipaolo@gmail.com>
6 months ago
8fb2fb70e1
fix : bug "$0 is not defined" with svelte:element and a single class with a function call ( #15396 )
...
* add spread to test
* fix #15386
* fix #15392
* test
* changeset
* use is_text_attribute
6 months ago
cf56973bf0
fix: class:directive not working with $$restProps ( #15389 )
...
* add spread to test
* fix #15386
* do no set cssHash on non-scoped element
* changeset
6 months ago
3d59e84a65
fix: allow double hyphen css selector names ( #15384 )
6 months ago
c2ec0d9ac2
fix: allow for duplicate `var` declarations ( #15382 )
6 months ago
bbeeed421b
Version Packages ( #15380 )
...
* Version Packages
* this changeset was unnecessary
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
6 months ago
51337f22bd
chore: simplify flushing ( #15348 )
...
* this appears to be unnecessary
* DRY out
* this doesnt appear to do anything useful
* simplify
* remove unused if block
* simplify, make non-recursive
* unused
* DRY
* simplify
* tidy up
* simplify
* changeset
* unused
* Revert "changeset"
This reverts commit 946e00dcf7
6 months ago
7958eb74df
chore: remove unnecessary `binding.is_called` property ( #15361 )
6 months ago
220c2418d1
Version Packages ( #15358 )
...
* Version Packages
* tweak
---------
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
6 months ago
d4360af751
chore: rewrite set_class() to handle directives ( #15352 )
...
* set_class with class: directives
* update expected result (remove leading space)
* fix
* optimize literals
* add test
* add test for mutations on hydration
* clean observer
* Update packages/svelte/src/compiler/phases/3-transform/client/visitors/RegularElement.js
unused
Co-authored-by: Rich Harris <hello@rich-harris.dev>
* Update packages/svelte/src/compiler/phases/3-transform/client/visitors/RegularElement.js
unused for now
Co-authored-by: Rich Harris <hello@rich-harris.dev>
* Update packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/element.js
unused for now
Co-authored-by: Rich Harris <hello@rich-harris.dev>
* Update packages/svelte/src/compiler/phases/3-transform/server/visitors/shared/element.js
nit
Co-authored-by: Rich Harris <hello@rich-harris.dev>
* Update packages/svelte/src/internal/client/dom/elements/attributes.js
nit
Co-authored-by: Rich Harris <hello@rich-harris.dev>
* Update packages/svelte/src/internal/shared/attributes.js
rename clazz to value :D
Co-authored-by: Rich Harris <hello@rich-harris.dev>
* remove unused + fix JSDoc
* drive-by fix
* minor style tweaks
* tweak test
* this is faster
* tweak
* tweak
* this is faster
* typo
* tweak
* changeset
---------
Co-authored-by: Rich Harris <hello@rich-harris.dev>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
6 months ago
5a946e7905
fix: Allow @const inside #key ( #15377 )
6 months ago
1e1aea4063
chore: remove unnecessary `?? ''` on some expressions ( #15287 )
...
* no `?? ''` on some expressions
* changeset
* delete operator returns boolean
* inverted conditions are a lil confusing
* no need for else after return
* simplify condition
* may as well add special handling for undefined while we're here
* use normal string literal when there are no values
* omit assignment when there is no text content
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
7 months ago
9873443337
Version Packages ( #15304 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 months ago
d8e78f7f57
fix: `muted` reactive without `bind` and select/autofocus attributes … ( #15326 )
...
* fix: `muted` reactive without `bind` and select/autofocus attributes working with function calls
Co-authored-by: Joel Howse <joel@helicalco.com>
* chore: add comments
---------
Co-authored-by: Joel Howse <joel@helicalco.com>
7 months ago
9091e7e930
fix: fire delegated events on target even it was disabled in the meantime ( #15319 )
...
They DOM could've been updated already by the time the event bubbling logic is reached, so the target element itself could not be notified of the event because it is marked as disabled. But the target could not have been disabled because it emits the event in the first place, so we emit regardless.
No test because not reproducible in jsdom environment.
Fixes #15256
7 months ago
575900de88
fix: Add more checks to determine if element is non-static ( #15259 )
...
Fixes #15241
7 months ago
073f4d8911
fix: prevent writable store value from becoming a proxy when reassigning using $-prefix ( #15283 )
...
fixes #15281
7 months ago
dde8603872
fix: do not warn for `binding_property_non_reactive` if binding is a store in an each ( #15318 )
...
Fixes #15315
7 months ago
c40392c1e8
chore: remove options.uid in render() ( #15302 )
...
* remove options.uid in render()
* changeset
* chore: update changeset
---------
Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>
7 months ago
32b78c9954
Version Packages ( #15279 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 months ago
7e3253745e
fix: ensure AST analysis on `svelte.js` modules succeeds ( #15297 )
...
This was the result of a `@ts-expect-error` silencing other type errors, which lead to this creeping in. This changes it so that the object is fully set, so we'll get type errors when new properties need to be added
fixes #15284
7 months ago
b6bf735a23
fix: correctly ssr component in `svelte:head` with `$props.id()` or `css='injected'` ( #15291 )
7 months ago
21dadfc997
fix: ignore typescript abstract methods during code transformation ( #15267 )
7 months ago
23ecc364da
Version Packages ( #15271 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 months ago
f747c412f4
chore: tweak effect self invalidation logic ( #15275 )
...
Also make sure events dispatched via transition/animation logic runs outside event context
Related to #15262
7 months ago
5e52825d60
fix: take private and public into account for `constant_assignment` of derived state ( #15276 )
...
Fixes #15273
7 months ago
18481386f3
fix: use `importNode` to clone templates for Firefox ( #15272 )
...
* fix: use `importNode` to clone templates for Firefox
* fix: move `is_firefox` check to line 28
* fix: revert using `is_firefox` too soon
7 months ago
a3e49b6110
fix: recurse into `$derived` for ownership validation ( #15166 )
...
- `$derived` can contain `$state` declarations so we cannot ignore them, so this reverts #14533
- instead, we add equality checks to not do this expensive work unnecessarily
- this also adds a render effect similar to the class ownership addition when it detects a getter on a POJO during ownership addition
fixes #15164
7 months ago
afae274587
fix: value/checked not correctly set using spread ( #15239 )
...
* set value/checked by JS
* test
* changeset
* fix test form-default-value-spread
7 months ago
85f83ec435
feat: $props.id(), a SSR-safe ID generation ( #15185 )
...
* first impl of $$uid
* fix
* $props.id()
* fix errors
* rename $.create_uid() into $.props_id()
* fix message
* relax const requirement, validate assignments instead
* oops
* simplify
* non-constants should be lowercased
* ditto
* start at 1
* add docs
* changeset
* add test
* add docs
* doc : add code example
* fix type reported by bennymi
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
7 months ago
280d8c74cc
Version Packages ( #15263 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 months ago
b602c59a22
fix: when re-connecting unowned deriveds, remove their unowned flag ( #15255 )
...
* fix: when an unowned derived is tracked again, remove unowned flag
* fix: when an unowned derived is tracked again, remove unowned flag
* test case
* test case
* cleanup unused logic
* simplify
* simplify
* simplify
* simplify
* add test
* fix other issue
* back to original plan
* Apply suggestions from code review
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
7 months ago
02788f8e62
fix: allow mutation of private derived state ( #15228 )
...
Also disallow reassignment of private derived state
Fixes #15227
7 months ago
c4d4349d0a
Version Packages ( #15234 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 months ago
4883fd2c83
fix: hydrate `href` that is part of spread attributes ( #15226 )
...
We had some duplicated and buggy code, removing it fixes #15120
7 months ago
f2c83e5db7
fix: ensure unowned derived dependencies are not duplicated when reac… ( #15232 )
...
* fix: ensure unowned derived dependencies are not duplicated when reactions are skipped
* added test case
* added test case
* add comment
7 months ago
b0c4fa5246
Version Packages ( #15216 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 months ago
3b7066f5c6
fix: ensure custom element updates don't run in hydration mode ( #15217 )
...
* fix: ensure custom element updates don't run in hydration mode
When a custom element is created before Svelte hydration kicks in, it will scaffold itself, using the properties given via attributes.
Now when a custom element property is set during Svelte's hydration, the Svelte custom element component could run logic like updating an each block. Without turning off hydration mode during that time, the update would try to pick up existing element nodes (because it thinks they must be there because of hydration mode), and crash.
No test because it would require a setup where we can ensure the element is scaffolded before hydration runs.
Fixes #15213
* changeset
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
7 months ago
6f392d679b
fix: properly set `value` property of custom elements ( #15206 )
...
Avoid going through the `element.value = element.__value = newValue` condition because `__value` is actually how Lit stores the current value on the element, and messing with that would break things: Lit would think the value hasn't changed (because `__value` is already set to the new value by us) and doesn't fire an update.
fixes #15194
7 months ago
d39d8c0675
fix: ensure tracking returns true, even if in unowned ( #15214 )
...
* fix: ensure tracking returns true, even if in unowned
* fix: ensure tracking returns true, even if in unowned
* Update packages/svelte/tests/runtime-runes/samples/effect-tracking-unowned/main.svelte
---------
Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
7 months ago
64f86ee9d4
Version Packages ( #15190 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 months ago
e0b3dc020c
chore: remove unused code from signal logic ( #15195 )
7 months ago
5b30fbfb0b
fix: encounter svelte:element in blocks as sibling during pruning css ( #15165 )
...
Fixes #14890
7 months ago
04addca428
Version Packages ( #15156 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 months ago
7bef5963bd
fix: ensure reactions are correctly attached for unowned deriveds ( #15158 )
...
* fix: ensure reactions are correctly attached for unowned deriveds
* tune
7 months ago
970aa7cfaa
fix: prevent false-positive ownership validations due to hot reload ( #15154 )
...
The component identity could change due to HMR, so we fall back to checking the filenames as well
fixes #14746
7 months ago
83f00ebbd6
fix: don't error on slot prop inside block inside other component ( #15148 )
...
`slot` is treated as a regular prop if it is not used directly inside another component, but we were running validations on such regular props that should only be run on real slots.
Fixes #15125
7 months ago
b8607f8765
fix: silence a11y attribute warnings when spread attributes present ( #15150 )
...
Fixes #15067
7 months ago
f5406c952e
fix: widen ownership when calling setContext ( #15153 )
...
Instead of doing ownership addition at each `getContext` call site, we do it once as the `setContext` call site and make the state basically global.
- avoids potential false positives in edge cases
- makes the whole thing more performant, especially around things like calling `getContext` inside a list item component
- false negatives are unlikely from this
fixes #15072
7 months ago
522557559f
fix: do not prune selectors like `:global(.foo):has(.scoped)` ( #15140 )
...
Fixes #14910
The issue occurs only when :has() targets at a component's root element and because include_self is false.
I came to the conclusion that this is the same case as :root:has(.scoped).
7 months ago
c8bbb15693
Version Packages ( #15139 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 months ago
13a6d555c0
fix: improve derived connection to ownership graph ( #15137 )
...
* fix: improve derived connection to ownership graph
* revised
* revised
* revised
* revised
* feedback
* feedback
* invasive change
* fix bugs
* fix other bug
7 months ago
9410ad0318
fix: correctly look for sibling elements inside blocks and components ( #15106 )
...
Fixes #15027 and fixes #14995
When the target element is inside a block or component, get_following_sibling_elements was looking only for sibling elements after the block/component. This PR fixes it by starting the search from the begging of the block/component and skipping nodes that go before the target element.
7 months ago
b2c8224a73
Version Packages ( #15118 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 months ago
fc4dd2dec4
fix: lazily connect derievds (in deriveds) to their parent ( #15129 )
7 months ago
3f8ce21f47
fix: Add `bind:focused` to `HTMLAttributes` ( #15122 )
...
* Revert "fix: ensure untrack correctly retains the active reaction (#15065 )"
This reverts commit 2ad519542d#15065 )""
This reverts commit f4e98bf89f
7 months ago
0e0f01ee1c
fix: disallow $state/$derived in const tags ( #15115 )
7 months ago
357e1a74b4
Version Packages ( #15088 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
7 months ago
d47f4f5908
fix: expand boolean attribute support ( #15095 )
...
* Adding test for expected boolean attribute support
* Improving support for more boolean attributes:
Added:
- `defer`
- `disablepictureinpicture`
- `disableremoteplayback`
Improved:
- `allowfullscreen`
- `novalidate`
* Skipping JSDOM version of boolean attribute test
JSDOM lacks support for some attributes, so we'll skip it for now.
See:
- `async`: https://github.com/jsdom/jsdom/issues/1564
- `nomodule`: https://github.com/jsdom/jsdom/issues/2475
- `autofocus`: https://github.com/jsdom/jsdom/issues/3041
- `inert`: https://github.com/jsdom/jsdom/issues/3605
- etc...: https://github.com/jestjs/jest/issues/139#issuecomment-592673550
* Adding changeset
8 months ago
d17f5c748d
fix: add check for is attribute ( #15086 )
...
Fixes #15085
Add a check for is attribute in is_custom_element_node function.
8 months ago
7740d4576b
fix: optimise || expressions in template ( #15092 )
8 months ago
c2e805f05c
fix: consistently set value to blank string when value attribute is undefined ( #15057 )
...
Fixes #4467
8 months ago
8bba70b8e3
fix: avoid double deriveds in component props ( #15089 )
...
* fix: prevent double deriveds in component props
* unused
* reuse mechanism
* move code to where it is used
* changeset
8 months ago
eee808fb79
fix: correctly handle `novalidate` attribute casing ( #15083 )
...
This PR fixes #15082 by correctly handling the HTML element novalidate attribute casing through noValidate DOM property mapping.
8 months ago
7da86ef80c
fix: don't throw for `undefined` non delegated event handlers ( #15087 )
...
* fix: don't throw for `undefined` non delegated event handlers
* chore: update typings
8 months ago
ee024ffd0e
Version Packages ( #15080 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
09510c8c5c
fix: address regression with untrack ( #15079 )
...
* fix: address regression with untrack
* add test
8 months ago
c75f1f5f2f
Version Packages ( #15052 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
5ad6a0cdc3
fix: initialize `files` bind on hydration ( #15059 )
8 months ago
2ad519542d
fix: ensure untrack correctly retains the active reaction ( #15065 )
...
* fix: ensure untrack correctly retains the active reaction
* fix: ensure untrack correctly retains the active reaction
8 months ago
5f6525f416
fix: omit unnecessary nullish coallescing in template expressions ( #15056 )
...
* omit unnecessary nullish coallescing in template expressions
* add tests
8 months ago
700029bd4d
fix: more efficient template effect grouping ( #15050 )
...
* WIP
* drive-by
* group attribute updates
* fix
* more
* unused
* more
* WIP
* unused
* simplify
* simplify
* simplify
* more
* unused
* unused
* more
* tweak
* update how class/style directives are handled
* more
* more
* simplify
* changeset
8 months ago
a9d1f46dbb
Version Packages ( #15021 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
509ba568f3
fix: create fewer deriveds for concatenated strings ( #15041 )
...
* fix: create fewer deriveds for concatenated strings
* stringified_text -> expression
8 months ago
2aefc5430d
feat(elements): Expose ClassValue ( #15035 )
...
* Push
* Cleanup
* Add changeset
* Remove redundant string
* Update documentation/docs/03-template-syntax/18-class.md
Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>
* Update documentation/docs/03-template-syntax/18-class.md
---------
Co-authored-by: Paolo Ricciuti <ricciutipaolo@gmail.com>
8 months ago
973b51d168
fix: correctly parse leading comments in function binding ( #15020 )
...
* fix: correctly parse leading comments in function binding
* chore: fix lint
8 months ago
1d3c4397b2
Version Packages ( #15010 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
ff79704ab8
fix: bump esrap ( #15015 )
...
* chore: bump esrap
* changeset
8 months ago
5419610833
fix: ensure resume effects are scheduled in topological order ( #15012 )
...
* fix: ensure resume effects are scheduled in topological order
* fix: ensure resume effects are scheduled in topological order
8 months ago
360ee70dcb
fix: remove listener on `bind_current_time` teardown ( #15013 )
...
Fixes #15008
8 months ago
dfa97a5e64
feat: allow every children in `template` tags ( #15007 )
...
* feat: allow every children in `template` tags
* Update .changeset/dry-mails-return.md
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
8 months ago
a1698c63ec
Version Packages ( #15001 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
dae4c5f5e1
fix: ensure signal write invalidation within effects is consistent ( #14989 )
...
* fix: ensure signal write invalidation within effects is persistent
* fix: ensure signal write invalidation within effects is persistent
* fix: ensure signal write invalidation within effects is persistent
* address feedback
8 months ago
a129592e5b
feat: allow const tag inside `svelte:boundary` ( #14993 )
...
* feat: allow const tag inside `svelte:boundary`
* chore: add better test
* docs: update docs for `@const`
8 months ago
efa5acf24e
Version Packages ( #14970 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
8a1acac084
fix: never consider inert boundary effects ( #14999 )
...
* fix: never consider inert boundary effects
* chore: inline bitwise
8 months ago
9b6e65fbeb
fix: correctly transform `pre` with no content ( #14973 )
...
Closes #14971
8 months ago
41fb51349e
fix: store access on component destroy ( #14968 )
...
Co-authored-by: Oscar Dominguez <dominguez.celada@gmail.com>
8 months ago
dbe5818560
fix: wrap each block expression in derived to encapsulte effects ( #14967 )
...
* fix: wrap each block expression in derived to encapsulte effects
* add test
* Update .changeset/tender-apples-scream.md
---------
Co-authored-by: Rich Harris <rich.harris@vercel.com>
8 months ago
dc8ae825b8
Version Packages ( #14965 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
bdc02008e4
fix: reset dependency read versions after reaction execution ( #14964 )
...
* fix: reset dependency read versions after reaction execution
* fix: reset dependency read versions after reaction execution
* fix: reset dependency read versions after reaction execution
* fix: reset dependency read versions after reaction execution
* fix: reset dependency read versions after reaction execution
* chore: add test
* changeset
---------
Co-authored-by: paoloricciuti <ricciutipaolo@gmail.com>
Co-authored-by: Rich Harris <rich.harris@vercel.com>
8 months ago
b7400ae93b
Version Packages ( #14959 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
c0842d1459
fix: properly add owners to function bindings ( #14962 )
...
Closes #14956
8 months ago
68cffa8489
fix: apply `overflow: hidden` style when transitioning elements, where necessary ( #14930 )
...
* fix: apply `overflow: hidden` style when transitioning elements, where necessary
* notes to self
8 months ago
79a67c9561
fix: account for parent scale when animating elements ( #14957 )
...
* WIP fix flip
* fix: account for parent scale when animating elements
8 months ago
80d9f9996f
Version Packages ( #14953 )
...
Co-authored-by: github-actions[bot] <github-actions[bot]@users.noreply.github.com>
8 months ago
9aae463ae1
fix: silence false-positive statel value warning ( #14958 )
...
fixes #14687
8 months ago
adiGuba
Paolo Ricciuti
github-actions[bot]
Rich Harris
Alexis
Simon H
Ranjan Purbey
tomoam
Caique Torres
Dominic Gannaway
7nik
Elliott Johnson
Trevor N. Suarez
Edoardo Cavazza
Theodore Brown
ComputerGuy
Puru Vijay