svelte

Commit Graph

Author	SHA1	Message	Date
Elliott Johnson	08b502b308	fix: Don't crash on `hydratable` serialization failures	20 hours ago
Rich Harris	46603d93cb	fix: add `srcObject` to permitted `<audio>`/`<video>` attributes (#17310 )	1 day ago
github-actions[bot]	c864d2c778	Version Packages (#17299 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 days ago
Rich Harris	190e64acd9	fix: destroy each items after siblings are resumed (#17258 ) * fix: destroy each items after siblings are resumed * changeset * remove unused exports * tidy up * fix: correctly reconcile each blocks after outroing branches are resumed * WIP * add some logging * fix * remove item on destroy * remove * remove * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * tests passing * tidy up * tidy up * note to self * tidy up * fix * add stress test to repo	3 days ago
github-actions[bot]	f091b11eab	Version Packages (#17286 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	4 days ago
Simon H	794b8f3dfd	fix: keep reactions up to date even when read outside of effect (#17295 ) In #17105 one line in `update_reaction` was changed that can cause reactivity loss. It checks if the reaction is updated inside of an effect and only then will push to the reactions. The prior version had an additional check to still add to the reactions if there is already at least one reaction on the derived, indicating it is connected. Removing this check fixes #17263 while keeping correctness: a connected derived by definition at least has one reaction and therefore can properly cleanup.	4 days ago
Rich Harris	1f3f1826e8	chore: move DOM-related effect properties to `effect.nodes` (#17293 ) * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * changeset * unused	4 days ago
Rich Harris	0e1c98ea11	fix: allow `$props.id()` to occur after an `await` (#17285 )	5 days ago
github-actions[bot]	f8287b0d91	Version Packages (#17268 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	5 days ago
Rich Harris	649d8572a6	fix: handle cross-realm Promises in `hydratable` (#17284 )	5 days ago
Rich Harris	617e179e68	fix: preserve node locations for better sourcemaps (#17269 ) * preserve node locations * preserve component IDs * update tests * use IDs for elements * more * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * tweak * tidy up * changeset * oops	6 days ago
adiGuba	570f64963b	fix: add props to state_referenced_locally (#17266 ) * add props to state_referenced_locally * changeset	7 days ago
github-actions[bot]	b4b580a13a	Version Packages (#17257 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	1 week ago
ComputerGuy	bec7ca7918	fix: throw on invalid `{@tag}`s (#17256 ) * fix: throw on invalid `{@tag}`s * fix	1 week ago
Paolo Ricciuti	ae6004657d	fix: array destructuring after await (#17254 )	1 week ago
github-actions[bot]	5c821c1a41	Version Packages (#17253 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	1 week ago
Simon H	da4cd0e359	fix: link offscreen items and last effect in each block correctly (#17240 ) * fix: link offscreen items and last effect in each block correctly It's possible that due to how new elements are inserted into the array that `effect.last` is wrong. We need to ensure it is really the last item to keep items properly connected to the graph. In addition we link offscreen items after all onscreen items, to ensure they don't have wrong pointers. Fixes #17201 * revert #17244 * add test	1 week ago
github-actions[bot]	1bc3ae7cbf	Version Packages (#17247 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	1 week ago
Rich Harris	8addf203c4	feat: add `print(...)` function (#16188 ) * use local version of esrap, for now * WIP * WIP * fixes * more * add `Declaration` visitor * add `TransitionDirective` * `UseDirective`, `OnDirective` * more directives * `SpreadAttribute`, directive shorthands * `{#if ...} {:else ...}` * fix * more * add tags, `AnimateDirective` * `KeyBlock` * `SelectorList`, `<svelte:whatever />` * quote text in `Attribute` visitor * tweak test logic to reduce false negatives * fix * fix * add separate test suite * fix * more * slightly nicer printing * install from pkg.pr.new * merge main * bump * fix * remove any * fix indentation * replace TODO with a type error * bump * fix * esrap@2 * lockfile * try this * regenerate * add small comment * fix test file * ensure new lines at end of file * common tests * tests for A-nodes * fix interface * tests for B-nodes * delete basic test * tests for C-nodes * combine css tests * tests for E-nodes * tests for H-nodes * tests for I-nodes * tests for K-nodes * tests for L-nodes * tests for N-nodes * add todo * remove other todo * tests for O-nodes * tests for P-nodes * tests for R-nodes * tests for S-nodes * tests for T-nodes * tests for U-nodes * seperate css and svelte visitors for clarity * fix failing test * rename early tests * fix const test * fix svelte-element * move block to css visitors * fix css output * fix #if indentation * fix self closing tag problems * use common method for attributes * put attributes into multiple lines if too long * fix new lines for #each:else * fix svelte element new lines * rmeove usless comments & fix playground * improved formatting * support formatting for a lot more nodes * style * fixes for formatting * cleanup * make typescript happy * add formatting related test * add docs * changeset * regenerate types * fix self-closing tags * fix bracket placement * break length 50 * add support for additional comments * remove abstract keyword * strip out more typescript gubbins --------- Co-authored-by: ComputerGuy <63362464+Ocean-OS@users.noreply.github.com> Co-authored-by: Manuel Serret <mserret99@gmail.com>	2 weeks ago
github-actions[bot]	cc1b3f234a	Version Packages (#17245 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Simon H	a7848c021a	fix: generate correct code for simple destructurings (#17237 ) Fixes #17236 * fix: generate correct code for simple destructurings * add a test (existing one doesn't fail on main) * adjust existing test so it fails on main * slightly neater approach (with identical outcome) --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	2 weeks ago
Simon H	d0e61bc252	fix: ensure each block animations don't mess with transitions (#17238 ) This ensures that an animation does not run when the element is first transitioning in. Else the animation would mess with the transition (overriding its animation basically). Due to our test setup it's not testable but I veryfied it fixes #17181 (tested all reproductions in there)	2 weeks ago
Rich Harris	52a36bdb35	fix: link offscreen items and last effect in each block correctly (alternative) (#17244 ) It's possible that due to how new elements are inserted into the array that `effect.last` is wrong. We need to ensure it is really the last item to keep items properly connected to the graph. Fixes #17201 --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
Simon H	f2dd477031	fix: await blockers before initialising const (#17226 ) * fix: await blockers before initialising const Fixes #17224 * ssr + test	2 weeks ago
github-actions[bot]	c6f99e6399	Version Packages (#17234 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Elliott Johnson	c2a110cd81	feat: `hydratable` (#17154 ) * feat: * doc comments * types * types * changeset * tests * docs * hopefully * lint * finally figured out test issues * get docs building * the easy stuff * prune errors * feat: capture clobbering better, capture unused keys, don't block on unused keys * progress on serializing nested promises * fix * idk man but the tests are passing so i'ma checkpoint this * fix tests * compare resolved serialized values * robustify * thunkify * fixes * ajsldkfjalsdfkjasd * tests * docs * ugh * ugh ugh ugh * Update documentation/docs/06-runtime/05-hydratable.md Co-authored-by: kaysef <25851116+kaysef@users.noreply.github.com> * make errors better * tweak * remove context restoration * fix * trim * simplify hydratable (#17230) * simplify hydratable * tidy up * unused --------- Co-authored-by: Elliott Johnson <sejohnson@torchcloudconsulting.com> * improve errors * include all non-internal frames, handle identical stacks * tweak example * tweak message — setTimeout is covered by ALS * cut out the middleman * unused * tidy * Apply suggestions from code review --------- Co-authored-by: Rich Harris <rich.harris@vercel.com> Co-authored-by: kaysef <25851116+kaysef@users.noreply.github.com>	2 weeks ago
github-actions[bot]	129c4086f7	Version Packages (#17228 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Simon H	84b261886b	chore: lift "flushSync cannot be called in effects" restriction (#17139 ) Since async-await was introduced into the code base a lot has changed. This lifts the restriction. Closes #17131 (though I still wonder why Skeleton does that)	2 weeks ago
Paolo Ricciuti	ea8838e96f	fix: store forked derived values (#17212 ) We have to take non-tracking contexts into account, especially while in the original `fork(() => ...)` context. Closes #17206 --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	2 weeks ago
Simon H	53bbe3462b	fix: don't execute attachments and attribute effects eagerly (#17208 ) * fix: don't execute attachments and attribute effects eagerly attributes_effect and attachments are blocks since they need the managed "don't just destroy children effects"-behavior, but they're not block effects in the sense of "run them eagerly while traversing the effect tree or while flushing effects". Since the latter was the case until now, it meant that forks could cause visible UI updates. This PR introduces a new flag to fix that. `BLOCK_NON_EAGER` is basically a combination of block effects (with respects to the managed behavior) and render effects (with respects to the execution timing). Fixes https://github.com/sveltejs/kit/issues/14931 * managed_effect	2 weeks ago
github-actions[bot]	1aafbc47ff	Version Packages (#17204 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Simon H	91486fa807	fix: take async into account for bindings/transitions/animations/attachments (#17198 ) * fix: take async into account for bindings/transitions/animations/attachments - block on async work - error at compile time on await expressions. Right now it gives confusing errors later at compile time or at runtime Fixes #17194 * this was weird	2 weeks ago
Paolo Ricciuti	a17dc3c302	fix: correctly migrate named self closing slots (#17199 )	2 weeks ago
github-actions[bot]	110181068f	Version Packages (#17202 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	2 weeks ago
Paolo Ricciuti	593eb048aa	chore changeset for #17163 (#17200 )	2 weeks ago
github-actions[bot]	9ccbd734f2	Version Packages (#17192 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Rich Harris	e365890ef9	fix: maintain correct linked list of effects when updating each blocks (#17191 ) * fix: maintain correct linked list of effects when updating each blocks * working * tidy up * changeset * remove unnecessary assignment, add comment explaining unidirectionality	3 weeks ago
github-actions[bot]	92c936d9b3	Version Packages (#17189 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Simon H	203c228174	fix: don't cancel transition of already outroing elements (#17186 ) * fix: don't cancel transition of already outroing elements #16977 forgot one detail: While an element is outroing, the block of e.g. an if block can be triggered again, resolving to the same condition. In that case we have an in-between state where the element is still onscreen but already outroing. We have to detect this to not eagerly destroy the corresponding effect when we arrive at the outro/destroy logic. Fixes #16982 * fix --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	3 weeks ago
Simon H	ebb97a618c	perf: don't use tracing overeager during dev (#17183 ) * perf: don't use tracing overeager during dev #17176 is a case where many sources are created and then written to (due to Svelte 4 prop mechanics), and our tracing kicked in eagerly. That combined with the excessive depth of the related stack traces slowed things down tremendously. The fix is simple: Don't record stack traces until we've seen this source get updated for a couple of times. Additionally we now delete the `updates` map after a flush. Previously it was just an ever-growing stack trace map. * fix * fix	3 weeks ago
github-actions[bot]	3b4b0adcd5	Version Packages (#17178 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Simon H	3604fdac6b	fix: avoid other batches running with queued root effects of main batch (#17145 ) * fix: avoid other batches running with queued root effects of main batch When `#traverse_effect_tree` runs, it can execute block effects, which in turn can create effects which are scheduled, which means `queued_root_effects` is now filled again. We didn't take that into account and assumed that in `#commit` we would have no queued root effects. As a result another batch could wrongfully run with the queued root effects of the main batch. That in turn can mean that `skipped_effects` is different on the other batch, leading to some branches not getting traversed into. As a result part of the tree is marked clean while further below batches are still not marked clean. That then breaks reactivity as soon as you schedule an effect in this still-not-clean sub tree, as it will not bubble all the way up to the root, since it comes across a not-clean branch, assuming something was already scheduled. The fix is simple: Stash the queued root effects before rebasing branches. Fixes #17118 * add note to self --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	3 weeks ago
github-actions[bot]	b94289d23b	Version Packages (#17168 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Simon H	99e670f632	fix: ensure eager effects don't break reactions chain (#17138 ) Execution of eager effects didn't set `is_updating_effect`, which meant the logic in `get` would wrongfully prevent dependencies being added to `reactions` of sources/deriveds. Fixes #17133	3 weeks ago
Simon H	a7a6d898d5	fix: correctly handle functions when determining async blockers (#17137 ) * fix: correctly handle functions when determining async blockers We didn't properly handle functions (function declarations/expressions/arrow functions) when calculating what is a blocker. More specifically - we did defer assignment of variable declarations even for arrow functions and function expressions, which is unnecessary and causes bugs when they're then referenced eagerly further below - we did not compute blockers for functions. They could reference blockers themselves, as such other code referencing them should wait on the related blockers Fixes #17129 * put into its own function * fix: take blockers into account when creating `#await` blocks The unrelated-but-in-the-same-issue-referenced-bug * oops * fix * minimize compiled output changes * no idea why editor showed these as unused	3 weeks ago
Simon H	686720070b	fix: keep deriveds reactive after their original parent effect was destroyed (#17171 ) Use case: Remote queries that are created on one screen, then are used again on another screen. Original parent effect is destroyed in that case but derived should still be reactive. It wasn't prior to this fix because inside `get` the `destroyed` variable would be true and so deps would not properly be recorded. Fixes https://github.com/sveltejs/kit/issues/14814	3 weeks ago
Simon H	7fd2d8660f	fix: parallelize async `@const`s in the template (#17165 ) * fix: parallelize async `@const`s in the template This fixes #17075 by solving the TODO of #17038 to add out of order rendering for async `@const` declarations in the template. It's implemented by a new field on the component state which is set as soon as we come across an async const. All async const declarations and those after it will be added to that field, and the existing blockers mechanism is then used to line up the async work correctly. After processing a fragment a `run` command is created from the collected consts. * fix * tweak --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	3 weeks ago
github-actions[bot]	b9c7e45408	Version Packages (#17161 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago
Rich Harris	c02ad03bfd	fix: overhaul `each` blocks (#17150 ) * state.items -> state.onscreen * offscreen_items -> state.offscreen * WIP * WIP * WIP * WIP * WIP * WIP * WIP * WIP * always push * fix * note to self * tweak/fix * tidy up * simplify * unused * clarity * note to self * simplify * one test to go * holy shit i think it works * unused * reduce number of bitwise checks * revert * small tweak * better comment * update note to self * fix: each block losing reactivity when items removed while promise pending (#17151) Co-authored-by: dylan <dylanbradshaw107@hotmail.com> Co-authored-by: Rich Harris <rich.harris@vercel.com> * add commented-out test, todo investigate --------- Co-authored-by: dylan1951 <58990501+dylan1951@users.noreply.github.com> Co-authored-by: dylan <dylanbradshaw107@hotmail.com> Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	3 weeks ago
github-actions[bot]	1e0c8c544c	Version Packages (#17159 ) Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>	3 weeks ago

1 2 3 4 5 ...

2302 Commits (elliott/17313-out-of-bounds-error)