svelte

Commit Graph

Author	SHA1	Message	Date
Simon H	1c150a460f	fix: abort running obsolete async branches (#18118 ) We shouldn't continue executing async work where we know the surrounding branch is destroyed already, it can leave to noisy "derived inter" warnings or even runtime errors ("cannot stringify symbol" when running a template effect with an uninitialized source). Neither should we warn about waterfalls on an already-destroyed async effect. Fixes #18097 (though strictly speaking that particular instance is also fixed by #18117 which fixes the underlying cause for the reruns; this one is necessary in itself though, as shown by the new test) --------- Co-authored-by: Rich Harris <rich.harris@vercel.com>	3 months ago

Author

SHA1

Message

Date

Simon H

1c150a460f

fix: abort running obsolete async branches (#18118 )

We shouldn't continue executing async work where we know the surrounding
branch is destroyed already, it can leave to noisy "derived inter"
warnings or even runtime errors ("cannot stringify symbol" when running
a template effect with an uninitialized source). Neither should we warn
about waterfalls on an already-destroyed async effect.

Fixes #18097 (though strictly speaking that particular instance is also
fixed by #18117 which fixes the underlying cause for the reruns; this
one is necessary in itself though, as shown by the new test)

---------

Co-authored-by: Rich Harris <rich.harris@vercel.com>

1 Commits (batch-branches-fix)