svelte

Commit Graph

Author	SHA1	Message	Date
Nic Polumeyv	3b559bbf96	fix: avoid NaN keyframe values in slide transition (#18430 ) Fixes #14205 When a `slide` transition runs on an element without a layout box, for example inside a `display: none` parent, `getComputedStyle` returns values like `auto` for the animated dimensions. These were passed through `parseFloat` unguarded, so the generated css contained `height: NaNpx` and the browser rejected the keyframe property with an "Invalid keyframe value" warning on every transition. Fix it by omitting properties if they have unparseable numbers - it's the same outcome but you don't see a warning. --------- Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	1 month ago

Author

SHA1

Message

Date

Nic Polumeyv

3b559bbf96

fix: avoid NaN keyframe values in slide transition (#18430 )

Fixes #14205

When a `slide` transition runs on an element without a layout box, for example inside a `display: none` parent, `getComputedStyle` returns values like `auto` for the animated dimensions. These were passed through `parseFloat` unguarded, so the generated css contained `height: NaNpx` and the browser rejected the keyframe property with an "Invalid keyframe value" warning on every transition.

Fix it by omitting properties if they have unparseable numbers - it's the same outcome but you don't see a warning.

---------

Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>

1 Commits (18704-preserve-locations)