svelte

Commit Graph

Author	SHA1	Message	Date
Nic Polumeyv	b2a24b0426	fix: run `onDestroy` callbacks when a server render throws (#18585 ) Fixes #18584. There's multiple parts to this - abort signal was buggy. It wasn't scoped per render, so cross-talk was possible. Fix by scoping to renderer - onDestroy callbacks were skipped when something throws. Fix by carefully aborting the rest of the tree, waiting for settle, collect all callbacks and then call them --------- Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com> Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>	1 month ago

Author

SHA1

Message

Date

Nic Polumeyv

b2a24b0426

fix: run `onDestroy` callbacks when a server render throws (#18585 )

Fixes #18584.

There's multiple parts to this
- abort signal was buggy. It wasn't scoped per render, so cross-talk was possible. Fix by scoping to renderer
- onDestroy callbacks were skipped when something throws. Fix by carefully aborting the rest of the tree, waiting for settle, collect all callbacks and then call them

---------

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Simon Holthausen <simon.holthausen@vercel.com>

1 Commits (18704-preserve-locations)