From 3b148b6635d77b5ef558ce72dbc2afb8fe529d58 Mon Sep 17 00:00:00 2001 From: PaulMaly Date: Mon, 11 Nov 2019 11:20:17 +0300 Subject: [PATCH] User `let` instead `var` for loop index User `let` instead `var` for loop index to prevent naming collisions with top-level scope. To reproduce: https://svelte.dev/repl/33152732e43049cfaf171bc6f10fd88f?version=3.13.0 --- src/compiler/compile/render_dom/wrappers/Element/index.ts | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/compiler/compile/render_dom/wrappers/Element/index.ts b/src/compiler/compile/render_dom/wrappers/Element/index.ts index 168d53d997..75c2cc6096 100644 --- a/src/compiler/compile/render_dom/wrappers/Element/index.ts +++ b/src/compiler/compile/render_dom/wrappers/Element/index.ts @@ -634,10 +634,10 @@ export default class ElementWrapper extends Wrapper { }); block.chunks.init.push(b` - var ${levels} = [${initial_props}]; + let ${levels} = [${initial_props}]; - var ${data} = {}; - for (var #i = 0; #i < ${levels}.length; #i += 1) { + let ${data} = {}; + for (let #i = 0; #i < ${levels}.length; #i += 1) { ${data} = @assign(${data}, ${levels}[#i]); } `); @@ -931,4 +931,4 @@ function to_html(wrappers: Array, blo } } }); -} \ No newline at end of file +}