From ff0abb1061bb9180a1c7e4f036586dfd0fc0dbef Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Fri, 23 Nov 2018 18:14:57 -0500 Subject: [PATCH] update some more tests --- test/runtime/samples/binding-input-radio-group/_config.js | 2 -- .../samples/binding-input-text-contextual/_config.js | 2 +- .../samples/binding-input-text-deconflicted/_config.js | 4 ++-- .../binding-input-text-deep-computed-dynamic/_config.js | 8 ++++---- .../samples/binding-input-text-deep-computed/_config.js | 4 ++-- .../_config.js | 8 ++++---- .../samples/binding-input-text-deep-contextual/_config.js | 4 ++-- .../binding-select-implicit-option-value/_config.js | 4 ++-- test/runtime/samples/binding-select-in-yield/_config.js | 4 ++-- test/runtime/samples/binding-select/_config.js | 4 ++-- test/runtime/samples/bindings-before-oncreate/_config.js | 5 ----- .../One.html | 0 .../Two.html | 0 .../main.html | 0 test/runtime/samples/bindings-coalesced/_config.js | 2 +- 15 files changed, 22 insertions(+), 29 deletions(-) delete mode 100644 test/runtime/samples/bindings-before-oncreate/_config.js rename test/runtime/samples/{bindings-before-oncreate => bindings-before-onmount}/One.html (100%) rename test/runtime/samples/{bindings-before-oncreate => bindings-before-onmount}/Two.html (100%) rename test/runtime/samples/{bindings-before-oncreate => bindings-before-onmount}/main.html (100%) diff --git a/test/runtime/samples/binding-input-radio-group/_config.js b/test/runtime/samples/binding-input-radio-group/_config.js index 95ae3f3446..d16f17bf77 100644 --- a/test/runtime/samples/binding-input-radio-group/_config.js +++ b/test/runtime/samples/binding-input-radio-group/_config.js @@ -5,8 +5,6 @@ const values = [ ]; export default { - solo: 1, - props: { values, selected: values[1] diff --git a/test/runtime/samples/binding-input-text-contextual/_config.js b/test/runtime/samples/binding-input-text-contextual/_config.js index 56888ee805..80285c52f3 100644 --- a/test/runtime/samples/binding-input-text-contextual/_config.js +++ b/test/runtime/samples/binding-input-text-contextual/_config.js @@ -35,7 +35,7 @@ export default { assert.equal(inputs[0].value, 'one'); inputs[1].value = 'four'; - inputs[1].dispatchEvent(event); + await inputs[1].dispatchEvent(event); assert.equal(items[1], 'four'); assert.htmlEqual(target.innerHTML, ` diff --git a/test/runtime/samples/binding-input-text-deconflicted/_config.js b/test/runtime/samples/binding-input-text-deconflicted/_config.js index 73196531a0..b3bce567a8 100644 --- a/test/runtime/samples/binding-input-text-deconflicted/_config.js +++ b/test/runtime/samples/binding-input-text-deconflicted/_config.js @@ -15,14 +15,14 @@ export default { `, - test(assert, component, target, window) { + async test(assert, component, target, window) { const input = target.querySelector('input'); assert.equal(input.value, 'world'); const event = new window.Event('input'); input.value = 'everybody'; - input.dispatchEvent(event); + await input.dispatchEvent(event); assert.equal(input.value, 'everybody'); assert.htmlEqual(target.innerHTML, ` diff --git a/test/runtime/samples/binding-input-text-deep-computed-dynamic/_config.js b/test/runtime/samples/binding-input-text-deep-computed-dynamic/_config.js index a0d95f1dc2..6c91b6b955 100644 --- a/test/runtime/samples/binding-input-text-deep-computed-dynamic/_config.js +++ b/test/runtime/samples/binding-input-text-deep-computed-dynamic/_config.js @@ -18,7 +18,7 @@ export default { 
{"foo":"a","bar":"b","baz":"c"}
`, - test(assert, component, target, window) { + async test(assert, component, target, window) { const input = target.querySelector('input'); const event = new window.Event('input'); @@ -26,7 +26,7 @@ export default { // edit bar input.value = 'e'; - input.dispatchEvent(event); + await input.dispatchEvent(event); assert.htmlEqual(target.innerHTML, ` @@ -38,7 +38,7 @@ export default { assert.equal(input.value, 'c'); input.value = 'f'; - input.dispatchEvent(event); + await input.dispatchEvent(event); assert.htmlEqual(target.innerHTML, ` @@ -50,7 +50,7 @@ export default { assert.equal(input.value, 'a'); input.value = 'd'; - input.dispatchEvent(event); + await input.dispatchEvent(event); assert.htmlEqual(target.innerHTML, ` diff --git a/test/runtime/samples/binding-input-text-deep-computed/_config.js b/test/runtime/samples/binding-input-text-deep-computed/_config.js index 7af7fc23dc..c30bbe3069 100644 --- a/test/runtime/samples/binding-input-text-deep-computed/_config.js +++ b/test/runtime/samples/binding-input-text-deep-computed/_config.js @@ -16,7 +16,7 @@ export default {

hello alice

`, - test(assert, component, target, window) { + async test(assert, component, target, window) { const input = target.querySelector('input'); assert.equal(input.value, 'alice'); @@ -24,7 +24,7 @@ export default { const event = new window.Event('input'); input.value = 'bob'; - input.dispatchEvent(event); + await input.dispatchEvent(event); assert.htmlEqual(target.innerHTML, ` diff --git a/test/runtime/samples/binding-input-text-deep-contextual-computed-dynamic/_config.js b/test/runtime/samples/binding-input-text-deep-contextual-computed-dynamic/_config.js index ffb8ad4c91..5371a14d5d 100644 --- a/test/runtime/samples/binding-input-text-deep-contextual-computed-dynamic/_config.js +++ b/test/runtime/samples/binding-input-text-deep-contextual-computed-dynamic/_config.js @@ -20,7 +20,7 @@ export default { 
{"foo":"a","bar":"b","baz":"c"}
`, - test(assert, component, target, window) { + async test(assert, component, target, window) { const input = target.querySelector('input'); const event = new window.Event('input'); @@ -28,7 +28,7 @@ export default { // edit bar input.value = 'e'; - input.dispatchEvent(event); + await input.dispatchEvent(event); assert.htmlEqual(target.innerHTML, ` @@ -40,7 +40,7 @@ export default { assert.equal(input.value, 'c'); input.value = 'f'; - input.dispatchEvent(event); + await input.dispatchEvent(event); assert.htmlEqual(target.innerHTML, ` @@ -52,7 +52,7 @@ export default { assert.equal(input.value, 'a'); input.value = 'd'; - input.dispatchEvent(event); + await input.dispatchEvent(event); assert.htmlEqual(target.innerHTML, ` diff --git a/test/runtime/samples/binding-input-text-deep-contextual/_config.js b/test/runtime/samples/binding-input-text-deep-contextual/_config.js index 3ae3f36aa8..9d0e71c210 100644 --- a/test/runtime/samples/binding-input-text-deep-contextual/_config.js +++ b/test/runtime/samples/binding-input-text-deep-contextual/_config.js @@ -19,7 +19,7 @@ export default {

three

`, - test(assert, component, target, window) { + async test(assert, component, target, window) { const inputs = [...target.querySelectorAll('input')]; assert.equal(inputs[0].value, 'one'); @@ -27,7 +27,7 @@ export default { const event = new window.Event('input'); inputs[1].value = 'four'; - inputs[1].dispatchEvent(event); + await inputs[1].dispatchEvent(event); assert.htmlEqual(target.innerHTML, `

one

diff --git a/test/runtime/samples/binding-select-implicit-option-value/_config.js b/test/runtime/samples/binding-select-implicit-option-value/_config.js index 70cc297a38..fac9e2d1c6 100644 --- a/test/runtime/samples/binding-select-implicit-option-value/_config.js +++ b/test/runtime/samples/binding-select-implicit-option-value/_config.js @@ -24,7 +24,7 @@ export default {

foo: 2

`, - test(assert, component, target, window) { + async test(assert, component, target, window) { const select = target.querySelector('select'); const options = [...target.querySelectorAll('option')]; @@ -34,7 +34,7 @@ export default { const change = new window.Event('change'); options[2].selected = true; - select.dispatchEvent(change); + await select.dispatchEvent(change); assert.equal(component.foo, 3); assert.htmlEqual( target.innerHTML, ` diff --git a/test/runtime/samples/binding-select-in-yield/_config.js b/test/runtime/samples/binding-select-in-yield/_config.js index 19cad9658b..708f8ce53b 100644 --- a/test/runtime/samples/binding-select-in-yield/_config.js +++ b/test/runtime/samples/binding-select-in-yield/_config.js @@ -5,7 +5,7 @@ export default { letter: 'b' }, - test(assert, component, target, window) { + async test(assert, component, target, window) { component.modal.toggle(); assert.htmlEqual(target.innerHTML, ` @@ -22,7 +22,7 @@ export default { const change = new window.MouseEvent('change'); select.options[2].selected = true; - select.dispatchEvent(change); + await select.dispatchEvent(change); assert.equal(component.letter, 'c'); assert.deepEqual(Array.from(select.options).map(o => o.selected), [ diff --git a/test/runtime/samples/binding-select/_config.js b/test/runtime/samples/binding-select/_config.js index 389f99ef03..4c0ff9030f 100644 --- a/test/runtime/samples/binding-select/_config.js +++ b/test/runtime/samples/binding-select/_config.js @@ -27,7 +27,7 @@ export default { selected: 'one', }, - test(assert, component, target, window) { + async test(assert, component, target, window) { const select = target.querySelector('select'); const options = [...target.querySelectorAll('option')]; @@ -37,7 +37,7 @@ export default { const change = new window.Event('change'); options[1].selected = true; - select.dispatchEvent(change); + await select.dispatchEvent(change); assert.equal(component.selected, 'two'); assert.htmlEqual(target.innerHTML, ` diff --git a/test/runtime/samples/bindings-before-oncreate/_config.js b/test/runtime/samples/bindings-before-oncreate/_config.js deleted file mode 100644 index d2852ae0e9..0000000000 --- a/test/runtime/samples/bindings-before-oncreate/_config.js +++ /dev/null @@ -1,5 +0,0 @@ -export default { - test(assert, component) { - assert.equal(component.one.snapshot, 2); - } -}; \ No newline at end of file diff --git a/test/runtime/samples/bindings-before-oncreate/One.html b/test/runtime/samples/bindings-before-onmount/One.html similarity index 100% rename from test/runtime/samples/bindings-before-oncreate/One.html rename to test/runtime/samples/bindings-before-onmount/One.html diff --git a/test/runtime/samples/bindings-before-oncreate/Two.html b/test/runtime/samples/bindings-before-onmount/Two.html similarity index 100% rename from test/runtime/samples/bindings-before-oncreate/Two.html rename to test/runtime/samples/bindings-before-onmount/Two.html diff --git a/test/runtime/samples/bindings-before-oncreate/main.html b/test/runtime/samples/bindings-before-onmount/main.html similarity index 100% rename from test/runtime/samples/bindings-before-oncreate/main.html rename to test/runtime/samples/bindings-before-onmount/main.html diff --git a/test/runtime/samples/bindings-coalesced/_config.js b/test/runtime/samples/bindings-coalesced/_config.js index 282bce1475..af8fe6d3af 100644 --- a/test/runtime/samples/bindings-coalesced/_config.js +++ b/test/runtime/samples/bindings-coalesced/_config.js @@ -12,6 +12,6 @@ export default { foo.double(); - assert.deepEqual(values, [6]); + assert.deepEqual(values, ['6']); } }; \ No newline at end of file