From fb813c2c74ccb76b17fe47ec8b042b61b9172203 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Mon, 27 Nov 2023 16:39:53 -0500 Subject: [PATCH] simplify --- .../client/visitors/javascript-runes.js | 46 +++++-------------- 1 file changed, 11 insertions(+), 35 deletions(-) diff --git a/packages/svelte/src/compiler/phases/3-transform/client/visitors/javascript-runes.js b/packages/svelte/src/compiler/phases/3-transform/client/visitors/javascript-runes.js index 802c2beb96..d32e8fcbb6 100644 --- a/packages/svelte/src/compiler/phases/3-transform/client/visitors/javascript-runes.js +++ b/packages/svelte/src/compiler/phases/3-transform/client/visitors/javascript-runes.js @@ -302,49 +302,25 @@ export const javascript_visitors_runes = { if (rune === '$effect.active') { return b.call('$.effect_active'); } - if (rune === '$log') { - if (state.options.dev) { - const args = /** @type {import('estree').Expression[]} */ ( - node.arguments.map((arg) => visit(arg)) - ); - return b.call('$.log', b.thunk(b.array(args))); - } - return b.unary('void', b.literal(0)); - } - if (rune === '$log.trace') { - if (state.options.dev) { - const args = /** @type {import('estree').Expression[]} */ ( - node.arguments.map((arg) => visit(arg)) - ); - return b.call('$.log_trace', b.thunk(b.array(args))); - } - return b.unary('void', b.literal(0)); - } - if (rune === '$log.break') { - if (state.options.dev) { - const args = /** @type {import('estree').Expression[]} */ ( - node.arguments.map((arg) => visit(arg)) - ); - return b.call('$.log_break', b.thunk(b.array(args))); - } - return b.unary('void', b.literal(0)); + if (rune === '$effect.root') { + const args = /** @type {import('estree').Expression[]} */ ( + node.arguments.map((arg) => visit(arg)) + ); + return b.call('$.user_root_effect', ...args); } - if (rune === '$log.table') { + + if (rune?.startsWith('$log')) { if (state.options.dev) { const args = /** @type {import('estree').Expression[]} */ ( node.arguments.map((arg) => visit(arg)) ); - return b.call('$.log_table', b.thunk(b.array(args))); + + const callee = rune === '$log' ? '$.log' : `$.log_${rune.slice(5)}`; + return b.call(callee, b.thunk(b.array(args))); } - return b.unary('void', b.literal(0)); - } - if (rune === '$effect.root') { - const args = /** @type {import('estree').Expression[]} */ ( - node.arguments.map((arg) => visit(arg)) - ); - return b.call('$.user_root_effect', ...args); + return b.unary('void', b.literal(0)); } next();