From fb51dd8f072468aa81052e123d8fb6b2193d7489 Mon Sep 17 00:00:00 2001
From: Bassam Ismail <skippednote@gmail.com>
Date: Wed, 5 Aug 2020 21:51:44 +0530
Subject: [PATCH] add a11y-media-has-caption check (#5075)

---
 src/compiler/compile/nodes/Element.ts         | 19 +++++++++++
 .../expected.html                             |  4 +--
 .../input.svelte                              |  6 ++--
 .../a11y-media-has-caption/input.svelte       |  4 +++
 .../a11y-media-has-caption/warnings.json      | 32 +++++++++++++++++++
 5 files changed, 60 insertions(+), 5 deletions(-)
 create mode 100644 test/validator/samples/a11y-media-has-caption/input.svelte
 create mode 100644 test/validator/samples/a11y-media-has-caption/warnings.json

diff --git a/src/compiler/compile/nodes/Element.ts b/src/compiler/compile/nodes/Element.ts
index ffcf0e51f2..145866cf4f 100644
--- a/src/compiler/compile/nodes/Element.ts
+++ b/src/compiler/compile/nodes/Element.ts
@@ -528,6 +528,25 @@ export default class Element extends Node {
 			}
 		}
 
+		if (this.is_media_node()) {
+			if (attribute_map.has('muted')) {
+				return;
+			}
+
+			let has_caption;
+			const track = this.children.find((i: Element) => i.name === 'track');
+			if (track) {
+				has_caption = track.attributes.find(a => a.name === 'kind' && a.get_static_value() === 'captions');
+			}
+
+			if (!has_caption) {
+				component.warn(this, {
+					code: `a11y-media-has-caption`,
+					message: `A11y: Media elements must have a <track kind="captions">`
+				});
+			}
+		}
+
 		if (a11y_no_onchange.has(this.name)) {
 			if (handlers_map.has('change') && !handlers_map.has('blur')) {
 				component.warn(this, {
diff --git a/test/css/samples/omit-scoping-attribute-attribute-selector/expected.html b/test/css/samples/omit-scoping-attribute-attribute-selector/expected.html
index 52175f98b6..f585d6bcdd 100644
--- a/test/css/samples/omit-scoping-attribute-attribute-selector/expected.html
+++ b/test/css/samples/omit-scoping-attribute-attribute-selector/expected.html
@@ -1,2 +1,2 @@
-<div><video class="svelte-xyz" autoplay></video>
-	<video></video></div>
\ No newline at end of file
+<div><video class="svelte-xyz" autoplay muted></video>
+	<video muted></video></div>
diff --git a/test/css/samples/omit-scoping-attribute-attribute-selector/input.svelte b/test/css/samples/omit-scoping-attribute-attribute-selector/input.svelte
index 6f4549ead8..af06836d29 100644
--- a/test/css/samples/omit-scoping-attribute-attribute-selector/input.svelte
+++ b/test/css/samples/omit-scoping-attribute-attribute-selector/input.svelte
@@ -1,10 +1,10 @@
 <div>
-	<video autoplay></video>
-	<video></video>
+	<video autoplay muted></video>
+	<video muted></video>
 </div>
 
 <style>
 	[autoplay] {
 		color: red;
 	}
-</style>
\ No newline at end of file
+</style>
diff --git a/test/validator/samples/a11y-media-has-caption/input.svelte b/test/validator/samples/a11y-media-has-caption/input.svelte
new file mode 100644
index 0000000000..105269cddb
--- /dev/null
+++ b/test/validator/samples/a11y-media-has-caption/input.svelte
@@ -0,0 +1,4 @@
+<video><track kind="captions"/></video>
+<video></video>
+<video><track /></video>
+<audio muted></audio>
diff --git a/test/validator/samples/a11y-media-has-caption/warnings.json b/test/validator/samples/a11y-media-has-caption/warnings.json
new file mode 100644
index 0000000000..a8c894b1d4
--- /dev/null
+++ b/test/validator/samples/a11y-media-has-caption/warnings.json
@@ -0,0 +1,32 @@
+[
+  {
+    "code": "a11y-media-has-caption",
+    "end": {
+      "character": 55,
+      "column": 15,
+      "line": 2
+    },
+    "message": "A11y: Media elements must have a <track kind=\"captions\">",
+    "pos": 40,
+    "start": {
+      "character": 40,
+      "column": 0,
+      "line": 2
+    }
+  },
+  {
+    "code": "a11y-media-has-caption",
+    "end": {
+      "character": 80,
+      "column": 24,
+      "line": 3
+    },
+    "message": "A11y: Media elements must have a <track kind=\"captions\">",
+    "pos": 56,
+    "start": {
+      "character": 56,
+      "column": 0,
+      "line": 3
+    }
+  }
+]