From eaf0087d7c5671794ee25521667860b1a8af1828 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Fri, 7 Mar 2025 10:02:58 -0500 Subject: [PATCH] fix: skip `log_if_contains_state` if only logging literals (#15468) --- .changeset/hungry-monkeys-fly.md | 5 +++++ .../phases/3-transform/client/visitors/CallExpression.js | 3 ++- 2 files changed, 7 insertions(+), 1 deletion(-) create mode 100644 .changeset/hungry-monkeys-fly.md diff --git a/.changeset/hungry-monkeys-fly.md b/.changeset/hungry-monkeys-fly.md new file mode 100644 index 0000000000..f52c8dad92 --- /dev/null +++ b/.changeset/hungry-monkeys-fly.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: skip `log_if_contains_state` if only logging literals diff --git a/packages/svelte/src/compiler/phases/3-transform/client/visitors/CallExpression.js b/packages/svelte/src/compiler/phases/3-transform/client/visitors/CallExpression.js index 7a3057451a..fda43ad791 100644 --- a/packages/svelte/src/compiler/phases/3-transform/client/visitors/CallExpression.js +++ b/packages/svelte/src/compiler/phases/3-transform/client/visitors/CallExpression.js @@ -44,7 +44,8 @@ export function CallExpression(node, context) { node.callee.property.type === 'Identifier' && ['debug', 'dir', 'error', 'group', 'groupCollapsed', 'info', 'log', 'trace', 'warn'].includes( node.callee.property.name - ) + ) && + node.arguments.some((arg) => arg.type !== 'Literal') // TODO more cases? ) { return b.call( node.callee,