address feedback

pull/12745/head
Dominic Gannaway 2 years ago
parent e6a2e0a564
commit eaa2dc26dd

@ -214,11 +214,6 @@ export function client_component(analysis, options) {
: b.thunk(store_get)
)
);
if (dev) {
store_setup.push(
b.stmt(b.assignment('=', b.member(binding.node, b.id('$is_store')), b.literal(true)))
);
}
}
}

@ -207,6 +207,17 @@ export function build_bind_this(expression, value, { state, visit }) {
export function build_validate_binding(state, binding, expression) {
const string = state.analysis.source.slice(binding.start, binding.end);
if (
binding.expression.type === 'MemberExpression' &&
binding.expression.object.type === 'Identifier'
) {
var ref_binding = state.scope.get(binding.expression.object.name);
if (ref_binding?.kind === 'store_sub') {
return b.empty;
}
}
const get_object = b.thunk(/** @type {Expression} */ (expression.object));
const get_property = b.thunk(
/** @type {Expression} */ (

@ -105,8 +105,7 @@ export function validate_binding(binding, get_object, get_property, line, column
var filename = dev_current_component_function?.[FILENAME];
render_effect(() => {
// @ts-ignore
if (warned || get_object.$is_store) return;
if (warned) return;
var object = get_object();
var property = get_property();

Loading…
Cancel
Save