Merge branch 'main' into selectedcontent-oninput-interfere

.changeset/dull-oranges-fry.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: avoid declaration tag warning in event handlers

.changeset/young-doodles-beam.md

@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: don't treat declaration tags as parts inside each blocks

packages/svelte/src/compiler/phases/2-analyze/visitors/shared/function.js

@@ -18,7 +18,9 @@ export function visit_function(node, context) {
 
 	context.next({
 		...context.state,
-		function_depth: context.state.function_depth + 1,
+		// we generally want to use scope.function_depth unless we specifically increased
+		// that in state.function_depth (e.g. a derived)
+		function_depth: Math.max(context.state.scope.function_depth, context.state.function_depth) + 1,
 		expression: null
 	});
 }

packages/svelte/src/compiler/phases/3-transform/client/visitors/shared/utils.js

@@ -8,7 +8,7 @@ import { sanitize_template_string } from '../../../../../utils/sanitize_template
 import { regex_is_valid_identifier } from '../../../../patterns.js';
 import is_reference from 'is-reference';
 import { dev, is_ignored, locator, component_name } from '../../../../../state.js';
-import { build_getter } from '../../utils.js';
+import { build_getter, is_state_source } from '../../utils.js';
 import { ExpressionMetadata } from '../../../../nodes.js';
 
 /**
@@ -272,6 +272,10 @@ export function build_bind_this(expression, value, { state, visit }) {
 			const binding = state.scope.get(node.name);
 			if (!binding) return;
 
+			// if it is a state or a derived it means is a declaration tag...in that case we don't want to pass the
+			// value but the signal itself or assignment will break
+			if (is_state_source(binding, state.analysis) || binding.kind === 'derived') return;
+
 			for (const [owner, scope] of state.scopes) {
 				if (owner.type === 'EachBlock' && scope === binding.scope) {
 					ids.push(node);

packages/svelte/tests/runtime-runes/samples/declaration-tags-each/_config.js

@@ -0,0 +1,10 @@
+import { flushSync } from 'svelte';
+import { test } from '../../test';
+
+export default test({
+	async test({ target, assert }) {
+		const [btn1, btn2] = target.querySelectorAll('button');
+		flushSync(() => btn2.click());
+		assert.equal(btn1.textContent, '1');
+	}
+});

packages/svelte/tests/runtime-runes/samples/declaration-tags-each/main.svelte

@@ -0,0 +1,6 @@
+{#each Array(1)}
+	{let ref = $state()}
+	{let count = $state(0)}
+	<button onclick={()=>count++} bind:this={ref}>{count}</button>
+	<button onclick={()=>ref.click()}></button>
+{/each}

packages/svelte/tests/validator/samples/declaration-tag-state-referenced-locally/input.svelte

@@ -7,3 +7,7 @@
 {let e = $state(0), f = e}
 
 {a}{b}{c}{d}{e}{f}
+
+<button onclick={() => {
+	console.log(a);
+}}>a</button>