diff --git a/.github/stale.yml b/.github/stale.yml deleted file mode 100644 index c95bc4cf22..0000000000 --- a/.github/stale.yml +++ /dev/null @@ -1,52 +0,0 @@ -# Configuration for probot-stale - https://github.com/probot/stale - -# Only issues or pull requests with all of these labels are check if stale. Defaults to `[]` (disabled) -onlyLabels: [] - -# Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable -exemptLabels: - - popular - - pinned - - security - - bug - - "[Status] Maybe Later" - -# Set to true to ignore issues in a project (defaults to false) -exemptProjects: false - -# Set to true to ignore issues in a milestone (defaults to false) -exemptMilestones: false - -# Set to true to ignore issues with an assignee (defaults to false) -exemptAssignees: false - -# Label to use when marking as stale -staleLabel: stale-bot - -# Comment to post when removing the stale label. -# unmarkComment: > -# Your comment here. - -# Limit the number of actions per hour, from 1-30. Default is 30 -limitPerRun: 1 - -# Optionally, specify configuration settings that are specific to just 'issues' or 'pulls': -pulls: - daysUntilStale: 210 - daysUntilClose: 25 - markComment: > - This pull request has been automatically marked as stale because it has not had - recent activity. It will be closed if no further activity occurs. Thank you - for your contributions. - closeComment: > - This pull request has been closed as it was previously marked as stale and saw no subsequent activity. - -issues: - daysUntilStale: 180 - daysUntilClose: 14 - markComment: > - This issue has been automatically marked as stale because it has not had - recent activity. It will be closed if no further activity occurs. Thank you - for your contributions. - closeComment: > - This issue has been closed as it was previously marked as stale and saw no subsequent activity. diff --git a/CHANGELOG.md b/CHANGELOG.md index a7444fe9c6..dbf2c6fac2 100644 --- a/CHANGELOG.md +++ b/CHANGELOG.md @@ -1,8 +1,9 @@ # Svelte changelog -## unreleased +## Unreleased -* Fix non-boolean attribute rendering in SSR to render truthy values as is, making it consistent with DOM rendering. ([#6121](https://github.com/sveltejs/svelte/issues/6121)) +* Fix non-boolean attribute rendering in SSR to render truthy values as-is ([#6121](https://github.com/sveltejs/svelte/issues/6121)) +* Add `a11y-no-redundant-roles` warning ([#7067](https://github.com/sveltejs/svelte/pull/7067)) ## 3.44.3 diff --git a/LICENSE.md b/LICENSE.md index cbf510847f..cd8f94f4ca 100644 --- a/LICENSE.md +++ b/LICENSE.md @@ -1,4 +1,4 @@ -Copyright (c) 2016-21 [these people](https://github.com/sveltejs/svelte/graphs/contributors) +Copyright (c) 2016-22 [these people](https://github.com/sveltejs/svelte/graphs/contributors) Permission is hereby granted, free of charge, to any person obtaining a copy of this software and associated documentation files (the "Software"), to deal in the Software without restriction, including without limitation the rights to use, copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the Software, and to permit persons to whom the Software is furnished to do so, subject to the following conditions: diff --git a/package.json b/package.json index ee6c781860..233772b8a2 100644 --- a/package.json +++ b/package.json @@ -83,8 +83,8 @@ }, "types": "types/runtime/index.d.ts", "scripts": { - "test": "mocha", - "test:unit": "mocha --require sucrase/register --recursive src/**/__test__.ts", + "test": "mocha --exit", + "test:unit": "mocha --require sucrase/register --recursive src/**/__test__.ts --exit", "quicktest": "mocha", "precoverage": "c8 mocha", "coverage": "c8 report --reporter=text-lcov > coverage.lcov && c8 report --reporter=html", diff --git a/site/content/blog/2019-04-22-svelte-3-rethinking-reactivity.md b/site/content/blog/2019-04-22-svelte-3-rethinking-reactivity.md index c372d2a85b..672fe1b777 100644 --- a/site/content/blog/2019-04-22-svelte-3-rethinking-reactivity.md +++ b/site/content/blog/2019-04-22-svelte-3-rethinking-reactivity.md @@ -94,4 +94,4 @@ We don't take this lightly: hopefully once you've experienced Svelte 3 you'll un As grueling as this release has been, we're nowhere near finished. We have a ton of ideas for generating smarter, more compact code, and a long feature wish-list. [Sapper](https://sapper.svelte.dev), our Next.js-style app framework, is still in the middle of being updated to use Svelte 3. The [Svelte Native](https://svelte-native.technology/) community project, which allows you to write Android and iOS apps in Svelte, is making solid progress but deserves more complete support from core. We don't yet have the bounty of editor extensions, syntax highlighters, component kits, devtools and so on that other frameworks have, and we should fix that. We *really* want to add first-class TypeScript support. -But in the meantime we think Svelte 3 is the best way to build web apps yet. Take an hour to go through the [tutorial](/tutorial) and we hope to convince you of the same. Either way, we'd love to see you in our [Discord chatroom](/chat) and on [GitHub](https://github.com/sveltejs/svelte) — everyone is welcome, especially you. +But in the meantime we think Svelte 3 is the best way to build web apps yet. Take an hour to go through the [tutorial](/tutorial) and we hope to convince you of the same. Either way, we'd love to see you in our [Discord chatroom](https://svelte.dev/chat) and on [GitHub](https://github.com/sveltejs/svelte) — everyone is welcome, especially you. diff --git a/site/content/blog/2022-01-01-whats-new-in-svelte-january-2022.md b/site/content/blog/2022-01-01-whats-new-in-svelte-january-2022.md new file mode 100644 index 0000000000..bf7bc3df57 --- /dev/null +++ b/site/content/blog/2022-01-01-whats-new-in-svelte-january-2022.md @@ -0,0 +1,77 @@ +--- +title: "What's new in Svelte: January 2022" +description: "Faster builds with SvelteKit and a much anticipated REPL feature" +author: Daniel Sandoval +authorURL: https://desandoval.net +--- + +Happy new year, Svelte Community! Lots to share this month across Svelte, SvelteKit, Language Tools and the Showcase. Thanks to everyone who made 2021 a great year to use Svelte. Looking forward to the next one 🚀 + +## What's new in SvelteKit +- `@sveltejs/adapter-static` for SvelteKit now has a `precompress` option to make brotli compression of assets and pages easier to do out of the box ([#3079](https://github.com/sveltejs/kit/pull/3079)) +- Concurrency mode in SvelteKit will now prerender pages in parallel ([#3120](https://github.com/sveltejs/kit/pull/3120)). It is enabled by default in `1.0.0-next.205` and later +- CSS is now automatically included before JS for improved page performance ([d13efe](https://github.com/sveltejs/kit/commit/d138efe21692f5925f1e89afc0a33f42d6a1a711)) +- A new config option adds the ability to disable service worker registration to do your own custom registration ([#2988](https://github.com/sveltejs/kit/pull/2988)) +- SSR route-splitting is here - breaking monolithic builds into smaller pieces for improved startup and routing performance ([#2931](https://github.com/sveltejs/kit/pull/2931)) +- `request.origin/path/query` is now `request.url` - simplifying the config and page `load` functions ([#3126](https://github.com/sveltejs/kit/pull/3126)) +- After the [update to Vite 2.7](https://github.com/sveltejs/kit/pull/3018), SvelteKit users are [reporting significant performance improvements](https://www.reddit.com/r/sveltejs/comments/rljhfc/sveltekit_massive_compiler_improvement_by/) and loading third-parties libraries in SSR has also been greatly improved +- SvelteKit server will now automatically restart when the config files is changed ([vite-plugin-svelte#237](https://github.com/sveltejs/vite-plugin-svelte/pull/237)) + + +## Other new bits from `svelte/*` +- [Svelte 3.44.3](https://github.com/sveltejs/svelte/blob/master/CHANGELOG.md#3443) is out with a few bug fixes in the binding and loop code +- Svelte Language Tools has introduced support for the then/catch shorthands from Svelte 3.41 and TypeScript's "go to" functionality ([105.8.0 and later](https://github.com/sveltejs/language-tools/releases/tag/extensions-105.8.0)) +- The Svelte REPL got a nice upgrade as well - letting you delete saved REPLs. Try it out by logging in at [svelte.dev/apps](https://svelte.dev/apps) + + +--- + +## Community Showcase + +**Apps & Sites** +- [Discover Twitter Spaces](https://github.com/navneetsharmaui/discover-twitter-spaces) is a tool that helps you find the Twitter Spaces +- [Modern Fluid Typography Editor](https://github.com/codeAdrian/modern-fluid-typography-editor) helps create beautiful fluid typography using CSS clamp +- [Unnwhiteboard](https://github.com/AviKKi/unnwhiteboard) is a job board for companies (or teams) that don't do "whiteboard" interviews +- [Secret Santa](https://gitlab.com/arturoguzman/secret-santa-sveltekit) is a gift giving coordination app developed with easiness in mind +- [LogSnag](https://logsnag.com/) notifies you of your projects' events and provides you with a timeline to keep track of anything important that happens +- [Version 0.2 of Tangent](http://tangentnotes.com/Download), a Svelte-based note writing app, is now in beta +- [Intl Explorer](https://github.com/jesperorb/intl-explorer) is a tool for viewing output for all possible formatters for Intl + +A lot of work this month has gone into migrating the Svelte main website and Svelte REPL to live in the https://github.com/sveltejs/sites repository - including a brand new homepage for [svelte.dev](https://svelte.dev/). Thanks to all the contributors who made this possible! + +If you're looking for a fun SvelteKit project to work on, [you can contribute to the Svelte Society site rewrite](https://github.com/svelte-society/sveltesociety-2021/issues) 💅 + + +**Learning and Listening** + +_To Read_ +- [Mutating Query Params in SvelteKit Without Page Reloads or Navigations](https://dev.to/mohamadharith/mutating-query-params-in-sveltekit-without-page-reloads-or-navigations-2i2b) by Mohamad Harith +- [Svelte for Reactaholics : A guide for React developers](https://www.100ms.live/blog/svelte-guide-for-react-developers) by Puru Vijay +- [Svelte's lifecycle methods can be used anywhere](https://geoffrich.net/posts/svelte-lifecycle-examples/) and [The many meanings of $ in Svelte](https://geoffrich.net/posts/svelte-$-meanings/) by Geoff Rich +- [Vercel and Svelte: A Perfect Match for Web Developers](https://thenewstack.io/vercel-and-svelte-a-perfect-match-for-web-developers/) by Darryl K. Taft +- [User-defined TailwindCSS Color Scheme with Svelte Stores](https://blog.dayslice.io/user-defined-tailwindcss-color-scheme-with-svelte-stores-ad80ca2cf038) by jeremy zaborowski +- [Ionic 6 + Svelte 🚀](https://medium.com/@raymondboswel/ionic-6-svelte-ae904caa82df) by Raymond Boswel +- [What happened in #Svelte language tools this year](https://twitter.com/dummdidumm_/status/1474158105395179525?t=ytj2K2Q52iD5-lNyLnQaAQ&s=19) by Simon H + +_To Watch_ +- [The Future of Svelte (Interview with Rich Harris)](https://www.youtube.com/watch?v=uQntFkK8Z54) by Lee Robinson, Director of Developer Relations at Vercel +- [Svelte is becoming the go-to framework](https://www.youtube.com/watch?v=fo6BKY2xR2w&t=1834s) for Obsidian plugin developers +- [Sveltekit WordPress Headless Blog](https://www.youtube.com/watch?v=c0UDVgjPxFw) by WebJeda +- [Getting started with SvelteKit](https://www.youtube.com/watch?v=i2suPKMPUFA) by Lihau Tan +- [Deploy a full-stack SvelteKit app on Cloudflare Pages](https://www.youtube.com/watch?v=Wc1_U6Dy5Tw) by 1nf + +_To Listen To_ +- [Syntax podcast: How To Do Things In Svelte](https://podcasts.apple.com/ca/podcast/how-to-do-things-in-svelte/id1253186678?i=1000544796072) +- [JS Party #205: So much Sveltey goodness (w/ Rich Harris)](https://changelog.com/jsparty/205) + +**Libraries, Tools & Components** +- [svelte-headlessui](https://github.com/rgossiaux/svelte-headlessui) is an unofficial, complete Svelte port of the Headless UI component library +- [svelte-forms v2](https://chainlist.github.io/svelte-forms/) has been released - the author is [looking for feedback](https://www.reddit.com/r/sveltejs/comments/r6354j/svelteforms_v2_has_been_released/) +- [Percival](https://github.com/ekzhang/percival) is a declarative data query and visualization language +- [Svelte FlatList](https://github.com/snuffyDev/svelte-flatlist) is a mobile-friendly, simple, and customizable draggable menu +- [svelte-keyed](https://github.com/bryanmylee/svelte-keyed) is a writable derived store for objects and arrays +- [Svemix](https://github.com/svemix/svemix) is Remix for Svelte - providing server scripts inside your Svelte components/routes, which will be transformed into endpoints + +Want to add something to the showcase? Need help bringing your next idea to life in Svelte? Join us on [Reddit](https://www.reddit.com/r/sveltejs/) or [Discord](https://discord.com/invite/yy75DKs). + +See ya next month! diff --git a/site/content/docs/00-introduction.md b/site/content/docs/00-introduction.md index 2fece5534f..11f82117e9 100644 --- a/site/content/docs/00-introduction.md +++ b/site/content/docs/00-introduction.md @@ -6,6 +6,6 @@ This page contains detailed API reference documentation. It's intended to be a r If that's not you (yet), you may prefer to visit the [interactive tutorial](/tutorial) or the [examples](/examples) before consulting this reference. -Don't be shy about asking for help in the [Discord chatroom](/chat). +Don't be shy about asking for help in the [Discord chatroom](https://svelte.dev/chat). Using an older version of Svelte? Have a look at the [v2 docs](https://v2.svelte.dev). diff --git a/site/content/examples/05-bindings/09-media-elements/App.svelte b/site/content/examples/05-bindings/09-media-elements/App.svelte index b4c5907f6d..de89b1be8d 100644 --- a/site/content/examples/05-bindings/09-media-elements/App.svelte +++ b/site/content/examples/05-bindings/09-media-elements/App.svelte @@ -50,7 +50,7 @@

Caminandes: Llamigos

-

From Blender Open Projects. CC-BY

+

From Blender Studio. CC-BY

Caminandes: Llamigos

-

From Blender Open Projects. CC-BY

+

From Blender Studio. CC-BY

Caminandes: Llamigos

-

From Blender Open Projects. CC-BY

+

From Blender Studio. CC-BY

({ + code: 'a11y-no-redundant-roles', + message: `A11y: Redundant role '${role}'` + }), a11y_accesskey: { code: 'a11y-accesskey', message: 'A11y: Avoid using accesskey' diff --git a/src/compiler/compile/nodes/Element.ts b/src/compiler/compile/nodes/Element.ts index 837a0296d0..bf81599bf6 100644 --- a/src/compiler/compile/nodes/Element.ts +++ b/src/compiler/compile/nodes/Element.ts @@ -70,6 +70,46 @@ const a11y_labelable = new Set([ 'textarea' ]); +const a11y_nested_implicit_semantics = new Map([ + ['header', 'banner'], + ['footer', 'contentinfo'] +]); + +const a11y_implicit_semantics = new Map([ + ['a', 'link'], + ['aside', 'complementary'], + ['body', 'document'], + ['datalist', 'listbox'], + ['dd', 'definition'], + ['dfn', 'term'], + ['details', 'group'], + ['dt', 'term'], + ['fieldset', 'group'], + ['form', 'form'], + ['h1', 'heading'], + ['h2', 'heading'], + ['h3', 'heading'], + ['h4', 'heading'], + ['h5', 'heading'], + ['h6', 'heading'], + ['hr', 'separator'], + ['li', 'listitem'], + ['menu', 'list'], + ['nav', 'navigation'], + ['ol', 'list'], + ['optgroup', 'group'], + ['output', 'status'], + ['progress', 'progressbar'], + ['section', 'region'], + ['summary', 'button'], + ['tbody', 'rowgroup'], + ['textarea', 'textbox'], + ['tfoot', 'rowgroup'], + ['thead', 'rowgroup'], + ['tr', 'row'], + ['ul', 'list'] +]); + const invisible_elements = new Set(['meta', 'html', 'script', 'style']); const valid_modifiers = new Set([ @@ -98,6 +138,23 @@ const react_attributes = new Map([ const attributes_to_compact_whitespace = ['class', 'style']; +function is_parent(parent: INode, elements: string[]) { + let check = false; + + while (parent) { + const parent_name = (parent as Element).name; + if (elements.includes(parent_name)) { + check = true; + break; + } + if (parent.type === 'Element') { + break; + } + parent = parent.parent; + } + return check; +} + function get_namespace(parent: Element, element: Element, explicit_namespace: string) { const parent_element = parent.find_nearest(/^Element/); @@ -351,6 +408,22 @@ export default class Element extends Node { const match = fuzzymatch(value, aria_roles); component.warn(attribute, compiler_warnings.a11y_unknown_role(value, match)); } + + // no-redundant-roles + const has_redundant_role = value === a11y_implicit_semantics.get(this.name); + + if (this.name === value || has_redundant_role) { + component.warn(attribute, compiler_warnings.a11y_no_redundant_roles(value)); + } + + // Footers and headers are special cases, and should not have redundant roles unless they are the children of sections or articles. + const is_parent_section_or_article = is_parent(this.parent, ['section', 'article']); + if (!is_parent_section_or_article) { + const has_nested_redundant_role = value === a11y_nested_implicit_semantics.get(this.name); + if (has_nested_redundant_role) { + component.warn(attribute, compiler_warnings.a11y_no_redundant_roles(value)); + } + } } // no-access-key diff --git a/src/compiler/utils/namespaces.ts b/src/compiler/utils/namespaces.ts index 01d9bd60b3..7da64afc8c 100644 --- a/src/compiler/utils/namespaces.ts +++ b/src/compiler/utils/namespaces.ts @@ -1,6 +1,6 @@ // The `foreign` namespace covers all DOM implementations that aren't HTML5. // It opts out of HTML5-specific a11y checks and case-insensitive attribute names. -export const foreign = 'https://svelte.dev/docs#svelte_options'; +export const foreign = 'https://svelte.dev/docs#template-syntax-svelte-options'; export const html = 'http://www.w3.org/1999/xhtml'; export const mathml = 'http://www.w3.org/1998/Math/MathML'; export const svg = 'http://www.w3.org/2000/svg'; diff --git a/test/custom-elements/index.ts b/test/custom-elements/index.ts index 35df156879..42b27eebd3 100644 --- a/test/custom-elements/index.ts +++ b/test/custom-elements/index.ts @@ -4,7 +4,7 @@ import * as http from 'http'; import { rollup } from 'rollup'; import virtual from '@rollup/plugin-virtual'; import puppeteer from 'puppeteer'; -import { addLineNumbers, loadConfig, loadSvelte } from '../helpers'; +import { addLineNumbers, loadConfig, loadSvelte, retryAsync, executeBrowserTest } from '../helpers'; import { deepEqual } from 'assert'; const page = ` @@ -17,8 +17,8 @@ const page = ` const assert = fs.readFileSync(`${__dirname}/assert.js`, 'utf-8'); describe('custom-elements', function() { + // Note: Increase the timeout in preparation for restarting Chromium due to SIGSEGV. this.timeout(10000); - let svelte; let server; let browser; @@ -44,12 +44,16 @@ describe('custom-elements', function() { }); } + async function launchPuppeteer() { + return await retryAsync(() => puppeteer.launch()); + } + before(async () => { svelte = loadSvelte(); console.log('[custom-element] Loaded Svelte'); server = await create_server(); console.log('[custom-element] Started server'); - browser = await puppeteer.launch(); + browser = await launchPuppeteer(); console.log('[custom-element] Launched puppeteer browser'); }); @@ -108,26 +112,7 @@ describe('custom-elements', function() { const result = await bundle.generate({ format: 'iife', name: 'test' }); code = result.output[0].code; - const page = await browser.newPage(); - - page.on('console', (type) => { - console[type._type](type._text); - }); - - page.on('error', error => { - console.log('>>> an error happened'); - console.error(error); - }); - - try { - await page.goto('http://localhost:6789'); - - const result = await page.evaluate(() => test(document.querySelector('main'))); - if (result) console.log(result); - } catch (err) { - console.log(addLineNumbers(code)); - throw err; - } finally { + function assertWarnings() { if (expected_warnings) { deepEqual(warnings.map(w => ({ code: w.code, @@ -138,6 +123,15 @@ describe('custom-elements', function() { })), expected_warnings); } } + + browser = await executeBrowserTest( + browser, + launchPuppeteer, + assertWarnings, + () => { + console.log(addLineNumbers(code)); + assertWarnings(); + }); }); }); }); diff --git a/test/helpers.ts b/test/helpers.ts index 101490d4dc..1ea0b19880 100644 --- a/test/helpers.ts +++ b/test/helpers.ts @@ -8,7 +8,7 @@ export const assert = (assert$1 as unknown) as typeof assert$1 & { htmlEqual: (a // for coverage purposes, we need to test source files, // but for sanity purposes, we need to test dist files -export function loadSvelte(test) { +export function loadSvelte(test: boolean = false) { process.env.TEST = test ? 'true' : ''; const resolved = require.resolve('../compiler.js'); @@ -55,7 +55,7 @@ export function cleanRequireCache() { const virtualConsole = new jsdom.VirtualConsole(); virtualConsole.sendTo(console); -const window = new jsdom.JSDOM('
', {virtualConsole}).window; +const window = new jsdom.JSDOM('
', { virtualConsole }).window; global.document = window.document; global.navigator = window.navigator; global.getComputedStyle = window.getComputedStyle; @@ -279,3 +279,50 @@ export function prettyPrintPuppeteerAssertionError(message) { assert.equal(match[1], match[2]); } } + +export async function retryAsync(fn: () => Promise, maxAttempts: number = 3, interval: number = 1000): Promise { + let attempts = 0; + while (attempts <= maxAttempts) { + try { + return await fn(); + } catch (err) { + if (++attempts >= maxAttempts) throw err; + await new Promise(resolve => setTimeout(resolve, interval)); + } + } +} + +// NOTE: Chromium may exit with SIGSEGV, so retry in that case +export async function executeBrowserTest(browser, launchPuppeteer: () => Promise, additionalAssertion: () => void, onError: (err: Error) => void) { + let count = 0; + do { + count++; + try { + const page = await browser.newPage(); + + page.on('console', (type) => { + console[type._type](type._text); + }); + + page.on('error', error => { + console.log('>>> an error happened'); + console.error(error); + }); + await page.goto('http://localhost:6789'); + const result = await page.evaluate(() => test(document.querySelector('main'))); + if (result) console.log(result); + additionalAssertion(); + await page.close(); + break; + } catch (err) { + if (count === 5 || browser.isConnected()) { + onError(err); + throw err; + } + console.debug(err.stack || err); + console.log('RESTARTING Chromium...'); + browser = await launchPuppeteer(); + } + } while (count <= 5); + return browser; +} diff --git a/test/js/samples/src-attribute-check-in-foreign/expected.js b/test/js/samples/src-attribute-check-in-foreign/expected.js index 3d781b72d4..2eb4c0713c 100644 --- a/test/js/samples/src-attribute-check-in-foreign/expected.js +++ b/test/js/samples/src-attribute-check-in-foreign/expected.js @@ -18,8 +18,8 @@ function create_fragment(ctx) { return { c() { - svg = document.createElementNS("https://svelte.dev/docs#svelte_options", "svg"); - img = document.createElementNS("https://svelte.dev/docs#svelte_options", "img"); + svg = document.createElementNS("https://svelte.dev/docs#template-syntax-svelte-options", "svg"); + img = document.createElementNS("https://svelte.dev/docs#template-syntax-svelte-options", "img"); this.h(); }, l(nodes) { diff --git a/test/runtime-puppeteer/index.ts b/test/runtime-puppeteer/index.ts index b700d47945..8e6f813de4 100644 --- a/test/runtime-puppeteer/index.ts +++ b/test/runtime-puppeteer/index.ts @@ -9,7 +9,9 @@ import { loadConfig, loadSvelte, mkdirp, - prettyPrintPuppeteerAssertionError + prettyPrintPuppeteerAssertionError, + retryAsync, + executeBrowserTest } from '../helpers'; import { deepEqual } from 'assert'; @@ -48,15 +50,21 @@ function create_server() { }); } +async function launchPuppeteer() { + return await retryAsync(() => puppeteer.launch()); +} + const assert = fs.readFileSync(`${__dirname}/assert.js`, 'utf-8'); -describe('runtime (puppeteer)', () => { +describe('runtime (puppeteer)', function() { + // Note: Increase the timeout in preparation for restarting Chromium due to SIGSEGV. + this.timeout(10000); before(async () => { svelte = loadSvelte(false); console.log('[runtime-puppeteer] Loaded Svelte'); server = await create_server(); console.log('[runtime-puppeteer] Started server'); - browser = await puppeteer.launch(); + browser = await launchPuppeteer(); console.log('[runtime-puppeteer] Launched puppeteer browser'); }); @@ -205,27 +213,7 @@ describe('runtime (puppeteer)', () => { const result = await bundle.generate({ format: 'iife', name: 'test' }); code = result.output[0].code; - const page = await browser.newPage(); - - page.on('console', (type) => { - console[type._type](type._text); - }); - - page.on('error', error => { - console.log('>>> an error happened'); - console.error(error); - }); - - try { - await page.goto('http://localhost:6789'); - - const result = await page.evaluate(() => test(document.querySelector('main'))); - if (result) console.log(result); - } catch (err) { - failed.add(dir); - prettyPrintPuppeteerAssertionError(err.message); - throw err; - } finally { + function assertWarnings() { if (config.warnings) { deepEqual(warnings.map(w => ({ code: w.code, @@ -240,6 +228,16 @@ describe('runtime (puppeteer)', () => { throw new Error('Received unexpected warnings'); } } + + browser = await executeBrowserTest( + browser, + launchPuppeteer, + assertWarnings, + (err) => { + failed.add(dir); + prettyPrintPuppeteerAssertionError(err.message); + assertWarnings(); + }); }); } diff --git a/test/runtime/index.ts b/test/runtime/index.ts index e777196ae2..4fc3880208 100644 --- a/test/runtime/index.ts +++ b/test/runtime/index.ts @@ -65,7 +65,7 @@ describe('runtime', () => { } const testName = `${dir} ${hydrate ? `(with hydration${from_ssr_html ? ' from ssr rendered html' : ''})` : ''}`; - (config.skip ? it.skip : solo ? it.only : it)(testName, () => { + (config.skip ? it.skip : solo ? it.only : it)(testName, (done) => { if (failed.has(dir)) { // this makes debugging easier, by only printing compiled output once throw new Error('skipping test, already failed'); @@ -96,7 +96,7 @@ describe('runtime', () => { glob('**/*.svelte', { cwd }).forEach(file => { if (file[0] === '_') return; - const dir = `${cwd}/_output/${hydrate ? 'hydratable' : 'normal'}`; + const dir = `${cwd}/_output/${hydrate ? 'hydratable' : 'normal'}`; const out = `${dir}/${file.replace(/\.svelte$/, '.js')}`; if (fs.existsSync(out)) { @@ -120,7 +120,7 @@ describe('runtime', () => { } }); - return Promise.resolve() + Promise.resolve() .then(() => { // hack to support transition tests clear_loops(); @@ -245,6 +245,7 @@ describe('runtime', () => { .catch(err => { // print a clickable link to open the directory err.stack += `\n\ncmd-click: ${path.relative(process.cwd(), cwd)}/main.svelte`; + done(); throw err; }) .then(() => { @@ -255,6 +256,7 @@ describe('runtime', () => { flush(); if (config.after_test) config.after_test(); + done(); }); }); } diff --git a/test/server-side-rendering/index.ts b/test/server-side-rendering/index.ts index cc3f20d637..f4175c73a6 100644 --- a/test/server-side-rendering/index.ts +++ b/test/server-side-rendering/index.ts @@ -52,21 +52,23 @@ describe('ssr', () => { throw new Error('Forgot to remove `solo: true` from test'); } - (solo ? it.only : it)(dir, () => { - dir = path.resolve(`${__dirname}/samples`, dir); + (solo ? it.only : it)(dir, (done) => { - cleanRequireCache(); + try { - const compileOptions = { - sveltePath, - ...config.compileOptions, - generate: 'ssr', - format: 'cjs' - }; + dir = path.resolve(`${__dirname}/samples`, dir); - require('../../register')(compileOptions); + cleanRequireCache(); + + const compileOptions = { + sveltePath, + ...config.compileOptions, + generate: 'ssr', + format: 'cjs' + }; + + require('../../register')(compileOptions); - try { const Component = require(`${dir}/main.svelte`).default; const expectedHtml = tryToReadFile(`${dir}/_expected.html`); @@ -132,6 +134,7 @@ describe('ssr', () => { throw err; } finally { set_current_component(null); + done(); } }); }); diff --git a/test/validator/samples/a11y-no-redundant-roles/input.svelte b/test/validator/samples/a11y-no-redundant-roles/input.svelte new file mode 100644 index 0000000000..05525effb6 --- /dev/null +++ b/test/validator/samples/a11y-no-redundant-roles/input.svelte @@ -0,0 +1,44 @@ +a link +
+
+ +