From e3d277b000dcca2bcb391b1cb92899484d7173e7 Mon Sep 17 00:00:00 2001 From: Paolo Ricciuti Date: Fri, 27 Feb 2026 21:01:13 +0100 Subject: [PATCH] fix: visit synthetic value node during ssr (#17824) Closes #17821 ### Before submitting the PR, please make sure you do the following - [x] It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs - [x] Prefix your PR title with `feat:`, `fix:`, `chore:`, or `docs:`. - [x] This message body should clearly illustrate what problems it solves. - [x] Ideally, include a test that fails without this PR but passes with it. - [x] If this PR changes code within `packages/svelte/src`, add a changeset (`npx changeset`). ### Tests and linting - [x] Run the tests with `pnpm test` and lint the project with `pnpm lint` --- .changeset/itchy-carpets-watch.md | 5 +++++ .../3-transform/server/visitors/RegularElement.js | 2 +- .../_expected.html | 1 + .../select-option-store-implicit-value/main.svelte | 11 +++++++++++ .../select-option-store-text-content/_expected.html | 1 + .../select-option-store-text-content/main.svelte | 13 +++++++++++++ 6 files changed, 32 insertions(+), 1 deletion(-) create mode 100644 .changeset/itchy-carpets-watch.md create mode 100644 packages/svelte/tests/server-side-rendering/samples/select-option-store-implicit-value/_expected.html create mode 100644 packages/svelte/tests/server-side-rendering/samples/select-option-store-implicit-value/main.svelte create mode 100644 packages/svelte/tests/server-side-rendering/samples/select-option-store-text-content/_expected.html create mode 100644 packages/svelte/tests/server-side-rendering/samples/select-option-store-text-content/main.svelte diff --git a/.changeset/itchy-carpets-watch.md b/.changeset/itchy-carpets-watch.md new file mode 100644 index 0000000000..2bafdae5ea --- /dev/null +++ b/.changeset/itchy-carpets-watch.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +fix: visit synthetic value node during ssr diff --git a/packages/svelte/src/compiler/phases/3-transform/server/visitors/RegularElement.js b/packages/svelte/src/compiler/phases/3-transform/server/visitors/RegularElement.js index e653f545af..42d9bcb667 100644 --- a/packages/svelte/src/compiler/phases/3-transform/server/visitors/RegularElement.js +++ b/packages/svelte/src/compiler/phases/3-transform/server/visitors/RegularElement.js @@ -126,7 +126,7 @@ export function RegularElement(node, context) { if (node.metadata.synthetic_value_node) { body = optimiser.transform( - node.metadata.synthetic_value_node.expression, + /** @type {Expression} */ (context.visit(node.metadata.synthetic_value_node.expression)), node.metadata.synthetic_value_node.metadata.expression ); } else { diff --git a/packages/svelte/tests/server-side-rendering/samples/select-option-store-implicit-value/_expected.html b/packages/svelte/tests/server-side-rendering/samples/select-option-store-implicit-value/_expected.html new file mode 100644 index 0000000000..0a0a4351f1 --- /dev/null +++ b/packages/svelte/tests/server-side-rendering/samples/select-option-store-implicit-value/_expected.html @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/packages/svelte/tests/server-side-rendering/samples/select-option-store-implicit-value/main.svelte b/packages/svelte/tests/server-side-rendering/samples/select-option-store-implicit-value/main.svelte new file mode 100644 index 0000000000..5d133d5bf3 --- /dev/null +++ b/packages/svelte/tests/server-side-rendering/samples/select-option-store-implicit-value/main.svelte @@ -0,0 +1,11 @@ + + + diff --git a/packages/svelte/tests/server-side-rendering/samples/select-option-store-text-content/_expected.html b/packages/svelte/tests/server-side-rendering/samples/select-option-store-text-content/_expected.html new file mode 100644 index 0000000000..daf2176928 --- /dev/null +++ b/packages/svelte/tests/server-side-rendering/samples/select-option-store-text-content/_expected.html @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/packages/svelte/tests/server-side-rendering/samples/select-option-store-text-content/main.svelte b/packages/svelte/tests/server-side-rendering/samples/select-option-store-text-content/main.svelte new file mode 100644 index 0000000000..27055caad6 --- /dev/null +++ b/packages/svelte/tests/server-side-rendering/samples/select-option-store-text-content/main.svelte @@ -0,0 +1,13 @@ + + +