From e34e5ee9da6a0d1d6408e55d818786166f609ace Mon Sep 17 00:00:00 2001 From: Saurav Sahu Date: Fri, 29 Jan 2021 22:28:43 +0530 Subject: [PATCH] fix: filter out 'this' binding for foreign namespace --- src/compiler/compile/nodes/Element.ts | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/src/compiler/compile/nodes/Element.ts b/src/compiler/compile/nodes/Element.ts index 8c5b4cb9f5..5a1e2ecfae 100644 --- a/src/compiler/compile/nodes/Element.ts +++ b/src/compiler/compile/nodes/Element.ts @@ -599,12 +599,14 @@ export default class Element extends Node { } validate_bindings_foreign() { - this.bindings.forEach(binding => { - this.component.error(binding, { - code: 'invalid-binding', - message: `'${binding.name}' is not a valid binding. Foreign elements only support bind:this` + this.bindings + .filter(binding => binding.name !== 'this') + .forEach(binding => { + this.component.error(binding, { + code: 'invalid-binding', + message: `'${binding.name}' is not a valid binding. Foreign elements only support bind:this` + }); }); - }); } validate_bindings() {