From e0b3dc020cb0ee693635d3ad9711a39689c32da6 Mon Sep 17 00:00:00 2001 From: Dominic Gannaway Date: Mon, 3 Feb 2025 17:20:29 +0000 Subject: [PATCH] chore: remove unused code from signal logic (#15195) --- .changeset/blue-sheep-joke.md | 5 +++++ .../src/internal/client/reactivity/deriveds.js | 12 ------------ .../src/internal/client/reactivity/effects.js | 2 +- packages/svelte/src/internal/client/runtime.js | 16 +--------------- 4 files changed, 7 insertions(+), 28 deletions(-) create mode 100644 .changeset/blue-sheep-joke.md diff --git a/.changeset/blue-sheep-joke.md b/.changeset/blue-sheep-joke.md new file mode 100644 index 0000000000..1d9ff973c5 --- /dev/null +++ b/.changeset/blue-sheep-joke.md @@ -0,0 +1,5 @@ +--- +'svelte': patch +--- + +chore: remove unused code from signal logic diff --git a/packages/svelte/src/internal/client/reactivity/deriveds.js b/packages/svelte/src/internal/client/reactivity/deriveds.js index 1f65ff38c3..60b55970e6 100644 --- a/packages/svelte/src/internal/client/reactivity/deriveds.js +++ b/packages/svelte/src/internal/client/reactivity/deriveds.js @@ -176,15 +176,3 @@ export function update_derived(derived) { derived.wv = increment_write_version(); } } - -/** - * @param {Derived} derived - * @returns {void} - */ -export function destroy_derived(derived) { - destroy_derived_effects(derived); - remove_reactions(derived, 0); - set_signal_status(derived, DESTROYED); - - derived.v = derived.deps = derived.ctx = derived.reactions = null; -} diff --git a/packages/svelte/src/internal/client/reactivity/effects.js b/packages/svelte/src/internal/client/reactivity/effects.js index d014ff793d..eab6c767f8 100644 --- a/packages/svelte/src/internal/client/reactivity/effects.js +++ b/packages/svelte/src/internal/client/reactivity/effects.js @@ -42,7 +42,7 @@ import * as e from '../errors.js'; import { DEV } from 'esm-env'; import { define_property } from '../../shared/utils.js'; import { get_next_sibling } from '../dom/operations.js'; -import { derived, destroy_derived } from './deriveds.js'; +import { derived } from './deriveds.js'; import { component_context, dev_current_component_function } from '../context.js'; /** diff --git a/packages/svelte/src/internal/client/runtime.js b/packages/svelte/src/internal/client/runtime.js index a572e27bf4..57cefccc01 100644 --- a/packages/svelte/src/internal/client/runtime.js +++ b/packages/svelte/src/internal/client/runtime.js @@ -27,12 +27,7 @@ import { } from './constants.js'; import { flush_tasks } from './dom/task.js'; import { internal_set } from './reactivity/sources.js'; -import { - destroy_derived, - destroy_derived_effects, - execute_derived, - update_derived -} from './reactivity/deriveds.js'; +import { destroy_derived_effects, update_derived } from './reactivity/deriveds.js'; import * as e from './errors.js'; import { FILENAME } from '../../constants.js'; import { tracing_mode_flag } from '../flags/index.js'; @@ -919,15 +914,6 @@ export function get(signal) { var flags = signal.f; var is_derived = (flags & DERIVED) !== 0; - // If the derived is destroyed, just execute it again without retaining - // its memoisation properties as the derived is stale - if (is_derived && (flags & DESTROYED) !== 0) { - var value = execute_derived(/** @type {Derived} */ (signal)); - // Ensure the derived remains destroyed - destroy_derived(/** @type {Derived} */ (signal)); - return value; - } - if (captured_signals !== null) { captured_signals.add(signal); }