From de90fc8dceae076f7fc0e5adf7fa72e0b6360479 Mon Sep 17 00:00:00 2001 From: Ray Thurn Void <53383860+raythurnvoid@users.noreply.github.com> Date: Tue, 17 Jun 2025 22:42:39 +0100 Subject: [PATCH] Test array sort in effect to prevent regressions of this use-case (#16175) --- .../samples/array-sort-in-effect/_config.js | 52 +++++++++++++++++++ .../samples/array-sort-in-effect/main.svelte | 21 ++++++++ 2 files changed, 73 insertions(+) create mode 100644 packages/svelte/tests/runtime-runes/samples/array-sort-in-effect/_config.js create mode 100644 packages/svelte/tests/runtime-runes/samples/array-sort-in-effect/main.svelte diff --git a/packages/svelte/tests/runtime-runes/samples/array-sort-in-effect/_config.js b/packages/svelte/tests/runtime-runes/samples/array-sort-in-effect/_config.js new file mode 100644 index 0000000000..cbac36fee8 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/array-sort-in-effect/_config.js @@ -0,0 +1,52 @@ +import { flushSync } from 'svelte'; +import { test } from '../../test'; + +export default test({ + /** + * Ensure that sorting an array inside an $effect works correctly + * and re-runs when the array changes (e.g., when items are added). + */ + test({ assert, target }) { + const button = target.querySelector('button'); + + // initial render — array should be sorted + assert.htmlEqual( + target.innerHTML, + ` + +

0

+

50

+

100

+ ` + ); + + // add first item (20); effect should re-run and sort the array + flushSync(() => button?.click()); + + assert.htmlEqual( + target.innerHTML, + ` + +

0

+

20

+

50

+

100

+ ` + ); + + // add second item (80); effect should re-run and sort the array + flushSync(() => button?.click()); + + assert.htmlEqual( + target.innerHTML, + ` + +

0

+

20

+

50

+

80

+

100

+ ` + ); + } +}); diff --git a/packages/svelte/tests/runtime-runes/samples/array-sort-in-effect/main.svelte b/packages/svelte/tests/runtime-runes/samples/array-sort-in-effect/main.svelte new file mode 100644 index 0000000000..c529f67cf4 --- /dev/null +++ b/packages/svelte/tests/runtime-runes/samples/array-sort-in-effect/main.svelte @@ -0,0 +1,21 @@ + + + +{#each arr as x} +

{x}

+{/each}