Updated to ESLint config 5.4.0 (#5541)

package.json

@@ -63,7 +63,7 @@
     "@rollup/plugin-sucrase": "^3.0.0",
     "@rollup/plugin-typescript": "^2.0.1",
     "@rollup/plugin-virtual": "^2.0.0",
-    "@sveltejs/eslint-config": "github:sveltejs/eslint-config#v5.2.0",
+    "@sveltejs/eslint-config": "github:sveltejs/eslint-config#v5.4.0",
     "@types/mocha": "^7.0.0",
     "@types/node": "^8.10.53",
     "@typescript-eslint/eslint-plugin": "^3.0.2",

src/compiler/compile/css/gather_possible_values.ts

@@ -15,4 +15,4 @@ export function gather_possible_values(node: Node, set: Set<string|{}>) {
 	else {
 		set.add(UNKNOWN);
 	}
-}
+}

src/compiler/compile/css/interfaces.ts

@@ -3,4 +3,4 @@ export interface CssNode {
 	start: number;
 	end: number;
 	[prop_name: string]: any;
-}
+}

src/compiler/compile/nodes/Action.ts

@@ -23,4 +23,4 @@ export default class Action extends Node {
 
 		this.uses_context = this.expression && this.expression.uses_context;
 	}
-}
+}

src/compiler/compile/nodes/Animation.ts

@@ -37,4 +37,4 @@ export default class Animation extends Node {
 			? new Expression(component, this, scope, info.expression, true)
 			: null;
 	}
-}
+}

src/compiler/compile/nodes/Class.ts

@@ -15,4 +15,4 @@ export default class Class extends Node {
 			? new Expression(component, this, scope, info.expression)
 			: null;
 	}
-}
+}

src/compiler/compile/nodes/Comment.ts

@@ -14,4 +14,4 @@ export default class Comment extends Node {
 		const match = pattern.exec(this.data);
 		this.ignores = match ? match[1].split(/[^\S]/).map(x => x.trim()).filter(Boolean) : [];
 	}
-}
+}

src/compiler/compile/nodes/Transition.ts

@@ -43,4 +43,4 @@ function describe(transition: Transition) {
 	return transition.directive === 'transition'
 		? "a 'transition'"
 		: `an '${transition.directive}'`;
-}
+}

src/compiler/compile/render_dom/Block.ts

@@ -486,4 +486,4 @@ export default class Block {
 			}
 		}
 	}
-}
+}

src/compiler/compile/render_dom/invalidate.ts

@@ -78,4 +78,4 @@ export function invalidate(renderer: Renderer, scope: Scope, node: Node, names:
 	}
 
 	return invalidate;
-}
+}

src/compiler/compile/render_dom/wrappers/Element/Attribute.ts

@@ -387,4 +387,4 @@ function is_indirectly_bound_value(attribute: AttributeWrapper) {
 					(binding) =>
 						/checked|group/.test(binding.name)
 				)));
-}
+}

src/compiler/compile/render_dom/wrappers/Text.ts

@@ -51,4 +51,4 @@ export default class TextWrapper extends Wrapper {
 			parent_node as Identifier
 		);
 	}
-}
+}

src/compiler/compile/render_dom/wrappers/shared/Tag.ts

@@ -56,4 +56,4 @@ export default class Tag extends Wrapper {
 
 		return { init: content };
 	}
-}
+}

src/compiler/compile/render_dom/wrappers/shared/bind_this.ts

@@ -94,4 +94,4 @@ export default function bind_this(component: Component, block: Block, binding: B
 
 	block.chunks.destroy.push(b`${callee}(null);`);
 	return b`${callee}(${variable});`;
-}
+}

src/compiler/compile/render_dom/wrappers/shared/get_slot_definition.ts

@@ -112,4 +112,4 @@ export function get_slot_definition(block: Block, scope: TemplateScope, lets: Le
 		get_context: x`${context_input} => ${context}`,
 		get_changes: x`${changes_input} => ${changes}`
 	};
-}
+}

src/compiler/compile/render_dom/wrappers/shared/is_dynamic.ts

@@ -9,4 +9,4 @@ export default function is_dynamic(variable: Var) {
 	}
 
 	return false;
-}
+}

src/compiler/compile/render_dom/wrappers/shared/is_head.ts

@@ -1,3 +1,3 @@
 export function is_head(node) {
 	return node && node.type === 'MemberExpression' && node.object.name === '@_document' && node.property.name === 'head';
-}
+}

src/compiler/compile/render_ssr/handlers/InlineComponent.ts

@@ -106,4 +106,4 @@ function is_empty_template_literal(template_literal) {
 		template_literal.quasis.length === 1 &&
 		template_literal.quasis[0].value.raw === ''
 	);
-}
+}

src/compiler/compile/render_ssr/handlers/shared/get_slot_scope.ts

@@ -18,4 +18,4 @@ export function get_slot_scope(lets: Let[]): ObjectPattern {
 			};
 		})
 	};
-}
+}

src/compiler/compile/utils/flatten_reference.ts

@@ -36,4 +36,4 @@ function to_string(node: Node) {
 		case 'Identifier':
 			return node.name;
 	}
-}
+}

src/compiler/compile/utils/get_name_from_filename.ts

@@ -24,4 +24,4 @@ export default function get_name_from_filename(filename: string) {
 	}
 
 	return base[0].toUpperCase() + base.slice(1);
-}
+}

src/compiler/compile/utils/get_slot_data.ts

@@ -28,4 +28,4 @@ function get_value(block: Block, attribute: Attribute) {
 	}
 
 	return value;
-}
+}

src/compiler/compile/utils/hash.ts

@@ -6,4 +6,4 @@ export default function hash(str: string): string {
 
 	while (i--) hash = ((hash << 5) - hash) ^ str.charCodeAt(i);
 	return (hash >>> 0).toString(36);
-}
+}

src/compiler/compile/utils/replace_object.ts

@@ -11,4 +11,4 @@ export default function replace_object(node: Node, replacement: Node) {
 	}
 	parent.object = replacement;
 	return ancestor;
-}
+}

src/compiler/compile/utils/reserved_keywords.ts

@@ -2,4 +2,4 @@ export const reserved_keywords = new Set(['$$props', '$$restProps', '$$slots']);
 
 export function is_reserved_keyword(name) {
 	return reserved_keywords.has(name);
-}
+}

src/compiler/config.ts

@@ -1 +1 @@
-export const test = typeof process !== 'undefined' && process.env.TEST;
+export const test = typeof process !== 'undefined' && process.env.TEST;

src/compiler/parse/acorn.ts

@@ -11,4 +11,4 @@ export const parse_expression_at = (source: string, index: number): Node => code
 	sourceType: 'module',
 	ecmaVersion: 12,
 	locations: true
-});
+});

src/compiler/parse/utils/bracket.ts

@@ -25,4 +25,4 @@ export function get_bracket_close(open) {
 	if (open === CURLY_BRACKET_OPEN) {
 		return CURLY_BRACKET_CLOSE;
 	}
-}
+}

src/compiler/utils/error.ts

@@ -37,4 +37,4 @@ export default function error(message: string, props: {
 	error.frame = get_code_frame(props.source, start.line - 1, start.column);
 
 	throw error;
-}
+}

src/compiler/utils/full_char_code_at.ts

@@ -7,4 +7,4 @@ export default function full_char_code_at(str: string, i: number): number {
 
 	const next = str.charCodeAt(i + 1);
 	return (code << 10) + next - 0x35fdc00;
-}
+}

src/compiler/utils/nodes_match.ts

@@ -29,4 +29,4 @@ export function nodes_match(a, b) {
 	}
 
 	return a === b;
-}
+}

src/runtime/internal/spread.ts

@@ -38,4 +38,4 @@ export function get_spread_update(levels, updates) {
 
 export function get_spread_object(spread_props) {
 	return typeof spread_props === 'object' && spread_props !== null ? spread_props : {};
-}
+}

src/runtime/internal/ssr.ts

@@ -134,4 +134,4 @@ export function add_attribute(name, value, boolean) {
 
 export function add_classes(classes) {
 	return classes ? ` class="${classes}"` : '';
-}
+}

src/runtime/store/index.ts

@@ -201,4 +201,4 @@ export function derived<T>(stores: Stores, fn: Function, initial_value?: T): Rea
  * Get the current value from a store by subscribing and immediately unsubscribing.
  * @param store readable
  */
-export { get_store_value as get };
+export { get_store_value as get };

test/css/index.ts

@@ -156,4 +156,4 @@ function read(file) {
 	} catch (err) {
 		return null;
 	}
-}
+}

test/css/samples/empty-class/_config.js

@@ -22,4 +22,4 @@ export default {
 			5:     color: red;
 			6:   }`
 	}]
-};
+};

test/css/samples/empty-rule-dev/_config.js

@@ -2,4 +2,4 @@ export default {
 	compileOptions: {
 		dev: true
 	}
-};
+};

test/css/samples/nested/_config.js

@@ -2,4 +2,4 @@ export default {
 	props: {
 		dynamic: 'x'
 	}
-};
+};

test/css/samples/omit-scoping-attribute-attribute-selector-equals-dynamic/_config.js

@@ -2,4 +2,4 @@ export default {
 	props: {
 		dynamic: 'whatever'
 	}
-};
+};

test/css/samples/omit-scoping-attribute-descendant-global-inner-class/_config.js

@@ -2,4 +2,4 @@ export default {
 	props: {
 		raw: '<p>raw</p>'
 	}
-};
+};

test/css/samples/omit-scoping-attribute-descendant-global-inner-multiple/_config.js

@@ -2,4 +2,4 @@ export default {
 	props: {
 		raw: '<p>raw</p>'
 	}
-};
+};

test/css/samples/omit-scoping-attribute-descendant-global-inner/_config.js

@@ -2,4 +2,4 @@ export default {
 	props: {
 		raw: '<p>raw</p>'
 	}
-};
+};

test/css/samples/omit-scoping-attribute-descendant-global-outer-multiple/_config.js

@@ -2,4 +2,4 @@ export default {
 	props: {
 		raw: '<p>raw</p>'
 	}
-};
+};

test/css/samples/omit-scoping-attribute-descendant-global-outer/_config.js

@@ -2,4 +2,4 @@ export default {
 	props: {
 		raw: '<p>raw</p>'
 	}
-};
+};

test/css/samples/omit-scoping-attribute-descendant/_config.js

@@ -21,4 +21,4 @@ export default {
 			 9:     color: red;
 			10:   }`
 	}]
-};
+};

test/css/samples/omit-scoping-attribute-global/_config.js

@@ -2,4 +2,4 @@ export default {
 	props: {
 		raw: '<p>raw</p>'
 	}
-};
+};

test/css/samples/unused-selector-leading/_config.js

@@ -48,4 +48,4 @@ export default {
 				6:   }`
 		}
 	]
-};
+};

test/css/samples/unused-selector-ternary/_config.js

@@ -26,4 +26,4 @@ export default {
 			17:     color: green;
 			18:   }`
 	}]
-};
+};

test/css/samples/unused-selector/_config.js

@@ -22,4 +22,4 @@ export default {
 			 9:     color: blue;
 			10:   }`
 	}]
-};
+};

test/custom-elements/assert.js

@@ -30,4 +30,4 @@ export function equal(a, b, message) {
 
 export function ok(condition, message) {
 	if (!condition) throw new Error(message || `Expected ${condition} to be truthy`);
-}
+}

test/custom-elements/samples/custom-method/test.js

@@ -9,4 +9,4 @@ export default async function (target) {
 
 	const p = el.shadowRoot.querySelector('p');
 	assert.equal(p.textContent, '42');
-}
+}

test/custom-elements/samples/escaped-css/test.js

@@ -10,4 +10,4 @@ export default function (target) {
 	const before = getComputedStyle(icon, '::before');
 
 	assert.equal(before.content, JSON.stringify(String.fromCharCode(0xff)));
-}
+}

test/custom-elements/samples/extended-builtin/custom-button.js

@@ -1,2 +1,2 @@
 class CustomButton extends HTMLButtonElement {}
-customElements.define('custom-button', CustomButton, { extends: 'button' });
+customElements.define('custom-button', CustomButton, { extends: 'button' });

test/custom-elements/samples/extended-builtin/test.js

@@ -12,4 +12,4 @@ export default function (target) {
 	const button = el.shadowRoot.querySelector('button');
 
 	assert.ok(button instanceof customElements.get('custom-button'));
-}
+}

test/custom-elements/samples/html-slots/test.js

@@ -14,4 +14,4 @@ export default function (target) {
 
 	assert.equal(slot0.assignedNodes()[1], target.querySelector('strong'));
 	assert.equal(slot1.assignedNodes().length, 0);
-}
+}

test/custom-elements/samples/html/test.js

@@ -9,4 +9,4 @@ export default function (target) {
 
 	const h1 = el.shadowRoot.querySelector('h1');
 	assert.equal(h1.textContent, 'Hello world!');
-}
+}

test/custom-elements/samples/nested.skip/test.js

@@ -14,4 +14,4 @@ export default async function (target) {
 
 	assert.equal(counter.count, 1);
 	assert.equal(counter.shadowRoot.innerHTML, '<button>count: 1</button>');
-}
+}

test/custom-elements/samples/new-styled/test.js

@@ -16,4 +16,4 @@ export default function (target) {
 
 	assert.equal(getComputedStyle(unstyled).color, 'rgb(0, 0, 0)');
 	assert.equal(getComputedStyle(styled).color, 'rgb(255, 0, 0)');
-}
+}

test/custom-elements/samples/new/test.js

@@ -15,4 +15,4 @@ export default function (target) {
 	const h1 = el.shadowRoot.querySelector('h1');
 
 	assert.equal(h1.textContent, 'Hello world!');
-}
+}

test/custom-elements/samples/no-missing-prop-warnings/_config.js

@@ -1,3 +1,3 @@
 export default {
 	dev: true
-};
+};

test/custom-elements/samples/no-missing-prop-warnings/test.js

@@ -16,4 +16,4 @@ export default function (target) {
 	]);
 
 	console.warn = warn;
-}
+}

test/custom-elements/samples/oncreate/test.js

@@ -5,4 +5,4 @@ export default function (target) {
 	target.innerHTML = '<my-app/>';
 	const el = target.querySelector('my-app');
 	assert.ok(el.wasCreated);
-}
+}

test/custom-elements/samples/props/test.js

@@ -20,4 +20,4 @@ export default function (target) {
 
 	assert.equal(p1.textContent, '5 items');
 	assert.equal(p2.textContent, 'd, e, f, g, h');
-}
+}

test/helpers.ts

@@ -259,4 +259,4 @@ export function mkdirp(dir) {
 	} catch (err) {
 		// do nothing
 	}
-}
+}

test/hydration/samples/basic/_config.js

@@ -14,4 +14,4 @@ export default {
 		assert.equal(h1, snapshot.h1);
 		assert.equal(h1.childNodes[0], snapshot.text);
 	}
-};
+};

test/hydration/samples/binding-input/_config.js

@@ -26,4 +26,4 @@ export default {
 			<p>Hello everybody!</p>
 		`);
 	}
-};
+};

test/hydration/samples/component-in-element/_config.js

@@ -18,4 +18,4 @@ export default {
 		assert.equal(p, snapshot.p);
 		assert.equal(p.childNodes[0], snapshot.text);
 	}
-};
+};

test/hydration/samples/component/_config.js

@@ -14,4 +14,4 @@ export default {
 		assert.equal(p, snapshot.p);
 		assert.equal(p.childNodes[0], snapshot.text);
 	}
-};
+};

test/hydration/samples/dynamic-text-changed/_config.js

@@ -18,4 +18,4 @@ export default {
 		assert.equal(h1, snapshot.h1);
 		assert.equal(h1.childNodes[0], snapshot.text);
 	}
-};
+};

test/hydration/samples/dynamic-text/_config.js

@@ -18,4 +18,4 @@ export default {
 		assert.equal(h1, snapshot.h1);
 		assert.equal(h1.childNodes[0], snapshot.text);
 	}
-};
+};

test/hydration/samples/each-block/_config.js

@@ -26,4 +26,4 @@ export default {
 		assert.equal(lis[1], snapshot.lis[1]);
 		assert.equal(lis[2], snapshot.lis[2]);
 	}
-};
+};

test/hydration/samples/element-attribute-added/_config.js

@@ -16,4 +16,4 @@ export default {
 
 		assert.equal(div, snapshot.div);
 	}
-};
+};

test/hydration/samples/element-attribute-changed/_config.js

@@ -16,4 +16,4 @@ export default {
 
 		assert.equal(div, snapshot.div);
 	}
-};
+};

test/hydration/samples/element-attribute-removed/_config.js

@@ -16,4 +16,4 @@ export default {
 
 		assert.equal(div, snapshot.div);
 	}
-};
+};

test/hydration/samples/element-attribute-unchanged/_config.js

@@ -12,4 +12,4 @@ export default {
 
 		assert.equal(div, snapshot.div);
 	}
-};
+};

test/hydration/samples/element-nested/_config.js

@@ -14,4 +14,4 @@ export default {
 		assert.equal(div, snapshot.div);
 		assert.equal(div.querySelector('p'), snapshot.p);
 	}
-};
+};

test/hydration/samples/element-ref/_config.js

@@ -13,4 +13,4 @@ export default {
 		assert.equal(h1, snapshot.h1);
 		assert.equal(component.h1, h1);
 	}
-};
+};

test/hydration/samples/event-handler/_config.js

@@ -23,4 +23,4 @@ export default {
 			<p>clicked!</p>
 		`);
 	}
-};
+};

test/hydration/samples/if-block-anchor/_config.js

@@ -23,4 +23,4 @@ export default {
 		assert.equal(ps[0], snapshot.p0);
 		assert.equal(ps[1], snapshot.p1);
 	}
-};
+};

test/hydration/samples/if-block-false/_config.js

@@ -16,4 +16,4 @@ export default {
 
 		assert.equal(p, snapshot.p);
 	}
-};
+};

test/hydration/samples/if-block-update/_config.js

@@ -21,4 +21,4 @@ export default {
 		component.bar = true;
 		assert.htmlEqual(target.innerHTML, '<p>bar!</p>');
 	}
-};
+};

test/hydration/samples/if-block/_config.js

@@ -16,4 +16,4 @@ export default {
 
 		assert.equal(p, snapshot.p);
 	}
-};
+};

test/hydration/samples/raw/_config.js

@@ -24,4 +24,4 @@ export default {
 		assert.equal(ps[1], snapshot.p1);
 		assert.equal(ps[1].firstChild, snapshot.text1);
 	}
-};
+};

test/hydration/samples/top-level-text/_config.js

@@ -10,4 +10,4 @@ export default {
 
 		assert.equal(text, snapshot.text);
 	}
-};
+};

test/js/samples/capture-inject-dev-only/_config.js

@@ -2,4 +2,4 @@ export default {
 	options: {
 		dev: false
 	}
-};
+};

test/js/samples/component-static-immutable/_config.js

@@ -2,4 +2,4 @@ export default {
 	options: {
 		immutable: true
 	}
-};
+};

test/js/samples/component-static-immutable2/_config.js

@@ -2,4 +2,4 @@ export default {
 	options: {
 		immutable: true
 	}
-};
+};

test/js/samples/component-store-file-invalidate/store.js

@@ -1,3 +1,3 @@
 import { writable } from '../../../../store';
 
-export const count = writable(0);
+export const count = writable(0);

test/js/samples/css-shadow-dom-keyframes/_config.js

@@ -2,4 +2,4 @@ export default {
 	options: {
 		customElement: true
 	}
-};
+};

test/js/samples/debug-empty/_config.js

@@ -2,4 +2,4 @@ export default {
 	options: {
 		dev: true
 	}
-};
+};

test/js/samples/debug-foo-bar-baz-things/_config.js

@@ -2,4 +2,4 @@ export default {
 	options: {
 		dev: true
 	}
-};
+};

test/js/samples/debug-foo/_config.js

@@ -2,4 +2,4 @@ export default {
 	options: {
 		dev: true
 	}
-};
+};

test/js/samples/debug-no-dependencies/_config.js

@@ -2,4 +2,4 @@ export default {
 	options: {
 		dev: true
 	}
-};
+};

test/js/samples/debug-ssr-foo/_config.js

@@ -3,4 +3,4 @@ export default {
 		generate: 'ssr',
 		dev: true
 	}
-};
+};

test/js/samples/dev-warning-missing-data-computed/_config.js

@@ -2,4 +2,4 @@ export default {
 	options: {
 		dev: true
 	}
-};
+};

test/js/samples/hydrated-void-element/_config.js

@@ -2,4 +2,4 @@ export default {
 	options: {
 		hydratable: true
 	}
-};
+};

test/js/samples/legacy-input-type/_config.js

@@ -2,4 +2,4 @@ export default {
 	options: {
 		legacy: true
 	}
-};
+};

test/js/samples/src-attribute-check/_config.js

@@ -2,4 +2,4 @@ export default {
 	options: {
 		hydratable: true
 	}
-};
+};

test/js/samples/ssr-no-oncreate-etc/_config.js

@@ -2,4 +2,4 @@ export default {
 	options: {
 		generate: 'ssr'
 	}
-};
+};

test/preprocess/samples/dependencies/_config.js

@@ -12,4 +12,4 @@ export default {
 	},
 
 	dependencies: ['./foo.css']
-};
+};