Merge remote-tracking branch 'origin/master' into fix/7476

CHANGELOG.md

@@ -5,6 +5,9 @@
 * Make `noreferrer` warning less zealous ([#6289](https://github.com/sveltejs/svelte/issues/6289))
 * `trusted-types` CSP compatibility for Web Components ([#8134](https://github.com/sveltejs/svelte/issues/8134))
 * Add `data-sveltekit-replacestate` and `data-sveltekit-keepfocus` attribute typings ([#8281](https://github.com/sveltejs/svelte/issues/8281))
+* Don't throw when calling `unsubscribe` twice ([#8186](https://github.com/sveltejs/svelte/pull/8186))
+* Detect unused empty attribute CSS selectors ([#8042](https://github.com/sveltejs/svelte/issues/8042))
+* Omit a11y warning on `<video>` tags with `aria-hidden="true"` ([#7874](https://github.com/sveltejs/svelte/issues/7874))
 
 ## 3.55.1
 

site/content/tutorial/18-debugging/meta.json

@@ -1,3 +0,0 @@
-{
-	"title": "Debugging"
-}

site/content/tutorial/18-special-tags/02-html-tags/text.md

@@ -12,4 +12,4 @@ In Svelte, you do this with the special `{@html ...}` tag:
 <p>{@html string}</p>
 ```
 
-> Svelte doesn't perform any sanitization of the expression inside `{@html ...}` before it gets inserted into the DOM. In other words, if you use this feature it's critical that you manually escape HTML that comes from sources you don't trust, otherwise you risk exposing your users to XSS attacks.
+> **Warning!** Svelte doesn't perform any sanitization of the expression inside `{@html ...}` before it gets inserted into the DOM. In other words, if you use this feature it's **critical** that you manually escape HTML that comes from sources you don't trust, otherwise you risk exposing your users to XSS attacks.

site/content/tutorial/18-special-tags/meta.json

@@ -0,0 +1,3 @@
+{
+	"title": "Special tags"
+}

src/compiler/compile/nodes/Element.ts

@@ -718,7 +718,10 @@ export default class Element extends Node {
 		}
 
 		if (this.name === 'video') {
-			if (attribute_map.has('muted')) {
+			const aria_hidden_attribute = attribute_map.get('aria-hidden');
+			const aria_hidden_exist = aria_hidden_attribute && aria_hidden_attribute.get_static_value();
+
+			if (attribute_map.has('muted') || aria_hidden_exist === 'true') {
 				return;
 			}
 

test/validator/samples/a11y-media-has-caption/input.svelte

@@ -2,3 +2,6 @@
 <video></video>
 <video><track /></video>
 <audio></audio>
+<video aria-hidden></video>
+<video aria-hidden="false"></video>
+<video aria-hidden="true"></video>

test/validator/samples/a11y-media-has-caption/warnings.json

@@ -28,5 +28,35 @@
       "column": 0,
       "line": 3
     }
+  },
+  {
+    "code": "a11y-media-has-caption",
+    "end": {
+      "character": 124,
+      "column": 27,
+      "line": 5
+    },
+    "message": "A11y: <video> elements must have a <track kind=\"captions\">",
+    "pos": 97,
+    "start": {
+      "character": 97,
+      "column": 0,
+      "line": 5
+    }
+  },
+  {
+    "code": "a11y-media-has-caption",
+    "end": {
+      "character": 160,
+      "column": 35,
+      "line": 6
+    },
+    "message": "A11y: <video> elements must have a <track kind=\"captions\">",
+    "pos": 125,
+    "start": {
+      "character": 125,
+      "column": 0,
+      "line": 6
+    }
   }
 ]