From dcf4acab3e9fc3217b87613009b71214a880f74c Mon Sep 17 00:00:00 2001 From: Richard Harris Date: Fri, 28 Dec 2018 20:07:39 -0500 Subject: [PATCH] fix REPL tab key behaviour --- package-lock.json | 2 +- .../src/routes/repl/_components/CodeMirror.html | 17 ++++++++++------- 2 files changed, 11 insertions(+), 8 deletions(-) diff --git a/package-lock.json b/package-lock.json index bb8027e73b..b435177e9d 100644 --- a/package-lock.json +++ b/package-lock.json @@ -1,6 +1,6 @@ { "name": "svelte", - "version": "3.0.0-alpha6", + "version": "3.0.0-alpha12", "lockfileVersion": 1, "requires": true, "dependencies": { diff --git a/site/src/routes/repl/_components/CodeMirror.html b/site/src/routes/repl/_components/CodeMirror.html index cf68e11221..b8b3b18109 100644 --- a/site/src/routes/repl/_components/CodeMirror.html +++ b/site/src/routes/repl/_components/CodeMirror.html @@ -120,7 +120,7 @@ editor.toTextArea(); } - editor = CodeMirror.fromTextArea(refs.editor, { + const opts = { lineNumbers, lineWrapping: true, indentWithTabs: true, @@ -130,12 +130,15 @@ mode: modes[mode] || { name: mode }, - readOnly: readonly, - extraKeys: { - Tab: tab, - 'Shift-Tab': tab - } - }); + readOnly: readonly + }; + + if (!tab) opts.extraKeys = { + Tab: tab, + 'Shift-Tab': tab + }; + + editor = CodeMirror.fromTextArea(refs.editor, opts); editor.on('change', instance => { if (!updating) {