mirror of https://github.com/sveltejs/svelte
Rich Harris
7 years ago
committed by
GitHub
commit
d920af8e2c
@ -0,0 +1,25 @@
|
||||
name: CI
|
||||
on: [push, pull_request]
|
||||
jobs:
|
||||
Tests:
|
||||
runs-on: ${{ matrix.os }}
|
||||
strategy:
|
||||
matrix:
|
||||
node-version: [8, 10, 12]
|
||||
os: [ubuntu-latest, windows-latest, macOS-latest]
|
||||
steps:
|
||||
- run: git config --global core.autocrlf false
|
||||
- uses: actions/checkout@v1
|
||||
- uses: actions/setup-node@v1
|
||||
with:
|
||||
node-version: ${{ matrix.node-version }}
|
||||
- run: npm install
|
||||
- run: npm test
|
||||
env:
|
||||
CI: true
|
||||
Lint:
|
||||
runs-on: ubuntu-latest
|
||||
steps:
|
||||
- uses: actions/checkout@v1
|
||||
- uses: actions/setup-node@v1
|
||||
- run: 'npm i && npm run lint'
|
||||
@ -1,20 +0,0 @@
|
||||
language: node_js
|
||||
node_js:
|
||||
- "8"
|
||||
- "10"
|
||||
- "12"
|
||||
env:
|
||||
global:
|
||||
- BUILD_TIMEOUT=20000
|
||||
|
||||
addons:
|
||||
apt:
|
||||
packages:
|
||||
- xvfb
|
||||
|
||||
install:
|
||||
- export DISPLAY=':99.0'
|
||||
- Xvfb :99 -screen 0 1024x768x24 > /dev/null 2>&1 &
|
||||
- npm ci || npm install
|
||||
|
||||
after_success: npm run codecov
|
||||
@ -0,0 +1,138 @@
|
||||
# Contributing to Svelte
|
||||
|
||||
Svelte is a new way to build web applications. It's a compiler that takes your declarative components and converts them into efficient JavaScript that surgically updates the DOM.
|
||||
|
||||
The [Open Source Guides](https://opensource.guide/) website has a collection of resources for individuals, communities, and companies who want to learn how to run and contribute to an open source project. Contributors and people new to open source alike will find the following guides especially useful:
|
||||
|
||||
* [How to Contribute to Open Source](https://opensource.guide/how-to-contribute/)
|
||||
* [Building Welcoming Communities](https://opensource.guide/building-community/)
|
||||
|
||||
## Get involved
|
||||
|
||||
There are many ways to contribute to Svelte, and many of them do not involve writing any code. Here's a few ideas to get started:
|
||||
|
||||
- Simply start using Svelte. Go through the [Getting Started](https://svelte.dev/blog/the-easiest-way-to-get-started) guide. Does everything work as expected? If not, we're always looking for improvements. Let us know by [opening an issue](#reporting-new-issues).
|
||||
- Look through the [open issues](https://github.com/sveltejs/svelte/issues). Provide workarounds, ask for clarification, or suggest labels. Help [triage issues](#triaging-issues-and-pull-requests).
|
||||
- If you find an issue you would like to fix, [open a pull request](#your-first-pull-request).
|
||||
- Read through our [tutorials](https://svelte.dev/tutorial/basics). If you find anything that is confusing or can be improved, you can make edits by clicking "Edit this chapter" at the bottom left of the tutorial page.
|
||||
- Take a look at the [features requested](https://github.com/sveltejs/svelte/labels/enhancement) by others in the community and consider opening a pull request if you see something you want to work on.
|
||||
|
||||
Contributions are very welcome. If you think you need help planning your contribution, please ping us on Discord at [svelte.dev/chat](https://svelte.dev/chat) and let us know you are looking for a bit of help.
|
||||
|
||||
### Triaging issues and pull requests
|
||||
|
||||
One great way you can contribute to the project without writing any code is to help triage issues and pull requests as they come in.
|
||||
|
||||
- Ask for more information if you believe the issue does not provide all the details required to solve it.
|
||||
- Suggest [labels](https://github.com/sveltejs/svelte/labels) that can help categorize issues.
|
||||
- Flag issues that are stale or that should be closed.
|
||||
- Ask for test plans and review code.
|
||||
|
||||
## Bugs
|
||||
|
||||
We use [GitHub issues](https://github.com/sveltejs/svelte/issues) for our public bugs. If you would like to report a problem, take a look around and see if someone already opened an issue about it. If you a are certain this is a new, unreported bug, you can submit a [bug report](#reporting-new-issues).
|
||||
|
||||
If you have questions about using Svelte, contact us on Discord at [svelte.dev/chat](https://svelte.dev/chat), and we will do our best to answer your questions.
|
||||
|
||||
If you see anything you'd like to be implemented, create a [feature request issue](https://github.com/sveltejs/svelte/issues/new?template=feature_request.md)
|
||||
|
||||
## Reporting new issues
|
||||
|
||||
When [opening a new issue](https://github.com/sveltejs/svelte/issues/new/choose), always make sure to fill out the issue template. **This step is very important!** Not doing so may result in your issue not being managed in a timely fashion. Don't take this personally if this happens, and feel free to open a new issue once you've gathered all the information required by the template.
|
||||
|
||||
- **One issue, one bug:** Please report a single bug per issue.
|
||||
- **Provide reproduction steps:** List all the steps necessary to reproduce the issue. The person reading your bug report should be able to follow these steps to reproduce your issue with minimal effort. If possible, use the [REPL](https://svelte.dev/repl) to create your reproduction.
|
||||
|
||||
## Installation
|
||||
|
||||
1. Ensure you have [npm](https://www.npmjs.com/get-npm) installed.
|
||||
1. After cloning the repository, run `npm install` in the root of the repository.
|
||||
1. To start a development server, run `npm run dev`.
|
||||
|
||||
|
||||
## Pull requests
|
||||
|
||||
### Your first pull request
|
||||
|
||||
So you have decided to contribute code back to upstream by opening a pull request. You've invested a good chunk of time, and we appreciate it. We will do our best to work with you and get the PR looked at.
|
||||
|
||||
Working on your first Pull Request? You can learn how from this free video series:
|
||||
|
||||
[**How to Contribute to an Open Source Project on GitHub**](https://egghead.io/courses/how-to-contribute-to-an-open-source-project-on-github)
|
||||
|
||||
### Proposing a change
|
||||
|
||||
If you would like to request a new feature or enhancement but are not yet thinking about opening a pull request, you can also file an issue with [feature template](https://github.com/sveltejs/svelte/issues/new?template=feature_request.md).
|
||||
|
||||
If you're only fixing a bug, it's fine to submit a pull request right away but we still recommend to file an issue detailing what you're fixing. This is helpful in case we don't accept that specific fix but want to keep track of the issue.
|
||||
|
||||
### Sending a pull request
|
||||
|
||||
Small pull requests are much easier to review and more likely to get merged. Make sure the PR does only one thing, otherwise please split it.
|
||||
|
||||
Please make sure the following is done when submitting a pull request:
|
||||
|
||||
1. Fork [the repository](https://github.com/sveltejs/svelte) and create your branch from `master`.
|
||||
1. Describe your **test plan** in your pull request description. Make sure to test your changes.
|
||||
1. Make sure your code lints (`npm run lint`).
|
||||
1. Make sure your tests pass (`npm run test`).
|
||||
|
||||
All pull requests should be opened against the `master` branch.
|
||||
|
||||
#### Test plan
|
||||
|
||||
A good test plan has the exact commands you ran and their output, provides screenshots or videos if the pull request changes UI.
|
||||
|
||||
- If you've changed APIs, update the documentation.
|
||||
|
||||
#### Writing tests
|
||||
|
||||
All tests are located in `/test` folder.
|
||||
|
||||
Test samples are kept in `/test/xxx/samples` folder.
|
||||
|
||||
#### Running tests
|
||||
|
||||
1. To run test, run `npm run test`
|
||||
1. To run test for a specific feature, you can use the `-g` (aka `--grep`) option. For example, to only run test involving transitions, run `npm run test -- -g transition`.
|
||||
|
||||
##### Running solo test
|
||||
|
||||
1. To run only one test, rename the test sample folder to end with `.solo`. For example, to run the `test/js/samples/action` only, rename it to `test/js/samples/action.solo`.
|
||||
1. To run only one test suite, rename the test suite folder to end with `.solo`. For example, to run the `test/js` test suite only, rename it to `test/js.solo`.
|
||||
1. Remember to rename the test folder back. The CI will fail if there's a solo test.
|
||||
|
||||
##### Updating `.expected` files
|
||||
|
||||
1. Tests suites like `css`, `js`, `server-side-rendering` asserts that the generated output has to match the content in the `.expected` file. For example, in the `js` test suites, the generated js code is compared against the content in `expected.js`.
|
||||
1. To update the content of the `.expected` file, run the test with `--update` flag. (`npm run test --update`)
|
||||
|
||||
#### Breaking changes
|
||||
|
||||
When adding a new breaking change, follow this template in your pull request:
|
||||
|
||||
```md
|
||||
### New breaking change here
|
||||
|
||||
- **Who does this affect**:
|
||||
- **How to migrate**:
|
||||
- **Why make this breaking change**:
|
||||
- **Severity (number of people affected x effort)**:
|
||||
```
|
||||
|
||||
### What happens next?
|
||||
|
||||
The core Svelte team will be monitoring for pull requests. Do help us by making your pull request easy to review by following the guidelines above.
|
||||
|
||||
## Style guide
|
||||
|
||||
[Eslint](https://eslint.org) will catch most styling issues that may exist in your code. You can check the status of your code styling by simply running `npm run lint`.
|
||||
|
||||
### Code conventions
|
||||
|
||||
- `snake_case` for internal variable names and methods
|
||||
- `camelCase` for public variable names and methods.
|
||||
|
||||
## License
|
||||
|
||||
By contributing to Svelte, you agree that your contributions will be licensed under its [MIT license](https://github.com/sveltejs/svelte/blob/master/LICENSE).
|
||||
@ -1,31 +0,0 @@
|
||||
# http://www.appveyor.com/docs/appveyor-yml
|
||||
|
||||
version: "{build}"
|
||||
|
||||
clone_depth: 10
|
||||
|
||||
init:
|
||||
- git config --global core.autocrlf false
|
||||
|
||||
environment:
|
||||
matrix:
|
||||
- nodejs_version: 8
|
||||
- nodejs_version: 10
|
||||
- nodejs_version: 12
|
||||
|
||||
install:
|
||||
- ps: Update-NodeJsInstallation (Get-NodeJsLatestBuild $env:nodejs_version)
|
||||
- npm ci || npm install
|
||||
|
||||
build: off
|
||||
|
||||
test_script:
|
||||
- node --version && npm --version
|
||||
- npm test
|
||||
|
||||
matrix:
|
||||
fast_finish: false
|
||||
|
||||
# cache:
|
||||
# - C:\Users\appveyor\AppData\Roaming\npm-cache -> package.json # npm cache
|
||||
# - node_modules -> package.json # local npm modules
|
||||
@ -0,0 +1,14 @@
|
||||
import { langs } from '@sveltejs/site-kit/utils/markdown.js';
|
||||
import PrismJS from 'prismjs';
|
||||
import 'prismjs/components/prism-bash';
|
||||
|
||||
export function highlight(source, lang) {
|
||||
const plang = langs[lang] || '';
|
||||
const highlighted = plang ? PrismJS.highlight(
|
||||
source,
|
||||
PrismJS.languages[plang],
|
||||
lang,
|
||||
) : source.replace(/[&<>]/g, c => ({ '&': '&', '<': '<', '>': '>' })[c]);
|
||||
|
||||
return `<pre class='language-${plang}'><code>${highlighted}</code></pre>`;
|
||||
}
|
||||
|
Before Width: | Height: | Size: 4.3 KiB After Width: | Height: | Size: 2.0 KiB |
|
Before Width: | Height: | Size: 10 KiB After Width: | Height: | Size: 5.7 KiB |
|
Before Width: | Height: | Size: 1.4 KiB |
|
Before Width: | Height: | Size: 9.0 KiB After Width: | Height: | Size: 7.8 KiB |
|
Before Width: | Height: | Size: 10 KiB After Width: | Height: | Size: 9.1 KiB |
|
Before Width: | Height: | Size: 4.0 KiB After Width: | Height: | Size: 1.8 KiB |
|
After Width: | Height: | Size: 1.5 KiB |
|
After Width: | Height: | Size: 5.7 KiB |
|
After Width: | Height: | Size: 4.9 KiB |
|
After Width: | Height: | Size: 4.0 KiB |
|
After Width: | Height: | Size: 6.7 KiB |
|
After Width: | Height: | Size: 7.2 KiB |
|
Before Width: | Height: | Size: 7.4 KiB |
|
Before Width: | Height: | Size: 12 KiB |
|
Before Width: | Height: | Size: 3.8 KiB |
|
After Width: | Height: | Size: 7.0 KiB |
|
Before Width: | Height: | Size: 111 KiB After Width: | Height: | Size: 111 KiB |
File diff suppressed because it is too large
Load Diff
@ -0,0 +1,6 @@
|
||||
export interface CssNode {
|
||||
type: string;
|
||||
start: number;
|
||||
end: number;
|
||||
[prop_name: string]: any;
|
||||
}
|
||||
@ -1,38 +1,51 @@
|
||||
import Node from './shared/Node';
|
||||
import Component from '../Component';
|
||||
import { walk } from 'estree-walker';
|
||||
import { Identifier } from 'estree';
|
||||
|
||||
const applicable = new Set(['Identifier', 'ObjectExpression', 'ArrayExpression', 'Property']);
|
||||
|
||||
export default class Let extends Node {
|
||||
type: 'Let';
|
||||
name: string;
|
||||
value: string;
|
||||
name: Identifier;
|
||||
value: Identifier;
|
||||
names: string[] = [];
|
||||
|
||||
constructor(component: Component, parent, scope, info) {
|
||||
super(component, parent, scope, info);
|
||||
|
||||
this.name = info.name;
|
||||
this.value = info.expression && `[✂${info.expression.start}-${info.expression.end}✂]`;
|
||||
this.name = { type: 'Identifier', name: info.name };
|
||||
|
||||
const { names } = this;
|
||||
|
||||
if (info.expression) {
|
||||
this.value = info.expression;
|
||||
|
||||
walk(info.expression, {
|
||||
enter: node => {
|
||||
enter(node) {
|
||||
if (!applicable.has(node.type)) {
|
||||
component.error(node, {
|
||||
component.error(node as any, {
|
||||
code: 'invalid-let',
|
||||
message: `let directive value must be an identifier or an object/array pattern`
|
||||
});
|
||||
}
|
||||
|
||||
if (node.type === 'Identifier') {
|
||||
this.names.push(node.name);
|
||||
names.push(node.name);
|
||||
}
|
||||
|
||||
// slightly unfortunate hack
|
||||
if (node.type === 'ArrayExpression') {
|
||||
(node as any).type = 'ArrayPattern';
|
||||
}
|
||||
|
||||
if (node.type === 'ObjectExpression') {
|
||||
(node as any).type = 'ObjectPattern';
|
||||
}
|
||||
}
|
||||
});
|
||||
} else {
|
||||
this.names.push(this.name);
|
||||
names.push(this.name.name);
|
||||
}
|
||||
}
|
||||
}
|
||||
@ -1,22 +1,26 @@
|
||||
import Block from '../Block';
|
||||
import Wrapper from './shared/Wrapper';
|
||||
import deindent from '../../utils/deindent';
|
||||
import { b } from 'code-red';
|
||||
import Body from '../../nodes/Body';
|
||||
import { Identifier } from 'estree';
|
||||
import EventHandler from './Element/EventHandler';
|
||||
|
||||
export default class BodyWrapper extends Wrapper {
|
||||
node: Body;
|
||||
|
||||
render(block: Block, _parent_node: string, _parent_nodes: string) {
|
||||
this.node.handlers.forEach(handler => {
|
||||
const snippet = handler.render(block);
|
||||
render(block: Block, _parent_node: Identifier, _parent_nodes: Identifier) {
|
||||
this.node.handlers
|
||||
.map(handler => new EventHandler(handler, this))
|
||||
.forEach(handler => {
|
||||
const snippet = handler.get_snippet(block);
|
||||
|
||||
block.builders.init.add_block(deindent`
|
||||
@_document.body.addEventListener("${handler.name}", ${snippet});
|
||||
`);
|
||||
block.chunks.init.push(b`
|
||||
@_document.body.addEventListener("${handler.node.name}", ${snippet});
|
||||
`);
|
||||
|
||||
block.builders.destroy.add_block(deindent`
|
||||
@_document.body.removeEventListener("${handler.name}", ${snippet});
|
||||
`);
|
||||
});
|
||||
block.chunks.destroy.push(b`
|
||||
@_document.body.removeEventListener("${handler.node.name}", ${snippet});
|
||||
`);
|
||||
});
|
||||
}
|
||||
}
|
||||
|
||||
@ -0,0 +1,69 @@
|
||||
import EventHandler from '../../../nodes/EventHandler';
|
||||
import Wrapper from '../shared/Wrapper';
|
||||
import Block from '../../Block';
|
||||
import { b, x, p } from 'code-red';
|
||||
|
||||
const TRUE = x`true`;
|
||||
const FALSE = x`false`;
|
||||
|
||||
export default class EventHandlerWrapper {
|
||||
node: EventHandler;
|
||||
parent: Wrapper;
|
||||
|
||||
constructor(node: EventHandler, parent: Wrapper) {
|
||||
this.node = node;
|
||||
this.parent = parent;
|
||||
|
||||
if (!node.expression) {
|
||||
this.parent.renderer.component.add_var({
|
||||
name: node.handler_name.name,
|
||||
internal: true,
|
||||
referenced: true,
|
||||
});
|
||||
|
||||
this.parent.renderer.component.partly_hoisted.push(b`
|
||||
function ${node.handler_name.name}(event) {
|
||||
@bubble($$self, event);
|
||||
}
|
||||
`);
|
||||
}
|
||||
}
|
||||
|
||||
get_snippet(block) {
|
||||
const snippet = this.node.expression ? this.node.expression.manipulate(block) : x`#ctx.${this.node.handler_name}`;
|
||||
|
||||
if (this.node.reassigned) {
|
||||
block.maintain_context = true;
|
||||
return x`function () { ${snippet}.apply(this, arguments); }`;
|
||||
}
|
||||
return snippet;
|
||||
}
|
||||
|
||||
render(block: Block, target: string) {
|
||||
let snippet = this.get_snippet(block);
|
||||
|
||||
if (this.node.modifiers.has('preventDefault')) snippet = x`@prevent_default(${snippet})`;
|
||||
if (this.node.modifiers.has('stopPropagation')) snippet = x`@stop_propagation(${snippet})`;
|
||||
if (this.node.modifiers.has('self')) snippet = x`@self(${snippet})`;
|
||||
|
||||
const args = [];
|
||||
|
||||
const opts = ['passive', 'once', 'capture'].filter(mod => this.node.modifiers.has(mod));
|
||||
if (opts.length) {
|
||||
args.push((opts.length === 1 && opts[0] === 'capture')
|
||||
? TRUE
|
||||
: x`{ ${opts.map(opt => p`${opt}: true`)} }`);
|
||||
} else if (block.renderer.options.dev) {
|
||||
args.push(FALSE);
|
||||
}
|
||||
|
||||
if (block.renderer.options.dev) {
|
||||
args.push(this.node.modifiers.has('stopPropagation') ? TRUE : FALSE);
|
||||
args.push(this.node.modifiers.has('preventDefault') ? TRUE : FALSE);
|
||||
}
|
||||
|
||||
block.event_listeners.push(
|
||||
x`@listen(${target}, "${this.node.name}", ${snippet}, ${args})`
|
||||
);
|
||||
}
|
||||
}
|
||||
Some files were not shown because too many files have changed in this diff Show More
Loading…
Reference in new issue