From d592d8aebd80f858171eeedb5065769102e7e883 Mon Sep 17 00:00:00 2001 From: Simon Holthausen Date: Sun, 20 Sep 2026 22:07:01 +0200 Subject: [PATCH] original test obsolete, refactor into a new test --- .../_config.js | 17 ++--------------- .../main.svelte | 0 2 files changed, 2 insertions(+), 15 deletions(-) rename packages/svelte/tests/runtime-runes/samples/{async-commit-effect-overlap => async-indirect-overlap}/_config.js (51%) rename packages/svelte/tests/runtime-runes/samples/{async-commit-effect-overlap => async-indirect-overlap}/main.svelte (100%) diff --git a/packages/svelte/tests/runtime-runes/samples/async-commit-effect-overlap/_config.js b/packages/svelte/tests/runtime-runes/samples/async-indirect-overlap/_config.js similarity index 51% rename from packages/svelte/tests/runtime-runes/samples/async-commit-effect-overlap/_config.js rename to packages/svelte/tests/runtime-runes/samples/async-indirect-overlap/_config.js index 5557c7ebbb..abe1894686 100644 --- a/packages/svelte/tests/runtime-runes/samples/async-commit-effect-overlap/_config.js +++ b/packages/svelte/tests/runtime-runes/samples/async-indirect-overlap/_config.js @@ -7,8 +7,7 @@ export default test({ async test({ assert, target }) { await tick(); - const [a, b, , pop] = target.querySelectorAll('button'); - const shift = target.querySelectorAll('button')[2]; + const [a, b, shift, pop] = target.querySelectorAll('button'); assert.htmlEqual(target.innerHTML, `${buttons}

a

a

aa

1

`); @@ -21,21 +20,9 @@ export default test({ await tick(); assert.htmlEqual(target.innerHTML, `${buttons}

a

a

aa

1

`); - // resolve the newer (b) batch first. Committing it must not commit the - // still-pending `a` batch, whose async work has not completed — `a` must - // still read 'a', and the unrelated `c` update must not be blocked + // resolve the newer (b) batch first. Since it ran with the latest a value, it can resolve both pop.click(); await tick(); - assert.htmlEqual(target.innerHTML, `${buttons}

a

b

ab

2

`); - - // stale promise from the `a` batch's first run — resolving it does nothing - shift.click(); - await tick(); - assert.htmlEqual(target.innerHTML, `${buttons}

a

b

ab

2

`); - - // the `a` batch's re-run await ('bb') resolves — everything is committed - shift.click(); - await tick(); assert.htmlEqual(target.innerHTML, `${buttons}

b

b

bb

2

`); } }); diff --git a/packages/svelte/tests/runtime-runes/samples/async-commit-effect-overlap/main.svelte b/packages/svelte/tests/runtime-runes/samples/async-indirect-overlap/main.svelte similarity index 100% rename from packages/svelte/tests/runtime-runes/samples/async-commit-effect-overlap/main.svelte rename to packages/svelte/tests/runtime-runes/samples/async-indirect-overlap/main.svelte