From ca280a6c15a5a360366205cc60908205779021ba Mon Sep 17 00:00:00 2001 From: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Tue, 18 Apr 2023 17:58:47 +0200 Subject: [PATCH] drive by lint --- test/types/actions.ts | 52 ++++++++++++------------------------------- 1 file changed, 14 insertions(+), 38 deletions(-) diff --git a/test/types/actions.ts b/test/types/actions.ts index 7a0ca97714..3d56aa3605 100644 --- a/test/types/actions.ts +++ b/test/types/actions.ts @@ -9,19 +9,14 @@ const href: Action = (node) => { }; href; -const required: Action = (node, param) => { - node; - param; -}; +const required: Action = (_node, _param) => {}; required(null as any, true); // @ts-expect-error (only in strict mode) boolean missing required(null as any); // @ts-expect-error no boolean required(null as any, 'string'); -const required1: Action = (node, param) => { - node; - param; +const required1: Action = (_node, _param) => { return { update: (p) => p === true, destroy: () => {} @@ -29,14 +24,10 @@ const required1: Action = (node, param) => { }; required1; -const required2: Action = (node) => { - node; -}; +const required2: Action = (_node) => {}; required2; -const required3: Action = (node, param) => { - node; - param; +const required3: Action = (_node, _param) => { return { // @ts-expect-error comparison always resolves to false update: (p) => p === 'd', @@ -45,18 +36,13 @@ const required3: Action = (node, param) => { }; required3; -const optional: Action = (node, param?) => { - node; - param; -}; +const optional: Action = (_node, _param?) => {}; optional(null as any, true); optional(null as any); // @ts-expect-error no boolean optional(null as any, 'string'); -const optional1: Action = (node, param?) => { - node; - param; +const optional1: Action = (_node, _param?) => { return { update: (p) => p === true, destroy: () => {} @@ -64,20 +50,13 @@ const optional1: Action = (node, param?) => { }; optional1; -const optional2: Action = (node) => { - node; -}; +const optional2: Action = (_node) => {}; optional2; -const optional3: Action = (node, param) => { - node; - param; -}; +const optional3: Action = (_node, _param) => {}; optional3; -const optional4: Action = (node, param?) => { - node; - param; +const optional4: Action = (_node, _param?) => { return { // @ts-expect-error comparison always resolves to false update: (p) => p === 'd', @@ -86,17 +65,14 @@ const optional4: Action = (node, param?) => { }; optional4; -const no: Action = (node) => { - node; -}; +const no: Action = (_node) => {}; // @ts-expect-error second param no(null as any, true); no(null as any); // @ts-expect-error second param no(null as any, 'string'); -const no1: Action = (node) => { - node; +const no1: Action = (_node) => { return { destroy: () => {} }; @@ -104,15 +80,15 @@ const no1: Action = (node) => { no1; // @ts-expect-error param given -const no2: Action = (node, param?) => {}; +const no2: Action = (_node, _param?) => {}; no2; // @ts-expect-error param given -const no3: Action = (node, param) => {}; +const no3: Action = (_node, _param) => {}; no3; // @ts-expect-error update method given -const no4: Action = (node) => { +const no4: Action = (_node) => { return { update: () => {}, destroy: () => {}