From c7328ffa249d9864c60de683d8af7678031772ca Mon Sep 17 00:00:00 2001 From: pushkin Date: Mon, 6 Apr 2020 00:12:43 +0200 Subject: [PATCH] only check dirty for transition_in #4064 did not have another bug, the first change just blocked nested `if_block`s from getting updates --- src/compiler/compile/render_dom/wrappers/IfBlock.ts | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/src/compiler/compile/render_dom/wrappers/IfBlock.ts b/src/compiler/compile/render_dom/wrappers/IfBlock.ts index c1ff2024f3..7fef8ec830 100644 --- a/src/compiler/compile/render_dom/wrappers/IfBlock.ts +++ b/src/compiler/compile/render_dom/wrappers/IfBlock.ts @@ -526,9 +526,11 @@ export default class IfBlockWrapper extends Wrapper { ${name}.c(); ${has_transitions && b`@transition_in(${name}, 1);`} ${name}.m(${update_mount_node}, ${anchor}); - } else if (${block.renderer.dirty(branch.dependencies)}) { + } else { ${dynamic && b`${name}.p(#ctx, #dirty);`} - ${has_transitions && b`@transition_in(${name}, 1);`} + if (${block.renderer.dirty(branch.dependencies)}) { + ${has_transitions && b`@transition_in(${name}, 1);`} + } } `;