From c66bf178aae18c2b4d8ac189a48cf10c47e4d417 Mon Sep 17 00:00:00 2001
From: Paolo Ricciuti <ricciutipaolo@gmail.com>
Date: Mon, 9 Dec 2024 13:39:31 +0100
Subject: [PATCH] fix: mark subtree dynamic for bind with sequence expressions
 (#14626)

---
 .changeset/green-pandas-study.md                   |  5 +++++
 .../phases/2-analyze/visitors/BindDirective.js     |  3 +++
 .../samples/bind-getter-setter/_config.js          | 14 ++++++++++----
 .../samples/bind-getter-setter/main.svelte         |  9 +++++++++
 4 files changed, 27 insertions(+), 4 deletions(-)
 create mode 100644 .changeset/green-pandas-study.md

diff --git a/.changeset/green-pandas-study.md b/.changeset/green-pandas-study.md
new file mode 100644
index 0000000000..869599055c
--- /dev/null
+++ b/.changeset/green-pandas-study.md
@@ -0,0 +1,5 @@
+---
+'svelte': patch
+---
+
+fix: mark subtree dynamic for bind with sequence expressions
diff --git a/packages/svelte/src/compiler/phases/2-analyze/visitors/BindDirective.js b/packages/svelte/src/compiler/phases/2-analyze/visitors/BindDirective.js
index b062365380..b4de1925df 100644
--- a/packages/svelte/src/compiler/phases/2-analyze/visitors/BindDirective.js
+++ b/packages/svelte/src/compiler/phases/2-analyze/visitors/BindDirective.js
@@ -11,6 +11,7 @@ import * as w from '../../../warnings.js';
 import { binding_properties } from '../../bindings.js';
 import fuzzymatch from '../../1-parse/utils/fuzzymatch.js';
 import { is_content_editable_binding, is_svg } from '../../../../utils.js';
+import { mark_subtree_dynamic } from './shared/fragment.js';
 
 /**
  * @param {AST.BindDirective} node
@@ -141,6 +142,8 @@ export function BindDirective(node, context) {
 			e.bind_invalid_expression(node);
 		}
 
+		mark_subtree_dynamic(context.path);
+
 		return;
 	}
 
diff --git a/packages/svelte/tests/runtime-runes/samples/bind-getter-setter/_config.js b/packages/svelte/tests/runtime-runes/samples/bind-getter-setter/_config.js
index 158d1e6f63..dd5c387405 100644
--- a/packages/svelte/tests/runtime-runes/samples/bind-getter-setter/_config.js
+++ b/packages/svelte/tests/runtime-runes/samples/bind-getter-setter/_config.js
@@ -4,17 +4,23 @@ import { assert_ok } from '../../../suite';
 
 export default test({
 	async test({ assert, target, logs }) {
-		const input = target.querySelector('input');
-
-		assert_ok(input);
+		const [input, checkbox] = target.querySelectorAll('input');
 
 		input.value = '2';
 		input.dispatchEvent(new window.Event('input'));
 
 		flushSync();
 
-		assert.htmlEqual(target.innerHTML, `<button>a: 2</button><input type="value">`);
+		assert.htmlEqual(
+			target.innerHTML,
+			`<button>a: 2</button><input type="value"><div><input type="checkbox" ></div>`
+		);
 
 		assert.deepEqual(logs, ['b', '2', 'a', '2']);
+
+		flushSync(() => {
+			checkbox.click();
+		});
+		assert.deepEqual(logs, ['b', '2', 'a', '2', 'check', false]);
 	}
 });
diff --git a/packages/svelte/tests/runtime-runes/samples/bind-getter-setter/main.svelte b/packages/svelte/tests/runtime-runes/samples/bind-getter-setter/main.svelte
index 191a423476..f6d908fba1 100644
--- a/packages/svelte/tests/runtime-runes/samples/bind-getter-setter/main.svelte
+++ b/packages/svelte/tests/runtime-runes/samples/bind-getter-setter/main.svelte
@@ -2,6 +2,7 @@
 	import Child from './Child.svelte';
 
 	let a = $state(0);
+	let check = $state(true);
 </script>
 
 <button onclick={() => a++}>a: {a}</button>
@@ -14,3 +15,11 @@
 	}}
 />
 
+<div>
+	<input type="checkbox" 
+	bind:checked={()=>check,
+	(v)=>{
+		console.log('check', v);
+		check = v;
+	}} />
+</div>
\ No newline at end of file