From c65f06a610693db3f371dccae683a1ee897c7003 Mon Sep 17 00:00:00 2001 From: Admin Date: Sat, 11 Aug 2018 21:16:42 -0500 Subject: [PATCH] Changes stop and prevent to stopPropagation and preventDefault --- src/utils/getEventModifiers.ts | 4 ++-- src/validate/html/validateEventHandler.ts | 2 +- test/validator/samples/event-modifiers-invalid/errors.json | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) diff --git a/src/utils/getEventModifiers.ts b/src/utils/getEventModifiers.ts index f194e987e2..554a2c79af 100644 --- a/src/utils/getEventModifiers.ts +++ b/src/utils/getEventModifiers.ts @@ -6,9 +6,9 @@ export default function getEventModifiers(handlerName: String) { let modifiers = handlerName.split('|').slice(1); let eventModifiers = modifiers.reduce((acc, m) => { - if (m === 'stop') + if (m === 'stopPropagation') acc.bodyModifiers += 'event.stopPropagation();\n'; - else if (m === 'prevent') + else if (m === 'preventDefault') acc.bodyModifiers += 'event.preventDefault();\n'; else if (m === 'capture') acc.optionModifiers[m] = true; diff --git a/src/validate/html/validateEventHandler.ts b/src/validate/html/validateEventHandler.ts index b114070993..f1df2f741c 100644 --- a/src/validate/html/validateEventHandler.ts +++ b/src/validate/html/validateEventHandler.ts @@ -6,7 +6,7 @@ import { Node } from '../../interfaces'; const validBuiltins = new Set(['set', 'fire', 'destroy']); -const validModifiers = new Set(['stop', 'prevent', 'capture', 'once', 'passive']); +const validModifiers = new Set(['stopPropagation', 'preventDefault', 'capture', 'once', 'passive']); export default function validateEventHandlerCallee( validator: Validator, diff --git a/test/validator/samples/event-modifiers-invalid/errors.json b/test/validator/samples/event-modifiers-invalid/errors.json index 99737f50d2..af1cca83e4 100644 --- a/test/validator/samples/event-modifiers-invalid/errors.json +++ b/test/validator/samples/event-modifiers-invalid/errors.json @@ -1,5 +1,5 @@ [{ - "message": "Valid event modifiers are stop, prevent, capture, once, passive.", + "message": "Valid event modifiers are stopPropagation, preventDefault, capture, once, passive.", "code": "invalid-event-modifiers", "start": { "line": 1,