From c601acfe7ed85a4279ee3c9c582a09f2733c734d Mon Sep 17 00:00:00 2001
From: Paul Sauve <paul@burngames.net>
Date: Fri, 30 Dec 2016 21:33:05 -0600
Subject: [PATCH] Fix partial numbers being detected as numbers

---
 .../dom/visitors/attributes/addComponentAttributes.js |  2 +-
 .../generator/attribute-partial-number/Component.html |  1 +
 test/generator/attribute-partial-number/_config.js    |  3 +++
 test/generator/attribute-partial-number/main.html     | 11 +++++++++++
 4 files changed, 16 insertions(+), 1 deletion(-)
 create mode 100644 test/generator/attribute-partial-number/Component.html
 create mode 100644 test/generator/attribute-partial-number/_config.js
 create mode 100644 test/generator/attribute-partial-number/main.html

diff --git a/src/generators/dom/visitors/attributes/addComponentAttributes.js b/src/generators/dom/visitors/attributes/addComponentAttributes.js
index d1c70a574a..77bc99ea4c 100644
--- a/src/generators/dom/visitors/attributes/addComponentAttributes.js
+++ b/src/generators/dom/visitors/attributes/addComponentAttributes.js
@@ -28,7 +28,7 @@ export default function addComponentAttributes ( generator, node, local ) {
 
 				if ( value.type === 'Text' ) {
 					// static attributes
-					const result = isNaN( parseFloat( value.data ) ) ? JSON.stringify( value.data ) : value.data;
+					const result = String( parseFloat( value.data ) ) !== value.data ? JSON.stringify( value.data ) : value.data;
 					local.staticAttributes.push({
 						name: attribute.name,
 						value: result
diff --git a/test/generator/attribute-partial-number/Component.html b/test/generator/attribute-partial-number/Component.html
new file mode 100644
index 0000000000..c48ee295fc
--- /dev/null
+++ b/test/generator/attribute-partial-number/Component.html
@@ -0,0 +1 @@
+<p data-value="{{value}}"></p>
diff --git a/test/generator/attribute-partial-number/_config.js b/test/generator/attribute-partial-number/_config.js
new file mode 100644
index 0000000000..acb5859897
--- /dev/null
+++ b/test/generator/attribute-partial-number/_config.js
@@ -0,0 +1,3 @@
+export default {
+    html: '<p data-value="10px"></p>'
+};
diff --git a/test/generator/attribute-partial-number/main.html b/test/generator/attribute-partial-number/main.html
new file mode 100644
index 0000000000..7f56dcb447
--- /dev/null
+++ b/test/generator/attribute-partial-number/main.html
@@ -0,0 +1,11 @@
+<Component value="10px"/>
+
+<script>
+    import Component from './Component.html';
+
+    export default {
+        components: {
+            Component
+        }
+    };
+</script>