From 3fda96a624ff8e131f507e559bb02f5dbcd1273b Mon Sep 17 00:00:00 2001 From: Luca Bonavita Date: Sun, 7 Apr 2019 17:03:07 +0100 Subject: [PATCH 1/2] Don't update the active section for headings below level 3 Fixes #2365 --- site/src/routes/docs/_sections.js | 2 +- site/src/routes/docs/index.svelte | 6 ++++-- 2 files changed, 5 insertions(+), 3 deletions(-) diff --git a/site/src/routes/docs/_sections.js b/site/src/routes/docs/_sections.js index 79b64c58b3..d1447fb76a 100644 --- a/site/src/routes/docs/_sections.js +++ b/site/src/routes/docs/_sections.js @@ -125,7 +125,7 @@ export default function() { return ` - + ${text} `; diff --git a/site/src/routes/docs/index.svelte b/site/src/routes/docs/index.svelte index 0cbbf547f5..157ee39f9c 100644 --- a/site/src/routes/docs/index.svelte +++ b/site/src/routes/docs/index.svelte @@ -18,7 +18,9 @@ let show_contents = false; onMount(() => { - const anchors = container.querySelectorAll('[id]'); + // don't update `active_section` for headings below level 3, see _sections.js + const anchors = container.querySelectorAll('[id]:not([data-level="4"])'); + let positions; const onresize = () => { @@ -372,4 +374,4 @@ - \ No newline at end of file + From 1b9084b51e92a8fe93fbb44fb6766734b0d4c52f Mon Sep 17 00:00:00 2001 From: Luca Bonavita Date: Sun, 7 Apr 2019 17:41:46 +0100 Subject: [PATCH 2/2] use `data-scrollignore` rather than being level specific --- site/src/routes/docs/_sections.js | 2 +- site/src/routes/docs/index.svelte | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/site/src/routes/docs/_sections.js b/site/src/routes/docs/_sections.js index d1447fb76a..9a30845854 100644 --- a/site/src/routes/docs/_sections.js +++ b/site/src/routes/docs/_sections.js @@ -125,7 +125,7 @@ export default function() { return ` - + 3 ? 'data-scrollignore' : ''}> ${text} `; diff --git a/site/src/routes/docs/index.svelte b/site/src/routes/docs/index.svelte index 157ee39f9c..98dfae299e 100644 --- a/site/src/routes/docs/index.svelte +++ b/site/src/routes/docs/index.svelte @@ -19,7 +19,7 @@ onMount(() => { // don't update `active_section` for headings below level 3, see _sections.js - const anchors = container.querySelectorAll('[id]:not([data-level="4"])'); + const anchors = container.querySelectorAll('[id]:not([data-scrollignore])'); let positions;