From be2e41b558f57b1230dc6387381fc23eba4fdf2b Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Sun, 16 Dec 2018 09:18:06 -0500 Subject: [PATCH] remove unused refs stuff --- src/compile/Component.ts | 1 - src/compile/render-dom/index.ts | 12 ------------ src/internal/Component.js | 6 +----- src/internal/await-block.js | 1 - src/internal/scheduler.js | 1 - 5 files changed, 1 insertion(+), 20 deletions(-) diff --git a/src/compile/Component.ts b/src/compile/Component.ts index bf874bbbea..36730ed09e 100644 --- a/src/compile/Component.ts +++ b/src/compile/Component.ts @@ -80,7 +80,6 @@ export default class Component { indirectDependencies: Map> = new Map(); template_references: Set = new Set(); - refs: Set = new Set(); file: string; locate: (c: number) => { line: number, column: number }; diff --git a/src/compile/render-dom/index.ts b/src/compile/render-dom/index.ts index 0384a4162e..ffc0634e02 100644 --- a/src/compile/render-dom/index.ts +++ b/src/compile/render-dom/index.ts @@ -55,8 +55,6 @@ export default function dom( builder.addBlock(block.toString()); }); - const refs = Array.from(component.refs); - if (options.dev && !options.hydratable) { block.builders.claim.addLine( 'throw new Error("options.hydrate only works if the component was compiled with the `hydratable: true` option");' @@ -87,14 +85,6 @@ export default function dom( ` : null; - const inject_refs = refs.length > 0 - ? deindent` - $$refs => { - ${refs.map(name => `${name} = $$refs.${name};`)} - } - ` - : null; - const body = []; const not_equal = component.options.immutable ? `@not_equal` : `@safe_not_equal`; @@ -307,8 +297,6 @@ export default function dom( if (${Array.from(d.dependencies).map(n => `$$dirty.${n}`).join(' || ')}) ${d.snippet}`)} }; `} - - ${inject_refs && `$$self.$$.inject_refs = ${inject_refs};`} } `); } diff --git a/src/internal/Component.js b/src/internal/Component.js index c96aa93ab3..2db423c9a1 100644 --- a/src/internal/Component.js +++ b/src/internal/Component.js @@ -10,12 +10,10 @@ export function bind(component, name, callback) { } export function mount_component(component, target, anchor) { - const { fragment, refs, inject_refs, on_mount, on_destroy, after_render } = component.$$; + const { fragment, on_mount, on_destroy, after_render } = component.$$; fragment[fragment.i ? 'i' : 'm'](target, anchor); - inject_refs(refs); - // onMount happens after the initial afterUpdate. Because // afterUpdate callbacks happen in reverse order (inner first) // we schedule onMount callbacks before afterUpdate callbacks @@ -69,7 +67,6 @@ export function init(component, options, define, create_fragment, not_equal) { get: empty, set: noop, update: noop, - inject_refs: noop, not_equal, bound: blankObject(), @@ -82,7 +79,6 @@ export function init(component, options, define, create_fragment, not_equal) { // everything else callbacks: blankObject(), slotted: options.slots || {}, - refs: {}, dirty: null, binding_groups: [] }; diff --git a/src/internal/await-block.js b/src/internal/await-block.js index 0d7274f2eb..c579ef2242 100644 --- a/src/internal/await-block.js +++ b/src/internal/await-block.js @@ -32,7 +32,6 @@ export function handlePromise(promise, info) { block[block.i ? 'i' : 'm'](info.mount(), info.anchor); // TODO is some of this redundant? - info.component.$$.inject_refs(info.component.$$.refs); run_all(info.component.$$.after_render); flush(); } diff --git a/src/internal/scheduler.js b/src/internal/scheduler.js index fa6fc3a2e3..d245324a3b 100644 --- a/src/internal/scheduler.js +++ b/src/internal/scheduler.js @@ -58,7 +58,6 @@ function update($$) { $$.update($$.dirty); run_all($$.before_render); $$.fragment.p($$.dirty, $$.get()); - $$.inject_refs($$.refs); $$.dirty = null; $$.after_render.forEach(add_render_callback);