Merge pull request #2023 from sveltejs/component-name-conflict

Prevent component name conflict

package.json

@@ -1,6 +1,6 @@
 {
   "name": "svelte",
-  "version": "3.0.0-alpha20",
+  "version": "3.0.0-alpha21",
   "description": "The magical disappearing UI framework",
   "module": "index.mjs",
   "main": "index.js",

src/compile/Component.ts

@@ -93,7 +93,7 @@ export default class Component {
 		options: CompileOptions,
 		stats: Stats
 	) {
-		this.name = this.getUniqueName(name);
+		this.name = name;
 
 		this.stats = stats;
 		this.ast = ast;
@@ -131,6 +131,7 @@ export default class Component {
 		this.walk_module_js();
 		this.walk_instance_js_pre_template();
 
+		this.name = this.getUniqueName(name);
 		this.fragment = new Fragment(this, ast.html);
 
 		this.walk_instance_js_post_template();

test/runtime/index.js

@@ -34,7 +34,7 @@ describe("runtime", () => {
 
 		require.extensions[".html"] = function(module, filename) {
 			const options = Object.assign(
-				{ filename, name: getName(filename), format: 'cjs', sveltePath },
+				{ filename, name: compileOptions.name || getName(filename), format: 'cjs', sveltePath },
 				compileOptions
 			);
 

test/runtime/samples/deconflict-component-name-with-global/_config.js

@@ -0,0 +1,9 @@
+export default {
+	compileOptions: {
+		name: 'Set'
+	},
+
+	preserveIdentifiers: true,
+
+	html: `<p>true</p>`
+};

test/runtime/samples/deconflict-component-name-with-global/main.html

@@ -0,0 +1,5 @@
+<script>
+	let set = new Set(['x']);
+</script>
+
+<p>{set.has('x')}</p>

test/runtime/samples/dev-warning-missing-data-binding/_config.js

@@ -4,6 +4,6 @@ export default {
 	},
 
 	warnings: [
-		`<Main$> was created without expected prop 'value'`
+		`<Main> was created without expected prop 'value'`
 	]
 };

test/runtime/samples/dev-warning-missing-data-component/_config.js

@@ -4,6 +4,6 @@ export default {
 	},
 
 	warnings: [
-		`<Foo$> was created without expected prop 'y'`
+		`<Foo> was created without expected prop 'y'`
 	]
 };

test/runtime/samples/dev-warning-missing-data/_config.js

@@ -4,7 +4,7 @@ export default {
 	},
 
 	warnings: [
-		`<Main$> was created without expected prop 'foo'`,
-		`<Main$> was created without expected prop 'bar'`
+		`<Main> was created without expected prop 'foo'`,
+		`<Main> was created without expected prop 'bar'`
 	]
 };

test/runtime/samples/dev-warning-readonly-computed/_config.js

@@ -12,7 +12,7 @@ export default {
 			component.foo = 1;
 			throw new Error( 'Expected an error' );
 		} catch ( err ) {
-			assert.equal( err.message, `<Main$>: Cannot set read-only property 'foo'` );
+			assert.equal( err.message, `<Main>: Cannot set read-only property 'foo'` );
 		}
 	}
 };

test/runtime/samples/dev-warning-readonly-window-binding/_config.js

@@ -8,7 +8,7 @@ export default {
 			component.width = 99;
 			throw new Error('Expected an error');
 		} catch (err) {
-			assert.equal(err.message, `<Main$>: Cannot set read-only property 'width'`);
+			assert.equal(err.message, `<Main>: Cannot set read-only property 'width'`);
 		}
 	}
 };