From 2c8f73f2b69cccbe32bdbbd5b2520254bf69ec67 Mon Sep 17 00:00:00 2001 From: Rich-Harris Date: Fri, 9 Dec 2016 08:43:39 -0500 Subject: [PATCH] =?UTF-8?q?omit=20attributes=20for=20SSR=20=E2=80=93=20fix?= =?UTF-8?q?es=20#163?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- src/server-side-rendering/compile.js | 2 ++ test/server-side-rendering/directives/_actual.html | 1 + test/server-side-rendering/directives/_expected.html | 1 + test/server-side-rendering/directives/main.html | 1 + 4 files changed, 5 insertions(+) create mode 100644 test/server-side-rendering/directives/_actual.html create mode 100644 test/server-side-rendering/directives/_expected.html create mode 100644 test/server-side-rendering/directives/main.html diff --git a/src/server-side-rendering/compile.js b/src/server-side-rendering/compile.js index 38fdab5502..54b5dff969 100644 --- a/src/server-side-rendering/compile.js +++ b/src/server-side-rendering/compile.js @@ -174,6 +174,8 @@ export default function compile ( source, { filename }) { let element = `<${node.name}`; node.attributes.forEach( attribute => { + if ( attribute.type !== 'Attribute' ) return; + let str = ` ${attribute.name}`; if ( attribute.value !== true ) { diff --git a/test/server-side-rendering/directives/_actual.html b/test/server-side-rendering/directives/_actual.html new file mode 100644 index 0000000000..13cd34a990 --- /dev/null +++ b/test/server-side-rendering/directives/_actual.html @@ -0,0 +1 @@ + \ No newline at end of file diff --git a/test/server-side-rendering/directives/_expected.html b/test/server-side-rendering/directives/_expected.html new file mode 100644 index 0000000000..f80f9a3d92 --- /dev/null +++ b/test/server-side-rendering/directives/_expected.html @@ -0,0 +1 @@ + diff --git a/test/server-side-rendering/directives/main.html b/test/server-side-rendering/directives/main.html new file mode 100644 index 0000000000..a960ff707e --- /dev/null +++ b/test/server-side-rendering/directives/main.html @@ -0,0 +1 @@ +