From b8f32c0b1a295fd56c7c04683402968f32f01597 Mon Sep 17 00:00:00 2001 From: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Thu, 22 Dec 2022 17:47:52 +0100 Subject: [PATCH] [docs] clear timeout on destroy backported from https://github.com/sveltejs/learn.svelte.dev/pull/166 --- .../02-adding-parameters-to-actions/app-a/longpress.js | 1 + .../02-adding-parameters-to-actions/app-b/longpress.js | 1 + 2 files changed, 2 insertions(+) diff --git a/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-a/longpress.js b/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-a/longpress.js index 00bb9d05c8..07235f21dc 100644 --- a/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-a/longpress.js +++ b/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-a/longpress.js @@ -18,6 +18,7 @@ export function longpress(node, duration) { return { destroy() { + clearTimeout(timer); node.removeEventListener('mousedown', handleMousedown); node.removeEventListener('mouseup', handleMouseup); } diff --git a/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-b/longpress.js b/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-b/longpress.js index 9d807cb13a..4ce0dfe05b 100644 --- a/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-b/longpress.js +++ b/site/content/tutorial/12-actions/02-adding-parameters-to-actions/app-b/longpress.js @@ -21,6 +21,7 @@ export function longpress(node, duration) { duration = newDuration; }, destroy() { + clearTimeout(timer); node.removeEventListener('mousedown', handleMousedown); node.removeEventListener('mouseup', handleMouseup); }