From b610708f3dc13df623a1702b60d8aaf1fe5582c0 Mon Sep 17 00:00:00 2001 From: Simon Holthausen Date: Wed, 15 Jul 2026 15:10:38 +0200 Subject: [PATCH] unskip more tests --- .../samples/async-overlap-multiple-2/_config.js | 1 - .../samples/async-overlap-multiple-3/_config.js | 3 +-- .../samples/async-overlap-multiple-4/_config.js | 5 +---- .../samples/async-overlap-multiple-fork-3/_config.js | 1 - .../samples/async-stale-derived-2/_config.js | 2 +- .../samples/async-state-new-branch-fork-1/_config.js | 9 +-------- 6 files changed, 4 insertions(+), 17 deletions(-) diff --git a/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-2/_config.js b/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-2/_config.js index f4aff83aad..0f422d1797 100644 --- a/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-2/_config.js +++ b/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-2/_config.js @@ -2,7 +2,6 @@ import { tick } from 'svelte'; import { test } from '../../test'; export default test({ - skip: true, // TODO works on https://github.com/sveltejs/svelte/pull/17971 async test({ assert, target }) { await tick(); const [a_b, a_c, b_d, shift, pop] = target.querySelectorAll('button'); diff --git a/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-3/_config.js b/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-3/_config.js index c9e7513b22..7eb385d67d 100644 --- a/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-3/_config.js +++ b/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-3/_config.js @@ -2,7 +2,6 @@ import { tick } from 'svelte'; import { test } from '../../test'; export default test({ - skip: true, // TODO works on https://github.com/sveltejs/svelte/pull/17971 async test({ assert, target }) { await tick(); const [a_b, a_c, b_d, shift, pop] = target.querySelectorAll('button'); @@ -82,7 +81,7 @@ export default test({ assert.htmlEqual( target.innerHTML, ` - a 1 | b 2 | c 0 | d 1 + a 0 | b 0 | c 0 | d 0 diff --git a/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-4/_config.js b/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-4/_config.js index 472a3ebcaf..7a58595fe9 100644 --- a/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-4/_config.js +++ b/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-4/_config.js @@ -2,7 +2,6 @@ import { tick } from 'svelte'; import { test } from '../../test'; export default test({ - skip: true, // TODO works on https://github.com/sveltejs/svelte/pull/17971 async test({ assert, target }) { await tick(); const [a_b, a_c, b_d, shift, pop] = target.querySelectorAll('button'); @@ -78,13 +77,11 @@ export default test({ ); pop.click(); // second a resolved, first a/b now obsolete - // TODO would be nice to show final result here already, right now it doesn't because - // we have no handle on the already resolved first a anymore await tick(); assert.htmlEqual( target.innerHTML, ` - a 0 | b 0 | c 0 | d 0 + a 2 | b 2 | c 1 | d 1 diff --git a/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-fork-3/_config.js b/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-fork-3/_config.js index 61360d8dc9..fd7bc40eed 100644 --- a/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-fork-3/_config.js +++ b/packages/svelte/tests/runtime-runes/samples/async-overlap-multiple-fork-3/_config.js @@ -2,7 +2,6 @@ import { tick } from 'svelte'; import { test } from '../../test'; export default test({ - skip: true, async test({ assert, target }) { await tick(); const [a_b_fork, a_c, b_d, shift, pop, commit] = target.querySelectorAll('button'); diff --git a/packages/svelte/tests/runtime-runes/samples/async-stale-derived-2/_config.js b/packages/svelte/tests/runtime-runes/samples/async-stale-derived-2/_config.js index 8276c5be41..71fdc1fa64 100644 --- a/packages/svelte/tests/runtime-runes/samples/async-stale-derived-2/_config.js +++ b/packages/svelte/tests/runtime-runes/samples/async-stale-derived-2/_config.js @@ -2,7 +2,7 @@ import { tick } from 'svelte'; import { test } from '../../test'; export default test({ - skip: true, // TODO this one is tricky + skip: true, // TODO this one is tricky; are the assertions actually correct still? why don't we need two b.click()s at the end? (if so the test passes) async test({ assert, target }) { const [increment, a, b] = target.querySelectorAll('button'); diff --git a/packages/svelte/tests/runtime-runes/samples/async-state-new-branch-fork-1/_config.js b/packages/svelte/tests/runtime-runes/samples/async-state-new-branch-fork-1/_config.js index 737169cb91..2a671cb483 100644 --- a/packages/svelte/tests/runtime-runes/samples/async-state-new-branch-fork-1/_config.js +++ b/packages/svelte/tests/runtime-runes/samples/async-state-new-branch-fork-1/_config.js @@ -2,7 +2,6 @@ import { tick } from 'svelte'; import { test } from '../../test'; export default test({ - skip: true, // TODO works on https://github.com/sveltejs/svelte/pull/17971 async test({ assert, target }) { const [x, y, shift, pop, commit] = target.querySelectorAll('button'); @@ -37,6 +36,7 @@ export default test({ ` ); + // commit entangled fork with existing batch, so nothing happens yet shift.click(); await tick(); assert.htmlEqual( @@ -47,13 +47,6 @@ export default test({ - universe - universe - "universe" - universe - universe - universe - "universe"
` );