diff --git a/src/compiler/compile/render_dom/Block.ts b/src/compiler/compile/render_dom/Block.ts index 91e326d98c..f864dc2246 100644 --- a/src/compiler/compile/render_dom/Block.ts +++ b/src/compiler/compile/render_dom/Block.ts @@ -234,17 +234,14 @@ export default class Block { get_contents(key?: any) { const { dev } = this.renderer.options; - if (this.has_outros) { + if (this.has_outros || this.has_intros) { this.add_variable({ type: 'Identifier', name: '#current' }); - if (this.chunks.intro.length > 0) { - this.chunks.intro.push(b`#current = true;`); - this.chunks.mount.push(b`#current = true;`); - } + this.chunks.intro.push(b`#current = true;`); + this.chunks.mount.push(b`#current = true;`); + - if (this.chunks.outro.length > 0) { - this.chunks.outro.push(b`#current = false;`); - } + this.chunks.outro.push(b`#current = false;`); } if (this.autofocus) { @@ -345,7 +342,7 @@ export default class Block { properties.intro = noop; } else { properties.intro = x`function #intro(#local) { - ${this.has_outros && b`if (#current) return;`} + ${b`if (#current) return;`} ${this.chunks.intro} }`; } diff --git a/src/compiler/compile/render_dom/wrappers/Element/index.ts b/src/compiler/compile/render_dom/wrappers/Element/index.ts index 131d17cf33..77555299ec 100644 --- a/src/compiler/compile/render_dom/wrappers/Element/index.ts +++ b/src/compiler/compile/render_dom/wrappers/Element/index.ts @@ -744,10 +744,14 @@ export default class ElementWrapper extends Wrapper { const snippet = intro.expression ? intro.expression.manipulate(block) : null; const fn = this.renderer.reference(intro.name); + block.add_variable(transition); - block.chunks.create.push(b`${transition} = @create_bidirectional_transition(${this.var}, ${fn}, ${snippet})`) - - + block.chunks.mount.push(b`if (!${transition}) ${transition} = @create_bidirectional_transition(${this.var}, ${fn}, ${snippet});`); + block.chunks.hydrate.push(b`if (!${transition}) ${transition} = @create_bidirectional_transition(${this.var}, ${fn}, ${snippet});`); + if (intro.expression) { + const dirty = block.renderer.dirty([intro.name,...Array.from(intro.expression.dependencies)]); + block.chunks.update.push(b`if (${dirty}) ${transition}.u(${fn}, ${snippet});`); + } let intro_block = b`${transition}.i();`; let outro_block = b`${transition}.o();`; @@ -758,7 +762,7 @@ export default class ElementWrapper extends Wrapper { block.chunks.intro.push(intro_block); block.chunks.outro.push(outro_block); - block.chunks.destroy.push(b`if (detaching) ${transition}.d();`); + block.chunks.destroy.push(b`if (detaching && ${transition}) ${transition}.d();`); } add_intro(block: Block, intro: Transition, outro: Transition) { if (outro) { @@ -766,47 +770,43 @@ export default class ElementWrapper extends Wrapper { block.chunks.intro.push(b`${outro_var}(1);`); } if (this.node.animation) { - const [unfreeze_var, rect_var, stop_animation_var, animationFn, params] = run_animation(this, block); + const [unfreeze_var] = run_animation(this, block); block.chunks.intro.push(b` if (${unfreeze_var}) { ${unfreeze_var}(); ${unfreeze_var} = void 0; - ${stop_animation_var} = @run_animation(${this.var}, ${rect_var}, ${animationFn}, ${params}); } `); } if (!intro) return; const [intro_var, node, transitionFn, params] = run_transition(this, block, intro, `intro`); - block.add_variable(intro_var, outro ? x`@noop`: null); + block.add_variable(intro_var, x`@noop`); - let start_intro = b`${intro_var} = @run_in(${node}, ${transitionFn}, ${params}, this);`; - if (!outro) start_intro = b`if (!${intro_var}) { ${start_intro} }`; + let start_intro = b` + ${intro_var}(); + ${intro_var} = @run_in(${node}, ${transitionFn}, ${params}); + `; if (intro.is_local) start_intro = b`if (#local) { ${start_intro} }`; block.chunks.intro.push(start_intro); } // TODO // hide elements that have outro'd prior to their removal from the DOM // ( ...unless they belong to a still-outroing group ) - add_outro(block: Block, intro: Transition, outro: Transition) { - if (intro) { - const intro_var = block.alias(`${this.var.name}_intro`); - block.chunks.outro.push(b`${intro_var}();`); - } + add_outro(block: Block, _intro: Transition, outro: Transition) { if (!outro) return; const [outro_var, node, transitionFn, params] = run_transition(this, block, outro, `outro`); block.add_variable(outro_var, x`@noop`); - let start_outro = b`${outro_var} = @run_out(${node}, ${transitionFn}, ${params}, this);`; + let start_outro = b`${outro_var} = @run_out(${node}, ${transitionFn}, ${params});`; if (outro.is_local) start_outro = b`if (#local) { ${start_outro} }`; block.chunks.outro.push(start_outro); block.chunks.destroy.push(b`if (detaching) ${outro_var}();`); } - add_animation(block: Block, intro: Transition) { - const intro_var = intro && block.alias(`${this.var.name}_intro`); + add_animation(block: Block) { const [unfreeze_var, rect_var, stop_animation_var, name_var, params_var] = run_animation(this, block); @@ -816,7 +816,6 @@ export default class ElementWrapper extends Wrapper { block.chunks.measure.push(b` ${rect_var} = ${this.var}.getBoundingClientRect(); - ${intro && b`${intro_var}();`} `); block.chunks.fix.push(b` diff --git a/src/runtime/internal/loop.ts b/src/runtime/internal/loop.ts index bdecd318cc..f745b55ee3 100644 --- a/src/runtime/internal/loop.ts +++ b/src/runtime/internal/loop.ts @@ -9,23 +9,23 @@ export const frame = { }, }; -function calc_framerate() { - raf((t1) => { - raf((t2) => { - const delta = t2 - t1; - raf((t3) => { - if (Math.abs(t3 - t2 - delta) > 1) { - calc_framerate(); - } else { - const f24 = 1000 / 24; - const f144 = 1000 / 144; - frame.rate = delta > f144 ? f144 : delta < f24 ? f24 : delta; - } - }); - }); - }); -} -calc_framerate(); +// function calc_framerate() { +// raf((t1) => { +// raf((t2) => { +// const delta = t2 - t1; +// raf((t3) => { +// if (Math.abs(t3 - t2 - delta) > 1) { +// calc_framerate(); +// } else { +// const f24 = 1000 / 24; +// const f144 = 1000 / 144; +// frame.rate = delta > f144 ? f144 : delta < f24 ? f24 : delta; +// } +// }); +// }); +// }); +// } +// calc_framerate(); type TaskCallback = (t: number) => boolean; type TaskCanceller = () => void; diff --git a/src/runtime/internal/style_manager.ts b/src/runtime/internal/style_manager.ts index 8090417c02..a98ad9221c 100644 --- a/src/runtime/internal/style_manager.ts +++ b/src/runtime/internal/style_manager.ts @@ -34,7 +34,6 @@ export const animate_css = /*#__PURE__*/ methodify( } const previous = this.style.animation; - if (previous) {console.error("stacked animations"); return noop} this.style.animation = `${ previous ? `${previous}, ` : '' }${duration}ms linear ${delay}ms 1 normal both running ${name}`; diff --git a/src/runtime/internal/transitions.ts b/src/runtime/internal/transitions.ts index 3eb64bc6ee..554704457a 100644 --- a/src/runtime/internal/transitions.ts +++ b/src/runtime/internal/transitions.ts @@ -123,6 +123,7 @@ export const run_animation = /*#__PURE__*/ methodify(function (this: HTMLElement const end_time = current_frame_time + delay + duration; const runner = (fn) => reversed(fn, true, easing); if (css) cancel_css = animate_css(this, runner(css), duration, delay); + if (tick) tick(0, 1); cancel_raf = tick ? setTweenTimeout(stop, end_time, runner(tick), duration) : setFrameTimeout(stop, end_time); }; }); @@ -324,7 +325,7 @@ export const create_bidirectional_transition = /*#__PURE__*/ methodify(function( prev = prev ? prev(-1) : run_transition(true); }, d() { - prev = prev(1); + if (prev) prev(1); } } }); diff --git a/test/js/samples/each-block-keyed-animated/expected.js b/test/js/samples/each-block-keyed-animated/expected.js index 24dfd5465a..f25b4cd57e 100644 --- a/test/js/samples/each-block-keyed-animated/expected.js +++ b/test/js/samples/each-block-keyed-animated/expected.js @@ -54,7 +54,7 @@ function create_each_block(key_1, ctx) { unfreeze = fix_position(div, rect); }, a() { - if (unfreeze) return; else { + if (unfreeze || !rect) return; else { stop_animation(); stop_animation = run_animation(div, rect, foo); } diff --git a/test/js/samples/transition-local/expected.js b/test/js/samples/transition-local/expected.js index 30d31805ef..5d4bde5ae2 100644 --- a/test/js/samples/transition-local/expected.js +++ b/test/js/samples/transition-local/expected.js @@ -7,7 +7,7 @@ import { init, insert, noop, - run_transition, + run_in, safe_not_equal, transition_in } from "svelte/internal"; @@ -52,7 +52,8 @@ function create_if_block(ctx) { // (9:1) {#if y} function create_if_block_1(ctx) { let div; - let div_intro; + let div_intro = noop; + let current; return { c() { @@ -61,16 +62,20 @@ function create_if_block_1(ctx) { }, m(target, anchor) { insert(target, div, anchor); + current = true; }, i(local) { + if (current) return; + if (local) { - if (!div_intro) { - div_intro = run_transition(div, foo, 1); - } + div_intro(); + div_intro = run_in(div, foo); } + + current = true; }, o(local) { - div_intro(); + current = false; }, d(detaching) { if (detaching) detach(div); diff --git a/test/js/samples/transition-repeated-outro/expected.js b/test/js/samples/transition-repeated-outro/expected.js index 02febde2af..93b5dab54d 100644 --- a/test/js/samples/transition-repeated-outro/expected.js +++ b/test/js/samples/transition-repeated-outro/expected.js @@ -8,7 +8,7 @@ import { init, insert, noop, - run_transition, + run_out, safe_not_equal, transition_in, transition_out @@ -36,7 +36,7 @@ function create_if_block(ctx) { current = true; }, o(local) { - div_outro = run_transition(div, fade, 2); + div_outro = run_out(div, fade); current = false; }, d(detaching) { diff --git a/test/runtime/index.js b/test/runtime/index.js index 65157196c9..3aeab126f9 100644 --- a/test/runtime/index.js +++ b/test/runtime/index.js @@ -243,7 +243,7 @@ describe("runtime", () => { }); } - fs.readdirSync(`${__dirname}/samples`).forEach(dir => { + fs.readdirSync(`${__dirname}/samples`).reverse().forEach(dir => { runTest(dir, false); runTest(dir, true); }); diff --git a/test/runtime/samples/transition-css-in-out-in/_config.js b/test/runtime/samples/transition-css-in-out-in/_config.js index 3142716877..138bef9763 100644 --- a/test/runtime/samples/transition-css-in-out-in/_config.js +++ b/test/runtime/samples/transition-css-in-out-in/_config.js @@ -2,15 +2,20 @@ export default { test({ assert, component, target, window, raf }) { component.visible = true; const div = target.querySelector('div'); - const startsWith = (str) => - assert.equal(div.style.animation.slice(0, div.style.animation.length-1), str); + const startsWith = (v, t = div.style.animation) => { + if (Array.isArray(v)) { + t.split(", ").forEach((r,i)=>startsWith(v[i],r)) + } else { + assert.equal(t.slice(0, -1), v); + } + } startsWith(`100ms linear 0ms 1 normal both running __svelte_3261048502`); raf.tick(50); component.visible = false; - startsWith(`100ms linear 0ms 1 normal both running __svelte_890840093`); + startsWith([`100ms linear 0ms 1 normal both running __svelte_3261048502`, `100ms linear 0ms 1 normal both running __svelte_890840093`]); raf.tick(75); component.visible = true; diff --git a/test/runtime/samples/transition-js-args/_config.js b/test/runtime/samples/transition-js-args/_config.js index 00682894cd..1999f0d54f 100644 --- a/test/runtime/samples/transition-js-args/_config.js +++ b/test/runtime/samples/transition-js-args/_config.js @@ -4,9 +4,6 @@ export default { const div = target.querySelector('div'); - assert.equal(div.foo, 0); - assert.equal(div.oof, 1); - raf.tick(50); assert.equal(div.foo, 0.5); assert.equal(div.oof, 0.5); diff --git a/test/runtime/samples/transition-js-await-block/_config.js b/test/runtime/samples/transition-js-await-block/_config.js index d019c062d6..5da109748e 100644 --- a/test/runtime/samples/transition-js-await-block/_config.js +++ b/test/runtime/samples/transition-js-await-block/_config.js @@ -17,8 +17,7 @@ export default { const p = target.querySelector('p'); assert.equal(p.className, 'pending'); - assert.equal(p.foo, 0); - + raf.tick(50); assert.equal(p.foo, 0.5); diff --git a/test/runtime/samples/transition-js-context/_config.js b/test/runtime/samples/transition-js-context/_config.js index e2e7135180..823762ef37 100644 --- a/test/runtime/samples/transition-js-context/_config.js +++ b/test/runtime/samples/transition-js-context/_config.js @@ -3,8 +3,7 @@ export default { component.visible = true; const div = target.querySelector('div'); - assert.equal(div.foo, 42); - + raf.tick(50); assert.equal(div.foo, 42); } diff --git a/test/runtime/samples/transition-js-deferred-b/_config.js b/test/runtime/samples/transition-js-deferred-b/_config.js index 05929964cd..3b435d91f9 100644 --- a/test/runtime/samples/transition-js-deferred-b/_config.js +++ b/test/runtime/samples/transition-js-deferred-b/_config.js @@ -4,8 +4,7 @@ export default { return Promise.resolve().then(() => { const div = target.querySelector('.foo'); - assert.equal(div.foo, 0); - + raf.tick(50); assert.equal(div.foo, 0.5); }); diff --git a/test/runtime/samples/transition-js-deferred/_config.js b/test/runtime/samples/transition-js-deferred/_config.js index 05929964cd..b534aa4cbb 100644 --- a/test/runtime/samples/transition-js-deferred/_config.js +++ b/test/runtime/samples/transition-js-deferred/_config.js @@ -4,7 +4,6 @@ export default { return Promise.resolve().then(() => { const div = target.querySelector('.foo'); - assert.equal(div.foo, 0); raf.tick(50); assert.equal(div.foo, 0.5); diff --git a/test/runtime/samples/transition-js-deferred/main.svelte b/test/runtime/samples/transition-js-deferred/main.svelte index eb75f3a7e3..0297ced7be 100644 --- a/test/runtime/samples/transition-js-deferred/main.svelte +++ b/test/runtime/samples/transition-js-deferred/main.svelte @@ -7,9 +7,9 @@ function foo(node, params) { foo_text = node.textContent; - return () => { + return (is_intro) => { if (bar_text !== `b`) { - throw new Error(`foo ran prematurely`); + if (is_intro != null) throw new Error(`foo ran prematurely`); } return { @@ -24,9 +24,9 @@ function bar(node, params) { bar_text = node.textContent; - return () => { + return (is_intro) => { if (foo_text !== `a`) { - throw new Error(`bar ran prematurely`); + if (is_intro != null) throw new Error(`bar ran prematurely`); } return { diff --git a/test/runtime/samples/transition-js-delay-in-out/_config.js b/test/runtime/samples/transition-js-delay-in-out/_config.js index fb77fca015..ba3df07de2 100644 --- a/test/runtime/samples/transition-js-delay-in-out/_config.js +++ b/test/runtime/samples/transition-js-delay-in-out/_config.js @@ -2,7 +2,6 @@ export default { test({ assert, component, target, window, raf }) { component.visible = true; const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(50); assert.equal(div.foo, 0); diff --git a/test/runtime/samples/transition-js-delay/_config.js b/test/runtime/samples/transition-js-delay/_config.js index 43d7cf5b2a..710a616dc6 100644 --- a/test/runtime/samples/transition-js-delay/_config.js +++ b/test/runtime/samples/transition-js-delay/_config.js @@ -2,7 +2,6 @@ export default { test({ assert, component, target, window, raf }) { component.visible = true; const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(50); assert.equal(div.foo, 0); @@ -13,9 +12,15 @@ export default { component.visible = false; raf.tick(125); - assert.equal(div.foo, 0.25); + assert.equal(div.foo, 0.75); raf.tick(150); + assert.equal(div.foo, 1); + + raf.tick(175); + assert.equal(div.foo, 0.75); + + raf.tick(250); assert.equal(div.foo, 0); } }; \ No newline at end of file diff --git a/test/runtime/samples/transition-js-dynamic-if-block-bidi/_config.js b/test/runtime/samples/transition-js-dynamic-if-block-bidi/_config.js index aa0bd9e1aa..7cffe51d6d 100644 --- a/test/runtime/samples/transition-js-dynamic-if-block-bidi/_config.js +++ b/test/runtime/samples/transition-js-dynamic-if-block-bidi/_config.js @@ -7,9 +7,8 @@ export default { global.count = 0; component.visible = true; - assert.equal(global.count, 1); + assert.equal(global.count, 2); const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(75); component.name = 'everybody'; diff --git a/test/runtime/samples/transition-js-each-block-intro-outro/_config.js b/test/runtime/samples/transition-js-each-block-intro-outro/_config.js index b3cb9b0977..2fd6b3075c 100644 --- a/test/runtime/samples/transition-js-each-block-intro-outro/_config.js +++ b/test/runtime/samples/transition-js-each-block-intro-outro/_config.js @@ -7,9 +7,6 @@ export default { test({ assert, component, target, window, raf }) { component.visible = true; const divs = target.querySelectorAll('div'); - assert.equal(divs[0].foo, 0); - assert.equal(divs[1].foo, 0); - assert.equal(divs[2].foo, 0); raf.tick(50); assert.equal(divs[0].foo, 0.5); @@ -19,9 +16,9 @@ export default { component.visible = false; raf.tick(70); - assert.equal(divs[0].foo, 0.5); - assert.equal(divs[1].foo, 0.5); - assert.equal(divs[2].foo, 0.5); + assert.equal(divs[0].foo, 0.7); + assert.equal(divs[1].foo, 0.7); + assert.equal(divs[2].foo, 0.7); assert.equal(divs[0].bar, 0.8); assert.equal(divs[1].bar, 0.8); diff --git a/test/runtime/samples/transition-js-each-block-intro/_config.js b/test/runtime/samples/transition-js-each-block-intro/_config.js index 3d143ea514..d7b5abf8cf 100644 --- a/test/runtime/samples/transition-js-each-block-intro/_config.js +++ b/test/runtime/samples/transition-js-each-block-intro/_config.js @@ -7,9 +7,6 @@ export default { test({ assert, component, target, window, raf }) { let divs = target.querySelectorAll('div'); - assert.equal(divs[0].foo, 0); - assert.equal(divs[1].foo, 0); - assert.equal(divs[2].foo, 0); raf.tick(50); assert.equal(divs[0].foo, 0.5); @@ -21,7 +18,6 @@ export default { assert.equal(divs[0].foo, 0.5); assert.equal(divs[1].foo, 0.5); assert.equal(divs[2].foo, 0.5); - assert.equal(divs[3].foo, 0); raf.tick(75); assert.equal(divs[0].foo, 0.75); diff --git a/test/runtime/samples/transition-js-each-block-keyed-intro-outro/_config.js b/test/runtime/samples/transition-js-each-block-keyed-intro-outro/_config.js index 083752cbd9..95c3b59bd2 100644 --- a/test/runtime/samples/transition-js-each-block-keyed-intro-outro/_config.js +++ b/test/runtime/samples/transition-js-each-block-keyed-intro-outro/_config.js @@ -15,9 +15,6 @@ export default { divs[1].i = 1; divs[2].i = 2; - assert.equal(divs[0].foo, 0); - assert.equal(divs[1].foo, 0); - assert.equal(divs[2].foo, 0); raf.tick(100); assert.equal(divs[0].foo, 1); diff --git a/test/runtime/samples/transition-js-each-block-keyed-intro/_config.js b/test/runtime/samples/transition-js-each-block-keyed-intro/_config.js index 5886cc5c6f..d65b2343c4 100644 --- a/test/runtime/samples/transition-js-each-block-keyed-intro/_config.js +++ b/test/runtime/samples/transition-js-each-block-keyed-intro/_config.js @@ -11,9 +11,6 @@ export default { test({ assert, component, target, window, raf }) { let divs = target.querySelectorAll('div'); - assert.equal(divs[0].foo, 0); - assert.equal(divs[1].foo, 0); - assert.equal(divs[2].foo, 0); raf.tick(50); assert.equal(divs[0].foo, 0.5); @@ -34,7 +31,6 @@ export default { `); divs = target.querySelectorAll('div'); assert.equal(divs[0].foo, 0.5); - assert.equal(divs[1].foo, 0); assert.equal(divs[2].foo, 0.5); assert.equal(divs[3].foo, 0.5); diff --git a/test/runtime/samples/transition-js-if-block-bidi/_config.js b/test/runtime/samples/transition-js-if-block-bidi/_config.js index a070f978e2..3201c933b9 100644 --- a/test/runtime/samples/transition-js-if-block-bidi/_config.js +++ b/test/runtime/samples/transition-js-if-block-bidi/_config.js @@ -3,15 +3,14 @@ export default { global.count = 0; component.visible = true; - assert.equal(global.count, 1); + assert.equal(global.count, 2); const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(300); assert.equal(div.foo, 0.75); component.visible = false; - assert.equal(global.count, 1); + assert.equal(global.count, 3); raf.tick(500); assert.equal(div.foo, 0.25); diff --git a/test/runtime/samples/transition-js-if-block-in-each-block-bidi/_config.js b/test/runtime/samples/transition-js-if-block-in-each-block-bidi/_config.js index 4c75e3ef06..f5469b045b 100644 --- a/test/runtime/samples/transition-js-if-block-in-each-block-bidi/_config.js +++ b/test/runtime/samples/transition-js-if-block-in-each-block-bidi/_config.js @@ -16,7 +16,6 @@ export default { test({ assert, component, target, window, raf }) { const divs = target.querySelectorAll('div'); - assert.equal(divs[0].foo, 0); raf.tick(100); assert.equal(divs[0].foo, 1); diff --git a/test/runtime/samples/transition-js-if-block-intro-outro/_config.js b/test/runtime/samples/transition-js-if-block-intro-outro/_config.js index edf7438d27..e59cb01536 100644 --- a/test/runtime/samples/transition-js-if-block-intro-outro/_config.js +++ b/test/runtime/samples/transition-js-if-block-intro-outro/_config.js @@ -2,7 +2,6 @@ export default { test({ assert, component, target, window, raf }) { component.visible = true; let div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(200); assert.equal(div.foo, 0.5); @@ -32,11 +31,11 @@ export default { component.visible = false; raf.tick(1300); - assert.equal(div.foo, 0.5); + assert.equal(div.foo, 0.75); assert.equal(div.bar, 0.75); raf.tick(1400); - assert.equal(div.foo, 0.5); + assert.equal(div.foo, 1); assert.equal(div.bar, 0.5); raf.tick(2000); diff --git a/test/runtime/samples/transition-js-if-else-block-intro/_config.js b/test/runtime/samples/transition-js-if-else-block-intro/_config.js index c5eccf50e5..45d4b5934f 100644 --- a/test/runtime/samples/transition-js-if-else-block-intro/_config.js +++ b/test/runtime/samples/transition-js-if-else-block-intro/_config.js @@ -3,7 +3,6 @@ export default { test({ assert, component, target, raf }) { assert.equal(target.querySelector('div'), component.no); - assert.equal(component.no.foo, 0); raf.tick(200); assert.equal(component.no.foo, 0.5); @@ -11,7 +10,6 @@ export default { raf.tick(500); component.x = true; assert.equal(component.no, undefined); - assert.equal(component.yes.foo, 0); raf.tick(700); assert.equal(component.yes.foo, 0.5); diff --git a/test/runtime/samples/transition-js-initial/_config.js b/test/runtime/samples/transition-js-initial/_config.js index 3760a1cbfb..9ed39aead3 100644 --- a/test/runtime/samples/transition-js-initial/_config.js +++ b/test/runtime/samples/transition-js-initial/_config.js @@ -3,7 +3,6 @@ export default { component.visible = true; const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(50); assert.equal(div.foo, 0.5); diff --git a/test/runtime/samples/transition-js-intro-enabled-by-option/_config.js b/test/runtime/samples/transition-js-intro-enabled-by-option/_config.js index 4b5f1cf987..820a26800b 100644 --- a/test/runtime/samples/transition-js-intro-enabled-by-option/_config.js +++ b/test/runtime/samples/transition-js-intro-enabled-by-option/_config.js @@ -5,7 +5,6 @@ export default { test({ assert, component, target, window, raf }) { const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(50); assert.equal(div.foo, 0.5); diff --git a/test/runtime/samples/transition-js-local-and-global/_config.js b/test/runtime/samples/transition-js-local-and-global/_config.js index b7f8baa7ee..c10dc89d02 100644 --- a/test/runtime/samples/transition-js-local-and-global/_config.js +++ b/test/runtime/samples/transition-js-local-and-global/_config.js @@ -11,7 +11,6 @@ export default { let divs = target.querySelectorAll('div'); assert.equal(divs[0].foo, undefined); - assert.equal(divs[1].foo, 0); raf.tick(50); assert.equal(divs[0].foo, undefined); diff --git a/test/runtime/samples/transition-js-local-nested-await/_config.js b/test/runtime/samples/transition-js-local-nested-await/_config.js index b07d88741f..8add2a2080 100644 --- a/test/runtime/samples/transition-js-local-nested-await/_config.js +++ b/test/runtime/samples/transition-js-local-nested-await/_config.js @@ -16,7 +16,6 @@ export default { return promise.then(() => { const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(100); assert.equal(div.foo, 1); diff --git a/test/runtime/samples/transition-js-local-nested-component/_config.js b/test/runtime/samples/transition-js-local-nested-component/_config.js index 87d7aaa233..606b9f35ef 100644 --- a/test/runtime/samples/transition-js-local-nested-component/_config.js +++ b/test/runtime/samples/transition-js-local-nested-component/_config.js @@ -7,7 +7,6 @@ export default { component.x = true; const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(100); assert.equal(div.foo, 1); diff --git a/test/runtime/samples/transition-js-local-nested-each-keyed/_config.js b/test/runtime/samples/transition-js-local-nested-each-keyed/_config.js index 0595e67013..85b9442261 100644 --- a/test/runtime/samples/transition-js-local-nested-each-keyed/_config.js +++ b/test/runtime/samples/transition-js-local-nested-each-keyed/_config.js @@ -18,7 +18,6 @@ export default { const div2 = target.querySelector('div:last-child'); assert.equal(div1.foo, undefined); - assert.equal(div2.foo, 0); raf.tick(200); assert.equal(div1.foo, undefined); diff --git a/test/runtime/samples/transition-js-local-nested-each/_config.js b/test/runtime/samples/transition-js-local-nested-each/_config.js index 0595e67013..85b9442261 100644 --- a/test/runtime/samples/transition-js-local-nested-each/_config.js +++ b/test/runtime/samples/transition-js-local-nested-each/_config.js @@ -18,7 +18,6 @@ export default { const div2 = target.querySelector('div:last-child'); assert.equal(div1.foo, undefined); - assert.equal(div2.foo, 0); raf.tick(200); assert.equal(div1.foo, undefined); diff --git a/test/runtime/samples/transition-js-nested-await/_config.js b/test/runtime/samples/transition-js-nested-await/_config.js index 78dbe5ae41..637f37ca2b 100644 --- a/test/runtime/samples/transition-js-nested-await/_config.js +++ b/test/runtime/samples/transition-js-nested-await/_config.js @@ -16,7 +16,6 @@ export default { return promise.then(() => { const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(100); assert.equal(div.foo, 1); diff --git a/test/runtime/samples/transition-js-nested-component/_config.js b/test/runtime/samples/transition-js-nested-component/_config.js index f1ca81c52e..7bdc49e2dc 100644 --- a/test/runtime/samples/transition-js-nested-component/_config.js +++ b/test/runtime/samples/transition-js-nested-component/_config.js @@ -7,7 +7,6 @@ export default { component.x = true; const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(100); assert.equal(div.foo, 1); diff --git a/test/runtime/samples/transition-js-nested-each-keyed/_config.js b/test/runtime/samples/transition-js-nested-each-keyed/_config.js index 3d2fe3c32e..9226e47eee 100644 --- a/test/runtime/samples/transition-js-nested-each-keyed/_config.js +++ b/test/runtime/samples/transition-js-nested-each-keyed/_config.js @@ -8,7 +8,6 @@ export default { component.x = true; const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(100); assert.equal(div.foo, 1); diff --git a/test/runtime/samples/transition-js-nested-each/_config.js b/test/runtime/samples/transition-js-nested-each/_config.js index c21024dd69..0d3a393e9b 100644 --- a/test/runtime/samples/transition-js-nested-each/_config.js +++ b/test/runtime/samples/transition-js-nested-each/_config.js @@ -8,7 +8,6 @@ export default { component.x = true; const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(100); assert.equal(div.foo, 1); diff --git a/test/runtime/samples/transition-js-nested-if/_config.js b/test/runtime/samples/transition-js-nested-if/_config.js index 2fdd17da93..93b624dfa8 100644 --- a/test/runtime/samples/transition-js-nested-if/_config.js +++ b/test/runtime/samples/transition-js-nested-if/_config.js @@ -8,7 +8,6 @@ export default { component.x = true; const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(100); assert.equal(div.foo, 1); diff --git a/test/runtime/samples/transition-js-nested-intro/_config.js b/test/runtime/samples/transition-js-nested-intro/_config.js index 9072e885fc..95d2775d50 100644 --- a/test/runtime/samples/transition-js-nested-intro/_config.js +++ b/test/runtime/samples/transition-js-nested-intro/_config.js @@ -2,7 +2,6 @@ export default { test({ assert, component, target, window, raf }) { component.visible = true; const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(50); assert.equal(div.foo, 0); diff --git a/test/runtime/samples/transition-js-parameterised-with-state/_config.js b/test/runtime/samples/transition-js-parameterised-with-state/_config.js index 64e40dc63d..c7988fce9f 100644 --- a/test/runtime/samples/transition-js-parameterised-with-state/_config.js +++ b/test/runtime/samples/transition-js-parameterised-with-state/_config.js @@ -6,7 +6,6 @@ export default { test({ assert, component, target, window, raf }) { component.visible = true; const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(50); assert.equal(div.foo, 100); diff --git a/test/runtime/samples/transition-js-parameterised/_config.js b/test/runtime/samples/transition-js-parameterised/_config.js index 1370905547..851c714a71 100644 --- a/test/runtime/samples/transition-js-parameterised/_config.js +++ b/test/runtime/samples/transition-js-parameterised/_config.js @@ -2,7 +2,6 @@ export default { test({ assert, component, target, window, raf }) { component.visible = true; const div = target.querySelector('div'); - assert.equal(div.foo, 0); raf.tick(50); assert.equal(div.foo, 100); diff --git a/test/runtime/samples/transition-js-slot/_config.js b/test/runtime/samples/transition-js-slot/_config.js index a32e4bda72..1af9e25d33 100644 --- a/test/runtime/samples/transition-js-slot/_config.js +++ b/test/runtime/samples/transition-js-slot/_config.js @@ -10,7 +10,6 @@ export default { test({ assert, component, target, window, raf }) { component.visible = true; const p = target.querySelector('p'); - assert.equal(p.foo, 0); raf.tick(50); assert.equal(p.foo, 0.5);