From b47ba90664558c97ae532eb26136de58d3dd06c1 Mon Sep 17 00:00:00 2001 From: Simon H <5968653+dummdidumm@users.noreply.github.com> Date: Wed, 18 Feb 2026 13:35:49 +0100 Subject: [PATCH] add as _comments to legacy ast --- packages/svelte/src/compiler/legacy.js | 6 +++++- .../parser-legacy/samples/javascript-comments/output.json | 2 +- .../parser-legacy/samples/script-comment-only/output.json | 2 +- 3 files changed, 7 insertions(+), 3 deletions(-) diff --git a/packages/svelte/src/compiler/legacy.js b/packages/svelte/src/compiler/legacy.js index bb040c9c1a..459858fe13 100644 --- a/packages/svelte/src/compiler/legacy.js +++ b/packages/svelte/src/compiler/legacy.js @@ -102,7 +102,11 @@ export function convert(source, ast) { instance, module, css: ast.css ? visit(ast.css) : undefined, - comments: ast.comments?.length > 0 ? ast.comments : undefined + // put it on _comments not comments because the latter is checked by prettier and then fails + // if we don't adjust stuff accordingly in our prettier plugin, and so it would be kind of an + // indirect breaking change for people updating their Svelte version but not their prettier plugin version. + // We can keep it as comments for the modern AST because the modern AST is not used in the plugin yet. + _comments: ast.comments?.length > 0 ? ast.comments : undefined }; }, AnimateDirective(node) { diff --git a/packages/svelte/tests/parser-legacy/samples/javascript-comments/output.json b/packages/svelte/tests/parser-legacy/samples/javascript-comments/output.json index 97afe8249d..4d7cb2397f 100644 --- a/packages/svelte/tests/parser-legacy/samples/javascript-comments/output.json +++ b/packages/svelte/tests/parser-legacy/samples/javascript-comments/output.json @@ -881,7 +881,7 @@ "sourceType": "module" } }, - "comments": [ + "_comments": [ { "type": "Line", "value": " a leading comment", diff --git a/packages/svelte/tests/parser-legacy/samples/script-comment-only/output.json b/packages/svelte/tests/parser-legacy/samples/script-comment-only/output.json index 362979da4d..8ec0e0cd65 100644 --- a/packages/svelte/tests/parser-legacy/samples/script-comment-only/output.json +++ b/packages/svelte/tests/parser-legacy/samples/script-comment-only/output.json @@ -52,7 +52,7 @@ ] } }, - "comments": [ + "_comments": [ { "type": "Line", "value": " TODO write some code",