From ad846db643c1d9074ce008feff6d84f8b3b34437 Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Tue, 20 May 2025 09:20:33 -0400 Subject: [PATCH] separate tests for parent/sibling case --- .../implicitly-closed-by-parent/input.svelte | 6 +++++ .../warnings.json | 18 ++++++------- .../implicitly-closed-by-sibling/input.svelte | 9 +++++++ .../warnings.json | 26 +++++++++++++++++++ .../implicitly-closed-tag/input.svelte | 6 ----- 5 files changed, 50 insertions(+), 15 deletions(-) create mode 100644 packages/svelte/tests/validator/samples/implicitly-closed-by-parent/input.svelte rename packages/svelte/tests/validator/samples/{implicitly-closed-tag => implicitly-closed-by-parent}/warnings.json (58%) create mode 100644 packages/svelte/tests/validator/samples/implicitly-closed-by-sibling/input.svelte create mode 100644 packages/svelte/tests/validator/samples/implicitly-closed-by-sibling/warnings.json delete mode 100644 packages/svelte/tests/validator/samples/implicitly-closed-tag/input.svelte diff --git a/packages/svelte/tests/validator/samples/implicitly-closed-by-parent/input.svelte b/packages/svelte/tests/validator/samples/implicitly-closed-by-parent/input.svelte new file mode 100644 index 0000000000..f67eba18b8 --- /dev/null +++ b/packages/svelte/tests/validator/samples/implicitly-closed-by-parent/input.svelte @@ -0,0 +1,6 @@ +
+ +
+
+

hello

+
diff --git a/packages/svelte/tests/validator/samples/implicitly-closed-tag/warnings.json b/packages/svelte/tests/validator/samples/implicitly-closed-by-parent/warnings.json similarity index 58% rename from packages/svelte/tests/validator/samples/implicitly-closed-tag/warnings.json rename to packages/svelte/tests/validator/samples/implicitly-closed-by-parent/warnings.json index 7a3873842d..e495697d49 100644 --- a/packages/svelte/tests/validator/samples/implicitly-closed-tag/warnings.json +++ b/packages/svelte/tests/validator/samples/implicitly-closed-by-parent/warnings.json @@ -1,26 +1,26 @@ [ { "code": "element_implicitly_closed", - "message": "The tag `

` was implicitly closed by the parent or a next element. This may cause DOM structure being other than expected one.", + "message": "The tag `

` was implicitly closed by the parent or a next element. This may cause DOM structure being other than expected one.", "start": { - "line": 4, - "column": 4 + "line": 1, + "column": 6 }, "end": { - "line": 4, - "column": 7 + "line": 1, + "column": 25 } }, { "code": "element_implicitly_closed", "message": "The tag `
` was implicitly closed by the parent or a next element. This may cause DOM structure being other than expected one.", "start": { - "line": 3, - "column": 4 + "line": 4, + "column": 1 }, "end": { - "line": 3, - "column": 9 + "line": 4, + "column": 20 } } ] diff --git a/packages/svelte/tests/validator/samples/implicitly-closed-by-sibling/input.svelte b/packages/svelte/tests/validator/samples/implicitly-closed-by-sibling/input.svelte new file mode 100644 index 0000000000..7721f2f380 --- /dev/null +++ b/packages/svelte/tests/validator/samples/implicitly-closed-by-sibling/input.svelte @@ -0,0 +1,9 @@ +
+

+ +

+
+ +
+

+
diff --git a/packages/svelte/tests/validator/samples/implicitly-closed-by-sibling/warnings.json b/packages/svelte/tests/validator/samples/implicitly-closed-by-sibling/warnings.json new file mode 100644 index 0000000000..3a3324c826 --- /dev/null +++ b/packages/svelte/tests/validator/samples/implicitly-closed-by-sibling/warnings.json @@ -0,0 +1,26 @@ +[ + { + "code": "element_implicitly_closed", + "message": "The tag `

` was implicitly closed by the parent or a next element. This may cause DOM structure being other than expected one.", + "start": { + "line": 2, + "column": 1 + }, + "end": { + "line": 2, + "column": 18 + } + }, + { + "code": "element_implicitly_closed", + "message": "The tag `

` was implicitly closed by the parent or a next element. This may cause DOM structure being other than expected one.", + "start": { + "line": 8, + "column": 1 + }, + "end": { + "line": 8, + "column": 18 + } + } +] diff --git a/packages/svelte/tests/validator/samples/implicitly-closed-tag/input.svelte b/packages/svelte/tests/validator/samples/implicitly-closed-tag/input.svelte deleted file mode 100644 index 02d7a1a7aa..0000000000 --- a/packages/svelte/tests/validator/samples/implicitly-closed-tag/input.svelte +++ /dev/null @@ -1,6 +0,0 @@ -

- -
-

-

-