From ad7cc71e60263eeb631f167a10ab9fe49a0b1f7b Mon Sep 17 00:00:00 2001 From: Rich Harris Date: Wed, 17 Jul 2024 15:25:50 -0400 Subject: [PATCH] Apply suggestions from code review --- packages/svelte/messages/compile-warnings/template.md | 2 +- packages/svelte/src/compiler/warnings.js | 4 ++-- .../tests/validator/samples/attribute-quoted/warnings.json | 4 ++-- 3 files changed, 5 insertions(+), 5 deletions(-) diff --git a/packages/svelte/messages/compile-warnings/template.md b/packages/svelte/messages/compile-warnings/template.md index f5572f8302..3460e1098e 100644 --- a/packages/svelte/messages/compile-warnings/template.md +++ b/packages/svelte/messages/compile-warnings/template.md @@ -16,7 +16,7 @@ ## attribute_quoted -> Quoted attributes on components and custom elements will be stringified in a future version of Svelte. If this isn't what you want, remove the quotes. +> Quoted attributes on components and custom elements will be stringified in a future version of Svelte. If this isn't what you want, remove the quotes ## bind_invalid_each_rest diff --git a/packages/svelte/src/compiler/warnings.js b/packages/svelte/src/compiler/warnings.js index cef78b4486..d9c197cf75 100644 --- a/packages/svelte/src/compiler/warnings.js +++ b/packages/svelte/src/compiler/warnings.js @@ -688,11 +688,11 @@ export function attribute_invalid_property_name(node, wrong, right) { } /** - * Quoted attributes on components and custom elements will be stringified in a future version of Svelte. If this isn't what you want, remove the quotes. + * Quoted attributes on components and custom elements will be stringified in a future version of Svelte. If this isn't what you want, remove the quotes * @param {null | NodeLike} node */ export function attribute_quoted(node) { - w(node, "attribute_quoted", "Quoted attributes on components and custom elements will be stringified in a future version of Svelte. If this isn't what you want, remove the quotes."); + w(node, "attribute_quoted", "Quoted attributes on components and custom elements will be stringified in a future version of Svelte. If this isn't what you want, remove the quotes"); } /** diff --git a/packages/svelte/tests/validator/samples/attribute-quoted/warnings.json b/packages/svelte/tests/validator/samples/attribute-quoted/warnings.json index a5a7aa4d1c..3304b5c6b4 100644 --- a/packages/svelte/tests/validator/samples/attribute-quoted/warnings.json +++ b/packages/svelte/tests/validator/samples/attribute-quoted/warnings.json @@ -25,7 +25,7 @@ }, { "code": "attribute_quoted", - "message": "Quoted attributes on components and custom elements will be stringified in a future version of Svelte. If this isn't what you want, remove the quotes.", + "message": "Quoted attributes on components and custom elements will be stringified in a future version of Svelte. If this isn't what you want, remove the quotes", "start": { "column": 14, "line": 18 @@ -37,7 +37,7 @@ }, { "code": "attribute_quoted", - "message": "Quoted attributes on components and custom elements will be stringified in a future version of Svelte. If this isn't what you want, remove the quotes.", + "message": "Quoted attributes on components and custom elements will be stringified in a future version of Svelte. If this isn't what you want, remove the quotes", "start": { "column": 16, "line": 21