From aa9b2dd5f3c54ae9918ec6659760cfaf1f7d8892 Mon Sep 17 00:00:00 2001
From: Carlos Ivanchuk <105121122+buhodev@users.noreply.github.com>
Date: Tue, 21 Feb 2023 12:27:49 -0400
Subject: [PATCH] fix: omit a11y warning on `<video>` when `aria-hidden="true"`
 (#7880)

Related to #5967. Closes #7874

---------

Co-authored-by: Simon H <5968653+dummdidumm@users.noreply.github.com>
Co-authored-by: Yuichiro Yamashita <xydybaseball@gmail.com>
---
 src/compiler/compile/nodes/Element.ts         |  5 +++-
 .../a11y-media-has-caption/input.svelte       |  3 ++
 .../a11y-media-has-caption/warnings.json      | 30 +++++++++++++++++++
 3 files changed, 37 insertions(+), 1 deletion(-)

diff --git a/src/compiler/compile/nodes/Element.ts b/src/compiler/compile/nodes/Element.ts
index cb3d8c718f..62e0de51bf 100644
--- a/src/compiler/compile/nodes/Element.ts
+++ b/src/compiler/compile/nodes/Element.ts
@@ -718,7 +718,10 @@ export default class Element extends Node {
 		}
 
 		if (this.name === 'video') {
-			if (attribute_map.has('muted')) {
+			const aria_hidden_attribute = attribute_map.get('aria-hidden');
+			const aria_hidden_exist = aria_hidden_attribute && aria_hidden_attribute.get_static_value();
+
+			if (attribute_map.has('muted') || aria_hidden_exist === 'true') {
 				return;
 			}
 
diff --git a/test/validator/samples/a11y-media-has-caption/input.svelte b/test/validator/samples/a11y-media-has-caption/input.svelte
index 6d98fd3734..30f9a05f91 100644
--- a/test/validator/samples/a11y-media-has-caption/input.svelte
+++ b/test/validator/samples/a11y-media-has-caption/input.svelte
@@ -2,3 +2,6 @@
 <video></video>
 <video><track /></video>
 <audio></audio>
+<video aria-hidden></video>
+<video aria-hidden="false"></video>
+<video aria-hidden="true"></video>
diff --git a/test/validator/samples/a11y-media-has-caption/warnings.json b/test/validator/samples/a11y-media-has-caption/warnings.json
index 72c2caae53..6db618f03c 100644
--- a/test/validator/samples/a11y-media-has-caption/warnings.json
+++ b/test/validator/samples/a11y-media-has-caption/warnings.json
@@ -28,5 +28,35 @@
       "column": 0,
       "line": 3
     }
+  },
+  {
+    "code": "a11y-media-has-caption",
+    "end": {
+      "character": 124,
+      "column": 27,
+      "line": 5
+    },
+    "message": "A11y: <video> elements must have a <track kind=\"captions\">",
+    "pos": 97,
+    "start": {
+      "character": 97,
+      "column": 0,
+      "line": 5
+    }
+  },
+  {
+    "code": "a11y-media-has-caption",
+    "end": {
+      "character": 160,
+      "column": 35,
+      "line": 6
+    },
+    "message": "A11y: <video> elements must have a <track kind=\"captions\">",
+    "pos": 125,
+    "start": {
+      "character": 125,
+      "column": 0,
+      "line": 6
+    }
   }
 ]